Re: NULL pointer at kset_find_obj

2013-04-03 Thread Rusty Russell
David Howells writes: > Btw, one thing I've noticed is that sysfs appears to be able to execute code > in the module by way of parameter alterations before the module is completely > set up. It's preceeded by the module parameter parsing, which can do the same thing, so I don't think it's an

Re: NULL pointer at kset_find_obj

2013-04-03 Thread David Howells
Rusty Russell wrote: > > I think this bit should be waved in front of Rusty. It looks like it > > might be a bug in error handling code. > > It does look like it, but I can't see it. The module code doesn't see > an error (presumably sig_enforce is false), so we continue processing > the

Re: NULL pointer at kset_find_obj

2013-04-03 Thread David Howells
CAI Qian wrote: > > Can you check back earlier in the dmesg to see whether the kernel tried to > > load the key? -11 is presumably -EAGAIN - in which case no such key was > > found > > (rather than there being a cached lookup failure which is what -ENOKEY would > > indicate). It is possible

Re: NULL pointer at kset_find_obj

2013-04-03 Thread Rusty Russell
David Howells writes: > CAI Qian wrote: > >> Just booted the latest mainline, >> >> [ 35.217698] Request for unknown module key 'Magrathea: Glacier signing >> key: 8b7774b08bc4ee9637073434c10f0823f6fbe523' err -11 > > Can you check back earlier in the dmesg to see whether the kernel tried to

Re: NULL pointer at kset_find_obj

2013-04-03 Thread Rusty Russell
David Howells dhowe...@redhat.com writes: Btw, one thing I've noticed is that sysfs appears to be able to execute code in the module by way of parameter alterations before the module is completely set up. It's preceeded by the module parameter parsing, which can do the same thing, so I don't

Re: NULL pointer at kset_find_obj

2013-04-03 Thread Rusty Russell
David Howells dhowe...@redhat.com writes: CAI Qian caiq...@redhat.com wrote: Just booted the latest mainline, [ 35.217698] Request for unknown module key 'Magrathea: Glacier signing key: 8b7774b08bc4ee9637073434c10f0823f6fbe523' err -11 Can you check back earlier in the dmesg to see

Re: NULL pointer at kset_find_obj

2013-04-03 Thread David Howells
CAI Qian caiq...@redhat.com wrote: Can you check back earlier in the dmesg to see whether the kernel tried to load the key? -11 is presumably -EAGAIN - in which case no such key was found (rather than there being a cached lookup failure which is what -ENOKEY would indicate). It is

Re: NULL pointer at kset_find_obj

2013-04-03 Thread David Howells
Rusty Russell ru...@rustcorp.com.au wrote: I think this bit should be waved in front of Rusty. It looks like it might be a bug in error handling code. It does look like it, but I can't see it. The module code doesn't see an error (presumably sig_enforce is false), so we continue

Re: NULL pointer at kset_find_obj

2013-04-02 Thread CAI Qian
- Original Message - > From: "David Howells" > To: "CAI Qian" , ru...@rustcorp.com.au > Cc: dhowe...@redhat.com, "LKML" > Sent: Wednesday, April 3, 2013 1:38:50 AM > Subject: Re: NULL pointer at kset_find_obj > > CAI

Re: NULL pointer at kset_find_obj

2013-04-02 Thread David Howells
CAI Qian wrote: > Just booted the latest mainline, > > [ 35.217698] Request for unknown module key 'Magrathea: Glacier signing > key: 8b7774b08bc4ee9637073434c10f0823f6fbe523' err -11 Can you check back earlier in the dmesg to see whether the kernel tried to load the key? -11 is presumably

NULL pointer at kset_find_obj

2013-04-02 Thread CAI Qian
Just booted the latest mainline, [ 35.217698] Request for unknown module key 'Magrathea: Glacier signing key: 8b7774b08bc4ee9637073434c10f0823f6fbe523' err -11 [ 35.218511] BUG: unable to handle kernel paging request at a03093f0 [ 35.218521] IP: [] kset_find_obj+0x30/0x80 [

NULL pointer at kset_find_obj

2013-04-02 Thread CAI Qian
Just booted the latest mainline, [ 35.217698] Request for unknown module key 'Magrathea: Glacier signing key: 8b7774b08bc4ee9637073434c10f0823f6fbe523' err -11 [ 35.218511] BUG: unable to handle kernel paging request at a03093f0 [ 35.218521] IP: [81304710]

Re: NULL pointer at kset_find_obj

2013-04-02 Thread David Howells
CAI Qian caiq...@redhat.com wrote: Just booted the latest mainline, [ 35.217698] Request for unknown module key 'Magrathea: Glacier signing key: 8b7774b08bc4ee9637073434c10f0823f6fbe523' err -11 Can you check back earlier in the dmesg to see whether the kernel tried to load the key? -11

Re: NULL pointer at kset_find_obj

2013-04-02 Thread CAI Qian
- Original Message - From: David Howells dhowe...@redhat.com To: CAI Qian caiq...@redhat.com, ru...@rustcorp.com.au Cc: dhowe...@redhat.com, LKML linux-kernel@vger.kernel.org Sent: Wednesday, April 3, 2013 1:38:50 AM Subject: Re: NULL pointer at kset_find_obj CAI Qian caiq