Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-25 Thread Johan Hovold
On Thu, May 24, 2018 at 06:32:37AM -0700, Tony Lindgren wrote: > * Johan Hovold [180524 09:20]: > > On Mon, May 21, 2018 at 08:48:32AM -0700, Tony Lindgren wrote: > > > Well if you have some better mechanism in mind let's try it out. Short of > > > sprinkling pm_runtime_force_suspend/resume calls

Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-24 Thread Tony Lindgren
* Johan Hovold [180524 09:20]: > On Mon, May 21, 2018 at 08:48:32AM -0700, Tony Lindgren wrote: > > > > Yes the bug for closed ports needs to be fixed for sure. > > I did some forensic on this and it seems this problem has "always" been > there. Specifically, closed ports have never been runtime

Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-24 Thread Johan Hovold
On Mon, May 21, 2018 at 08:48:32AM -0700, Tony Lindgren wrote: > * Johan Hovold [180521 13:50]: > > On Thu, May 17, 2018 at 10:10:38AM -0700, Tony Lindgren wrote: > > > * Johan Hovold [180517 10:12]: > > > Well in that case we should just stick with -1 value for the > > > autosuspend. And just d

Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-21 Thread Tony Lindgren
* Johan Hovold [180521 13:50]: > On Thu, May 17, 2018 at 10:10:38AM -0700, Tony Lindgren wrote: > > * Johan Hovold [180517 10:12]: > > > No, defaulting to "on" (i.e. calling pm_runtime_forbid()) wouldn't work > > > either as that would also prevent the device from runtime suspending > > > just as

Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-21 Thread Johan Hovold
On Thu, May 17, 2018 at 10:10:38AM -0700, Tony Lindgren wrote: > * Johan Hovold [180517 10:12]: > > [ Sorry about the late reply. ] > > > > On Wed, May 09, 2018 at 06:57:06AM -0700, Tony Lindgren wrote: > > > * Johan Hovold [180509 13:12]: > > > > > > It seems we really should not be using the

Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-17 Thread Tony Lindgren
* Johan Hovold [180517 10:12]: > [ Sorry about the late reply. ] > > On Wed, May 09, 2018 at 06:57:06AM -0700, Tony Lindgren wrote: > > * Johan Hovold [180509 13:12]: > > > > It seems we really should not be using the negative autosuspend to > > > configure the RPM behaviour the way these drive

Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-17 Thread Johan Hovold
[ Sorry about the late reply. ] On Wed, May 09, 2018 at 06:57:06AM -0700, Tony Lindgren wrote: > * Johan Hovold [180509 13:12]: > > It seems we really should not be using the negative autosuspend to > > configure the RPM behaviour the way these drivers do. Perhaps a new > > mechanism is needed.

Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-09 Thread Tony Lindgren
* Johan Hovold [180509 13:12]: > While this seems to fix the idling of closed ports here too, I'm not > sure we can move use_autosuspend to startup() like this. > > First, this flag should be set before registering the tty so that udev > can be used to update the attributes. > > Second, this pre

OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))

2018-05-09 Thread Johan Hovold
[ Updating subject and adding linux-serial, linux-pm and linux-omap. ] On Tue, May 08, 2018 at 09:49:04AM -0700, Tony Lindgren wrote: > * Tony Lindgren [180508 08:54]: > > * Tony Lindgren [180508 08:47]: > > > * Tony Lindgren [180508 08:22]: > > > > * Johan Hovold [180508 07:00]: > > > > > Wit