Re: Ooops unmounting a defect DVD
Am Samstag, 29. Januar 2005 15:46 schrieb James Bottomley: > I wouldn't have noticed this at all since you didn't send it to the scsi > list, but fortunately, Al Viro drew it politely to my attention as > another example of SCSI refcounting problems. Sorry, it happening in cdrom_release fooled me into considering it a generic cdrom problem. > The issue seems to be that we have a spurious scsi_cd_put() on the error > path of sr_open(). The sr_block_..() functions are the "real" block > opens and should be refcounted, the sr_...() are the pseudo cdrom opens > and should not be refcounted. > > Could you try this and see if it fixes the problem? It fully fixes the problem. Thank you. Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Ooops unmounting a defect DVD
I wouldn't have noticed this at all since you didn't send it to the scsi list, but fortunately, Al Viro drew it politely to my attention as another example of SCSI refcounting problems. The issue seems to be that we have a spurious scsi_cd_put() on the error path of sr_open(). The sr_block_..() functions are the "real" block opens and should be refcounted, the sr_...() are the pseudo cdrom opens and should not be refcounted. Could you try this and see if it fixes the problem? James = drivers/scsi/sr.c 1.124 vs edited = --- 1.124/drivers/scsi/sr.c 2005-01-29 08:30:34 -06:00 +++ edited/drivers/scsi/sr.c2005-01-29 08:39:09 -06:00 @@ -544,7 +544,6 @@ return 0; error_out: - scsi_cd_put(cd); return retval; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
sr.c kobject refcounting got buggered [Re: Ooops unmounting a defect DVD]
On Fri, Jan 28, 2005 at 06:42:44PM +0100, Oliver Neukum wrote:
> I got this oops unmounting by "eject" a defect DVD on a genuine
> SCSI drive.
Looks like failing IO + close afterwards - umount is irrelevant here.
And oops itself looks like cdrom_release((void *)0x18, whatever),
called from sr_block_release(). Which is
static int sr_block_release(struct inode *inode, struct file *file)
{
int ret;
struct scsi_cd *cd = scsi_cd(inode->i_bdev->bd_disk);
ret = cdrom_release(&cd->cdi, file);
and since cdi is at offset 0x18 on i386, we have
scsi_cd(inode->i_bdev->bd_disk) == NULL
IOW,
inode->i_bdev->bd_disk->private_data == NULL
at the time of sr_block_release(). Which would be a problem, indeed.
AFAICS, the only place that could cause that crap is
static void sr_kref_release(struct kref *kref)
{
struct scsi_cd *cd = container_of(kref, struct scsi_cd, kref);
struct gendisk *disk = cd->disk;
spin_lock(&sr_index_lock);
clear_bit(disk->first_minor, sr_index_bits);
spin_unlock(&sr_index_lock);
unregister_cdrom(&cd->cdi);
disk->private_data = NULL;
put_disk(disk);
kfree(cd);
}
so we have scsi_cd refcount reaching zero (and scsi_cd being freed) before
the final close of /dev/sr...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Ooops unmounting a defect DVD
Hi, I got this oops unmounting by "eject" a defect DVD on a genuine SCSI drive. Jan 27 23:30:03 oenone kernel: Buffer I/O error on device sr0, logical block 1972790 Jan 27 23:30:03 oenone kernel: dc395x: eh_abort: (pid#733021) target=<01-0> cmd=dfc99c40 Jan 27 23:30:03 oenone kernel: dc395x: eh_abort: Command not found<6>dc395x: eh_bus_reset: (pid#733021) target=<01-0> cmd=dfc99c40 Jan 27 23:30:03 oenone kernel: dc395x: doing_srb_done: pids Jan 27 23:30:13 oenone kernel: dc395x: Target 01: Sync: 48ns Offset 8 (20.8 MB/s) Jan 27 23:30:24 oenone kernel: dc395x: sg_update_list: sg_to_virt failed Jan 27 23:30:24 oenone kernel: SCSI error : <0 0 1 0> return code = 0x802 Jan 27 23:30:24 oenone kernel: sr0: Current: sense key=0x4 Jan 27 23:30:24 oenone kernel: ASC=0x15 ASCQ=0x1 Jan 27 23:30:24 oenone kernel: Info fld=0x1e1a37 Jan 27 23:30:24 oenone kernel: end_request: I/O error, dev sr0, sector 7891164 Jan 27 23:30:24 oenone kernel: Buffer I/O error on device sr0, logical block 1972791 Jan 27 23:30:24 oenone kernel: dc395x: eh_abort: (pid#733885) target=<01-0> cmd=dfc99940 Jan 27 23:30:24 oenone kernel: dc395x: eh_abort: Command not found<6>dc395x: eh_bus_reset: (pid#733885) target=<01-0> cmd=dfc99940 Jan 27 23:30:24 oenone kernel: dc395x: doing_srb_done: pids Jan 27 23:30:34 oenone kernel: dc395x: Target 01: Sync: 48ns Offset 8 (20.8 MB/s) Jan 27 23:30:44 oenone kernel: dc395x: sg_update_list: sg_to_virt failed Jan 27 23:30:44 oenone kernel: SCSI error : <0 0 1 0> return code = 0x802 Jan 27 23:30:44 oenone kernel: sr0: Current: sense key=0x4 Jan 27 23:30:44 oenone kernel: ASC=0x15 ASCQ=0x1 Jan 27 23:30:44 oenone kernel: Info fld=0x1e1a38 Jan 27 23:30:44 oenone kernel: end_request: I/O error, dev sr0, sector 7891168 Jan 27 23:30:44 oenone kernel: Buffer I/O error on device sr0, logical block 1972792 Jan 27 23:30:44 oenone kernel: dc395x: eh_abort: (pid#734783) target=<01-0> cmd=dfc99c40 Jan 27 23:30:44 oenone kernel: dc395x: eh_abort: Command not found<6>dc395x: eh_bus_reset: (pid#734783) target=<01-0> cmd=dfc99c40 Jan 27 23:30:44 oenone kernel: dc395x: doing_srb_done: pids Jan 27 23:30:54 oenone kernel: dc395x: Target 01: Sync: 48ns Offset 8 (20.8 MB/s) Jan 27 23:31:05 oenone kernel: dc395x: sg_update_list: sg_to_virt failed Jan 27 23:31:05 oenone kernel: SCSI error : <0 0 1 0> return code = 0x802 Jan 27 23:31:05 oenone kernel: sr0: Current: sense key=0x4 Jan 27 23:31:05 oenone kernel: ASC=0x15 ASCQ=0x1 Jan 27 23:31:05 oenone kernel: Info fld=0x1e1a39 Jan 27 23:31:05 oenone kernel: end_request: I/O error, dev sr0, sector 7891172 Jan 27 23:31:05 oenone kernel: Buffer I/O error on device sr0, logical block 1972793 Jan 27 23:31:05 oenone kernel: dc395x: eh_abort: (pid#735658) target=<01-0> cmd=dfc99940 Jan 27 23:31:05 oenone kernel: dc395x: eh_abort: Command not found<6>dc395x: eh_bus_reset: (pid#735658) target=<01-0> cmd=dfc99940 Jan 27 23:31:05 oenone kernel: dc395x: doing_srb_done: pids Jan 27 23:31:15 oenone kernel: dc395x: Target 01: Sync: 48ns Offset 8 (20.8 MB/s) Jan 27 23:31:15 oenone kernel: scsi: Device offlined - not ready after error recovery: host 0 channel 0 id 1 lun 0 Jan 27 23:31:15 oenone kernel: scsi0 (1:0): rejecting I/O to offline device Jan 27 23:31:15 oenone kernel: scsi0 (1:0): rejecting I/O to offline device Jan 27 23:31:15 oenone kernel: Buffer I/O error on device sr0, logical block 1972794 Jan 27 23:31:15 oenone kernel: scsi0 (1:0): rejecting I/O to offline device Jan 27 23:31:15 oenone kernel: Unable to handle kernel NULL pointer dereference at virtual address 0018 Jan 27 23:31:15 oenone kernel: printing eip: Jan 27 23:31:15 oenone kernel: c02d183e Jan 27 23:31:15 oenone kernel: *pde = Jan 27 23:31:15 oenone kernel: Oops: [#1] Jan 27 23:31:15 oenone kernel: Modules linked in: paride usb_storage snd_intel8x0 snd_ac97_codec tuner tvaudio msp3400 bttv video_buf v4l2_common btcx_risc videodev usbserial nvram ipt_TOS ipt_LOG ipt_limit ipt_TCPMSS ipt_MASQUERADE ipt_pkttype ipt_state ipt_REJECT iptable_mangle iptable_filter ip6table_mangle ip_nat_ftp iptable_nat ip_conntrack_ftp ip_conntrack ip_tables ip6table_filter ip6_tables ipv6 usblp st Jan 27 23:31:15 oenone kernel: CPU:0 Jan 27 23:31:15 oenone kernel: EIP:0060:[]Not tainted VLI Jan 27 23:31:15 oenone kernel: EFLAGS: 00010297 (2.6.11-rc1) Jan 27 23:31:15 oenone kernel: EIP is at cdrom_release+0x1e/0x110 Jan 27 23:31:15 oenone kernel: eax: 0018 ebx: 0018 ecx: c02ba400 edx: Jan 27 23:31:15 oenone kernel: esi: cee35ea4 edi: dfc3d540 ebp: esp: d4a51f28 Jan 27 23:31:15 oenone kernel: ds: 007b es: 007b ss: 0068 Jan 27 23:31:15 oenone kernel: Process umount (pid: 13824, threadinfo=d4a5 task=d4205020) Jan 27 23:31:15 oenone kernel: Stack: cee35e40 cee35ea4 dfc3d540 c02ba415 cee35e40 Jan 27 23:31:15 oenone kernel:c0159bc5 d6c17800 c049db00 d4a5 c0158063 0
