hi, Race is as follows. Process A forks process B, both being part of the same session. Then, A calls disassociate_ctty while B forks C:
A B ---- ---- fork() copy_signal() dissasociate_ctty() .... attach_pid(p, PIDTYPE_SID, p->signal->session); Now, C can have current->signal->tty pointing to a freed tty structure, as it hasn't yet been added to the session group (to have its controlling tty cleared on the diassociate_ctty() call). This has shown up as an oops but could be even more serious. I haven't tried to create a test case, but a customer has verified that the patch below resolves the issue, which was occuring quite frequently. I'll try and post the test case if i can. The patch simply checks for a NULL tty *after* it has been attached to the proper session group and clears it as necessary. Alternatively, we could simply do the tty assignment after the the process is added to the proper session group. thanks, -Jason Signed-off-by: Jason Baron <[EMAIL PROTECTED]> --- linux-2.6.git/kernel/fork.c.bak 2005-09-06 13:42:14.000000000 -0400 +++ linux-2.6.git/kernel/fork.c 2005-09-06 13:43:47.000000000 -0400 @@ -1115,6 +1115,9 @@ static task_t *copy_process(unsigned lon __get_cpu_var(process_counts)++; } + if (!current->signal->tty && p->signal->tty) + p->signal->tty = NULL; + nr_threads++; total_forks++; write_unlock_irq(&tasklist_lock); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/