Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-16 Thread Martyn Welch
Nick, Sorry for the delay in responding. I'm staring at the manual for the ca91c142 and the relevant bits in the VSIx_CTL registers definitely need to be set to 0 for A16, likewise with the LM_CTL register. The pattern (3<<16) would enable one of the "reserved" address spaces. Martyn On

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-16 Thread Martyn Welch
On 16/06/14 10:56, Dan Carpenter wrote: On Mon, Jun 16, 2014 at 10:47:25AM +0100, Martyn Welch wrote: Nick, Sorry for the delay in responding. I'm staring at the manual for the ca91c142 and the relevant bits in the VSIx_CTL registers definitely need to be set to 0 for A16, likewise with the

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-16 Thread Dan Carpenter
On Mon, Jun 16, 2014 at 10:47:25AM +0100, Martyn Welch wrote: > Nick, > > Sorry for the delay in responding. > > I'm staring at the manual for the ca91c142 and the relevant bits in > the VSIx_CTL registers definitely need to be set to 0 for A16, > likewise with the LM_CTL register. The pattern

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-16 Thread Dan Carpenter
On Mon, Jun 16, 2014 at 10:47:25AM +0100, Martyn Welch wrote: Nick, Sorry for the delay in responding. I'm staring at the manual for the ca91c142 and the relevant bits in the VSIx_CTL registers definitely need to be set to 0 for A16, likewise with the LM_CTL register. The pattern (316)

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-16 Thread Martyn Welch
On 16/06/14 10:56, Dan Carpenter wrote: On Mon, Jun 16, 2014 at 10:47:25AM +0100, Martyn Welch wrote: Nick, Sorry for the delay in responding. I'm staring at the manual for the ca91c142 and the relevant bits in the VSIx_CTL registers definitely need to be set to 0 for A16, likewise with the

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-16 Thread Martyn Welch
Nick, Sorry for the delay in responding. I'm staring at the manual for the ca91c142 and the relevant bits in the VSIx_CTL registers definitely need to be set to 0 for A16, likewise with the LM_CTL register. The pattern (316) would enable one of the reserved address spaces. Martyn On

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-12 Thread Dan Carpenter
Martyn, Nick Krause emailed me privately that he's not able to get git to work. Normally for bug fixes, we would patch this up ourselves. The offending code was introduced in: commit 2b82beb8c1bc81b3dde69d16cacbc22546681acf Author: Martyn Welch Date: Thu Feb 18 15:13:19 2010 +

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-12 Thread Dan Carpenter
On Thu, Jun 12, 2014 at 10:33:09AM -0400, nick wrote: > Here is the fixed patch. Having issues with using Thunderbird > so just used Evolution for now. > Nick Please read the first paragraph of: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-12 Thread nick
Here is the fixed patch. Having issues with using Thunderbird so just used Evolution for now. Nick --- drivers/vme/bridges/vme_ca91cx42.h.orig 2014-06-11 22:50:29.339671939 -0400 +++ drivers/vme/bridges/vme_ca91cx42.h 2014-06-11 23:15:36.027685173 -0400 Fixes bug issues with wrong bus width

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-12 Thread nick
Here is the fixed patch. Having issues with using Thunderbird so just used Evolution for now. Nick --- drivers/vme/bridges/vme_ca91cx42.h.orig 2014-06-11 22:50:29.339671939 -0400 +++ drivers/vme/bridges/vme_ca91cx42.h 2014-06-11 23:15:36.027685173 -0400 Fixes bug issues with wrong bus width

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-12 Thread Dan Carpenter
On Thu, Jun 12, 2014 at 10:33:09AM -0400, nick wrote: Here is the fixed patch. Having issues with using Thunderbird so just used Evolution for now. Nick Please read the first paragraph of: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏‏

2014-06-12 Thread Dan Carpenter
Martyn, Nick Krause emailed me privately that he's not able to get git to work. Normally for bug fixes, we would patch this up ourselves. The offending code was introduced in: commit 2b82beb8c1bc81b3dde69d16cacbc22546681acf Author: Martyn Welch martyn.we...@ge.com Date: Thu Feb 18 15:13:19

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏

2014-06-11 Thread gre...@linuxfoundation.org
On Thu, Jun 12, 2014 at 04:17:36AM +, Nick Krause wrote: > Here is the fixed patch as per Greg's recommendations. Unforunalty my email > client removes tabs so I will have to be sending it as a patch file if that's > Ok. > Nick HTML is rejected by the mailing lists, and we can't take a base64

Re: PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]

2014-06-11 Thread gre...@linuxfoundation.org
On Thu, Jun 12, 2014 at 03:44:34AM +, Nick Krause wrote: > Hey Fellow Developers, > This is my first patch so if there are any errors please reply as i will > fix them. Below is the patch. > -- drivers/vme/bridges/vme_ca91cx42.h.orig    2014-06-11 22:50:29.339671939 > -0400 > +++

PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]

2014-06-11 Thread Nick Krause
Hey Fellow Developers, This is my first patch so if there are any errors please reply as i will fix them. Below is the patch. -- drivers/vme/bridges/vme_ca91cx42.h.orig    2014-06-11 22:50:29.339671939 -0400 +++ drivers/vme/bridges/vme_ca91cx42.h    2014-06-11 23:15:36.027685173 -0400 @@ -526,7

PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]

2014-06-11 Thread Nick Krause
Hey Fellow Developers, This is my first patch so if there are any errors please reply as i will fix them. Below is the patch. -- drivers/vme/bridges/vme_ca91cx42.h.orig    2014-06-11 22:50:29.339671939 -0400 +++ drivers/vme/bridges/vme_ca91cx42.h    2014-06-11 23:15:36.027685173 -0400 @@ -526,7

Re: PATCH[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]

2014-06-11 Thread gre...@linuxfoundation.org
On Thu, Jun 12, 2014 at 03:44:34AM +, Nick Krause wrote: Hey Fellow Developers, This is my first patch so if there are any errors please reply as i will fix them. Below is the patch. -- drivers/vme/bridges/vme_ca91cx42.h.orig    2014-06-11 22:50:29.339671939 -0400 +++

Re: PATCH[[vme/bridges/vme_ca91cx42.c:1382: Bad if test Bug Fix]‏

2014-06-11 Thread gre...@linuxfoundation.org
On Thu, Jun 12, 2014 at 04:17:36AM +, Nick Krause wrote: Here is the fixed patch as per Greg's recommendations. Unforunalty my email client removes tabs so I will have to be sending it as a patch file if that's Ok. Nick HTML is rejected by the mailing lists, and we can't take a base64