Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Pekka Enberg
On 4/11/07, Rusty Russell <[EMAIL PROTECTED]> wrote: What a question! end_request() doesn't end a request! What a crazy idea! Aah, indeed, end_request() uses req->hard_cur_sectors while end_entire_request() uses req->hard_nr_sectors which I missed. On 4/11/07, Rusty Russell <[EMAIL

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Rusty Russell
On Tue, 2007-04-10 at 14:36 +0300, Pekka Enberg wrote: > On 4/10/07, Rusty Russell <[EMAIL PROTECTED]> wrote: > > > +/* Jens gave me this nice helper to end all chunks of a request. */ > > > +static void end_entire_request(struct request *req, int uptodate) > > > +{ > > > + if

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Pekka Enberg
On 4/10/07, Rusty Russell <[EMAIL PROTECTED]> wrote: > +/* Jens gave me this nice helper to end all chunks of a request. */ > +static void end_entire_request(struct request *req, int uptodate) > +{ > + if (end_that_request_first(req, uptodate, req->hard_nr_sectors)) > +

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Pekka Enberg
Hi Rusty, On 4/10/07, Rusty Russell <[EMAIL PROTECTED]> wrote: +/* Jens gave me this nice helper to end all chunks of a request. */ +static void end_entire_request(struct request *req, int uptodate) +{ + if (end_that_request_first(req, uptodate, req->hard_nr_sectors)) +

PATCH 7/8] lguest: the block driver

2007-04-10 Thread Rusty Russell
Lguest block driver A simple block driver for lguest. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/block/Makefile |1 drivers/block/lguest_blk.c | 271 2 files changed, 272 insertions(+)

PATCH 7/8] lguest: the block driver

2007-04-10 Thread Rusty Russell
Lguest block driver A simple block driver for lguest. Signed-off-by: Rusty Russell [EMAIL PROTECTED] --- drivers/block/Makefile |1 drivers/block/lguest_blk.c | 271 2 files changed, 272 insertions(+)

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Pekka Enberg
Hi Rusty, On 4/10/07, Rusty Russell [EMAIL PROTECTED] wrote: +/* Jens gave me this nice helper to end all chunks of a request. */ +static void end_entire_request(struct request *req, int uptodate) +{ + if (end_that_request_first(req, uptodate, req-hard_nr_sectors)) + BUG();

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Pekka Enberg
On 4/10/07, Rusty Russell [EMAIL PROTECTED] wrote: +/* Jens gave me this nice helper to end all chunks of a request. */ +static void end_entire_request(struct request *req, int uptodate) +{ + if (end_that_request_first(req, uptodate, req-hard_nr_sectors)) + BUG(); +

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Rusty Russell
On Tue, 2007-04-10 at 14:36 +0300, Pekka Enberg wrote: On 4/10/07, Rusty Russell [EMAIL PROTECTED] wrote: +/* Jens gave me this nice helper to end all chunks of a request. */ +static void end_entire_request(struct request *req, int uptodate) +{ + if (end_that_request_first(req,

Re: PATCH 7/8] lguest: the block driver

2007-04-10 Thread Pekka Enberg
On 4/11/07, Rusty Russell [EMAIL PROTECTED] wrote: What a question! end_request() doesn't end a request! What a crazy idea! Aah, indeed, end_request() uses req-hard_cur_sectors while end_entire_request() uses req-hard_nr_sectors which I missed. On 4/11/07, Rusty Russell [EMAIL PROTECTED]