Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 07:42:35PM +0100, Jens Axboe wrote: > > diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c > > index b6491c0..ca84f0b 100644 > > --- a/block/cfq-iosched.c > > +++ b/block/cfq-iosched.c > > @@ -961,8 +961,8 @@ __cfq_dispatch_requests(struct cfq_data *cfqd, struct >

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Jens Axboe
On Wed, Mar 21 2007, Johannes Weiner wrote: > Hi, > > I think I found where the NULL may come from. Please, anybody, do not > apply this patch before a trustful person reviewed it... Jens? ;) > > My thoughts on this are, that there are two possibilities cfqq->next_rq > could be NULL: End of

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Johannes Weiner
Hi, On Wed, Mar 21, 2007 at 08:04:00PM +0100, Johannes Weiner wrote: > Did I even get the right place on where the NULL pointer dereference > happens? :) No, I did not. Sorry for the noise. =Hannes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Dale Blount
On Wed, 2007-03-21 at 20:59 +0100, Jens Axboe wrote: > On Wed, Mar 21 2007, Dale Blount wrote: > > On Wed, 2007-03-21 at 14:09 -0400, Chuck Ebbert wrote: > > > Dale Blount wrote: > > > >> I'm puzzled why this is hitting Dan, but no one else has reported > > > >> anything. Dan, did 2.6.19 work for

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Dale Blount
On Wed, 2007-03-21 at 20:59 +0100, Jens Axboe wrote: On Wed, Mar 21 2007, Dale Blount wrote: On Wed, 2007-03-21 at 14:09 -0400, Chuck Ebbert wrote: Dale Blount wrote: I'm puzzled why this is hitting Dan, but no one else has reported anything. Dan, did 2.6.19 work for you?

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Johannes Weiner
Hi, On Wed, Mar 21, 2007 at 08:04:00PM +0100, Johannes Weiner wrote: Did I even get the right place on where the NULL pointer dereference happens? :) No, I did not. Sorry for the noise. =Hannes - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Jens Axboe
On Wed, Mar 21 2007, Johannes Weiner wrote: Hi, I think I found where the NULL may come from. Please, anybody, do not apply this patch before a trustful person reviewed it... Jens? ;) My thoughts on this are, that there are two possibilities cfqq-next_rq could be NULL: End of list or a

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-22 Thread Johannes Weiner
Hi, On Thu, Mar 22, 2007 at 07:42:35PM +0100, Jens Axboe wrote: diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index b6491c0..ca84f0b 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -961,8 +961,8 @@ __cfq_dispatch_requests(struct cfq_data *cfqd, struct cfq_queue

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Jens Axboe
On Wed, Mar 21 2007, Dale Blount wrote: > On Wed, 2007-03-21 at 14:09 -0400, Chuck Ebbert wrote: > > Dale Blount wrote: > > >> I'm puzzled why this is hitting Dan, but no one else has reported > > >> anything. Dan, did 2.6.19 work for you? > > > > > > Actually, I believe it is happening to me

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Johannes Weiner
Hi, I think I found where the NULL may come from. Please, anybody, do not apply this patch before a trustful person reviewed it... Jens? ;) My thoughts on this are, that there are two possibilities cfqq->next_rq could be NULL: End of list or a bug when it is set (or not set). But why does

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Chuck Ebbert
Dale Blount wrote: > On Wed, 2007-03-21 at 14:09 -0400, Chuck Ebbert wrote: >> Dale Blount wrote: I'm puzzled why this is hitting Dan, but no one else has reported anything. Dan, did 2.6.19 work for you? >>> Actually, I believe it is happening to me too. This is on a 4-disk raid5 >>>

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Dale Blount
On Wed, 2007-03-21 at 14:09 -0400, Chuck Ebbert wrote: > Dale Blount wrote: > >> I'm puzzled why this is hitting Dan, but no one else has reported > >> anything. Dan, did 2.6.19 work for you? > > > > Actually, I believe it is happening to me too. This is on a 4-disk raid5 > > with > > one

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Chuck Ebbert
Dale Blount wrote: >> I'm puzzled why this is hitting Dan, but no one else has reported >> anything. Dan, did 2.6.19 work for you? > > Actually, I believe it is happening to me too. This is on a 4-disk raid5 with > one failed disk on two 2-port sata_sil pci controller cards. > > The BUG below

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Dale Blount
> I'm puzzled why this is hitting Dan, but no one else has reported > anything. Dan, did 2.6.19 work for you? Actually, I believe it is happening to me too. This is on a 4-disk raid5 with one failed disk on two 2-port sata_sil pci controller cards. The BUG below is from 2.6.20.3, but I will try

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Dale Blount
I'm puzzled why this is hitting Dan, but no one else has reported anything. Dan, did 2.6.19 work for you? Actually, I believe it is happening to me too. This is on a 4-disk raid5 with one failed disk on two 2-port sata_sil pci controller cards. The BUG below is from 2.6.20.3, but I will try

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Chuck Ebbert
Dale Blount wrote: I'm puzzled why this is hitting Dan, but no one else has reported anything. Dan, did 2.6.19 work for you? Actually, I believe it is happening to me too. This is on a 4-disk raid5 with one failed disk on two 2-port sata_sil pci controller cards. The BUG below is from

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Dale Blount
On Wed, 2007-03-21 at 14:09 -0400, Chuck Ebbert wrote: Dale Blount wrote: I'm puzzled why this is hitting Dan, but no one else has reported anything. Dan, did 2.6.19 work for you? Actually, I believe it is happening to me too. This is on a 4-disk raid5 with one failed disk on two

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Chuck Ebbert
Dale Blount wrote: On Wed, 2007-03-21 at 14:09 -0400, Chuck Ebbert wrote: Dale Blount wrote: I'm puzzled why this is hitting Dan, but no one else has reported anything. Dan, did 2.6.19 work for you? Actually, I believe it is happening to me too. This is on a 4-disk raid5 with one failed

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Johannes Weiner
Hi, I think I found where the NULL may come from. Please, anybody, do not apply this patch before a trustful person reviewed it... Jens? ;) My thoughts on this are, that there are two possibilities cfqq-next_rq could be NULL: End of list or a bug when it is set (or not set). But why does

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-21 Thread Jens Axboe
On Wed, Mar 21 2007, Dale Blount wrote: On Wed, 2007-03-21 at 14:09 -0400, Chuck Ebbert wrote: Dale Blount wrote: I'm puzzled why this is hitting Dan, but no one else has reported anything. Dan, did 2.6.19 work for you? Actually, I believe it is happening to me too. This is on a

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-01 Thread Dan Williams
On 3/1/07, Jens Axboe <[EMAIL PROTECTED]> wrote: On Thu, Mar 01 2007, Frank Seidel wrote: > Am Mittwoch, 28. Februar 2007 19:02 schrieb Dan Williams: > > I can reliably reproduce a null pointer dereference on 2.6.20 and > > 2.6.21-rc2. I will keep digging to find the kernel version where > >

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-01 Thread Jens Axboe
On Thu, Mar 01 2007, Frank Seidel wrote: > Am Mittwoch, 28. Februar 2007 19:02 schrieb Dan Williams: > > I can reliably reproduce a null pointer dereference on 2.6.20 and > > 2.6.21-rc2. I will keep digging to find the kernel version where > > this last worked, but wanted to see if there were any

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-01 Thread Frank Seidel
Am Mittwoch, 28. Februar 2007 19:02 schrieb Dan Williams: > I can reliably reproduce a null pointer dereference on 2.6.20 and > 2.6.21-rc2. I will keep digging to find the kernel version where > this last worked, but wanted to see if there were any immediate > experiments I should try. > ... >

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-01 Thread Frank Seidel
Am Mittwoch, 28. Februar 2007 19:02 schrieb Dan Williams: I can reliably reproduce a null pointer dereference on 2.6.20 and 2.6.21-rc2. I will keep digging to find the kernel version where this last worked, but wanted to see if there were any immediate experiments I should try. ... Kernel

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-01 Thread Jens Axboe
On Thu, Mar 01 2007, Frank Seidel wrote: Am Mittwoch, 28. Februar 2007 19:02 schrieb Dan Williams: I can reliably reproduce a null pointer dereference on 2.6.20 and 2.6.21-rc2. I will keep digging to find the kernel version where this last worked, but wanted to see if there were any

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-03-01 Thread Dan Williams
On 3/1/07, Jens Axboe [EMAIL PROTECTED] wrote: On Thu, Mar 01 2007, Frank Seidel wrote: Am Mittwoch, 28. Februar 2007 19:02 schrieb Dan Williams: I can reliably reproduce a null pointer dereference on 2.6.20 and 2.6.21-rc2. I will keep digging to find the kernel version where this last

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-02-28 Thread Chuck Ebbert
Chuck Ebbert wrote: > There are two patches for raid5/6 out there that might fix this. I'll > attach them (the second just fixes a minor bug in the first one.) Never mind, those patches are already in 2.6.21-rc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-02-28 Thread Chuck Ebbert
Dan Williams wrote: > I can reliably reproduce a null pointer dereference on 2.6.20 and > 2.6.21-rc2. I will keep digging to find the kernel version where this > last worked, but wanted to see if there were any immediate experiments I > should try. > > The failure is caused by running tiobench

PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-02-28 Thread Dan Williams
I can reliably reproduce a null pointer dereference on 2.6.20 and 2.6.21-rc2. I will keep digging to find the kernel version where this last worked, but wanted to see if there were any immediate experiments I should try. The failure is caused by running tiobench on a MD raid6 array with 6 out of

PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-02-28 Thread Dan Williams
I can reliably reproduce a null pointer dereference on 2.6.20 and 2.6.21-rc2. I will keep digging to find the kernel version where this last worked, but wanted to see if there were any immediate experiments I should try. The failure is caused by running tiobench on a MD raid6 array with 6 out of

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-02-28 Thread Chuck Ebbert
Dan Williams wrote: I can reliably reproduce a null pointer dereference on 2.6.20 and 2.6.21-rc2. I will keep digging to find the kernel version where this last worked, but wanted to see if there were any immediate experiments I should try. The failure is caused by running tiobench on a MD

Re: PROBLEM: null pointer dereference in cfq_dispatch_requests (2.6.21-rc2 and 2.6.20)

2007-02-28 Thread Chuck Ebbert
Chuck Ebbert wrote: There are two patches for raid5/6 out there that might fix this. I'll attach them (the second just fixes a minor bug in the first one.) Never mind, those patches are already in 2.6.21-rc. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of