Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-30 Thread Christoph Lameter
On Mon, 30 Apr 2007, Arjan van de Ven wrote: > Christoph Lameter wrote: > > Umm you did not read the last bit of the description? It talks about firing > > all timers on all cpus at once. > > > > it talks about AVOIDING firing all timers on all cpus at once. H... Looked fine right now.

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-30 Thread Arjan van de Ven
Christoph Lameter wrote: Umm you did not read the last bit of the description? It talks about firing all timers on all cpus at once. it talks about AVOIDING firing all timers on all cpus at once. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-30 Thread Christoph Lameter
On Sat, 28 Apr 2007, Arjan van de Ven wrote: > > Hmmm... Yes but that looks like it comes from a different function. Slab > > calls > > > > __round_jiffies_relative(HZ, cpu)) > > > > And its description says: > > > > /** > > * > > * The exact rounding is skewed for each processor to avoid

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-30 Thread Christoph Lameter
On Sat, 28 Apr 2007, Arjan van de Ven wrote: Hmmm... Yes but that looks like it comes from a different function. Slab calls __round_jiffies_relative(HZ, cpu)) And its description says: /** * * The exact rounding is skewed for each processor to avoid all * processors

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-30 Thread Arjan van de Ven
Christoph Lameter wrote: Umm you did not read the last bit of the description? It talks about firing all timers on all cpus at once. it talks about AVOIDING firing all timers on all cpus at once. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-30 Thread Christoph Lameter
On Mon, 30 Apr 2007, Arjan van de Ven wrote: Christoph Lameter wrote: Umm you did not read the last bit of the description? It talks about firing all timers on all cpus at once. it talks about AVOIDING firing all timers on all cpus at once. H... Looked fine right now. Must have

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-28 Thread Arjan van de Ven
On Sat, 2007-04-28 at 16:35 -0700, Christoph Lameter wrote: > Hmmm... Yes but that looks like it comes from a different function. Slab > calls > > __round_jiffies_relative(HZ, cpu)) > > And its description says: > > /** > * > * The exact rounding is skewed for each processor to avoid all >

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-28 Thread Christoph Lameter
On Sat, 28 Apr 2007, Arjan van de Ven wrote: > Christoph Lameter wrote: > > The slab reaper takes global locks. If one makes all cache reapers fire at > > the same time as this patch does then there will be a lot of contention that > > may result lots of interrupt holdoffs since some locks are

Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-28 Thread Christoph Lameter
The slab reaper takes global locks. If one makes all cache reapers fire at the same time as this patch does then there will be a lot of contention that may result lots of interrupt holdoffs since some locks are taken with interrupts disabled. The vm statistics counters are updated and will

Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-28 Thread Christoph Lameter
The slab reaper takes global locks. If one makes all cache reapers fire at the same time as this patch does then there will be a lot of contention that may result lots of interrupt holdoffs since some locks are taken with interrupts disabled. The vm statistics counters are updated and will

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-28 Thread Christoph Lameter
On Sat, 28 Apr 2007, Arjan van de Ven wrote: Christoph Lameter wrote: The slab reaper takes global locks. If one makes all cache reapers fire at the same time as this patch does then there will be a lot of contention that may result lots of interrupt holdoffs since some locks are taken

Re: Please revert [PATCH] user of the jiffies rounding patch: Slab

2007-04-28 Thread Arjan van de Ven
On Sat, 2007-04-28 at 16:35 -0700, Christoph Lameter wrote: Hmmm... Yes but that looks like it comes from a different function. Slab calls __round_jiffies_relative(HZ, cpu)) And its description says: /** * * The exact rounding is skewed for each processor to avoid all *