Re: Question about using #ifdef CONFIG_PPC64 in driver code

2019-10-07 Thread Christoph Hellwig
On Sun, Oct 06, 2019 at 12:33:31PM +0300, Oded Gabbay wrote: > Hi Greg, > a while ago we had an argument about identifying in my driver's code > whether I'm running on x86 or powerpc. I tried to do something > dynamically (based on parent pci bridge ID), and you and other people > objected to it.

Re: Question about using #ifdef CONFIG_PPC64 in driver code

2019-10-07 Thread Greg Kroah-Hartman
On Sun, Oct 06, 2019 at 12:33:31PM +0300, Oded Gabbay wrote: > Hi Greg, > a while ago we had an argument about identifying in my driver's code > whether I'm running on x86 or powerpc. I tried to do something > dynamically (based on parent pci bridge ID), and you and other people > objected to it.

Question about using #ifdef CONFIG_PPC64 in driver code

2019-10-06 Thread Oded Gabbay
Hi Greg, a while ago we had an argument about identifying in my driver's code whether I'm running on x86 or powerpc. I tried to do something dynamically (based on parent pci bridge ID), and you and other people objected to it. I see in other drivers (more then a few) that they are using #ifdef