RE: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-16 Thread David Laight
From: Linus Torvalds > Sent: 15 August 2018 21:19 ... > But if people run things on real machines, then BUG() is absolutely > the last thing you EVER want to do for "debugging". I'm not sure you want it on a live system either. Live systems are where the 'hard' bugs show up. I've just spent a cou

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 12:45 PM Kees Cook wrote: > > I feel like we're talking cross purposes. The BUG() cases were for > places where we detect that we're executing with an impossible stack > pointer. It seems like trying to recover from that would just hide the > corruption for a later time tha

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Kees Cook
On Wed, Aug 15, 2018 at 12:04 PM, Linus Torvalds wrote: > On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: >> >> I swear I'm doing my best. Are you speaking of >> stackleak_check_alloca() or stackleak_erase()? These were both >> discussed on the list, and we weren't able to come up with >> alter

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Alexander Popov
Hello Linus, On 15.08.2018 22:04, Linus Torvalds wrote: > On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: >> >> I swear I'm doing my best. Are you speaking of >> stackleak_check_alloca() or stackleak_erase()? These were both >> discussed on the list, and we weren't able to come up with >> alter

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: > > I swear I'm doing my best. Are you speaking of > stackleak_check_alloca() or stackleak_erase()? These were both > discussed on the list, and we weren't able to come up with > alternatives: in both cases we're off the stack, and recovery is > se

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Kees Cook
On Wed, Aug 15, 2018 at 9:41 AM, Linus Torvalds wrote: > On Mon, Aug 13, 2018 at 2:43 PM Kees Cook wrote: >> >> Please pull these gcc-plugin changes for v4.19-rc1. > > No. > > It adds yet another BUG_ON() without having been merged. > > I'm not pulling this. Dammit, have you learnt *nothing*? I

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Linus Torvalds
On Mon, Aug 13, 2018 at 2:43 PM Kees Cook wrote: > > Please pull these gcc-plugin changes for v4.19-rc1. No. It adds yet another BUG_ON() without having been merged. I'm not pulling this. Dammit, have you learnt *nothing*? I'm, disappointed in the whole feature, but I'm also tired of having to