RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-09-24 Thread Naga Sureshkumar Relli
iquel.ray...@bootlin.com; rich...@nod.at; > > > > dw...@infradead.org; computersforpe...@gmail.com; > > > > marek.va...@gmail.com; kyungmin.p...@samsung.com; > > > > abs...@codeaurora.org; peterpand...@micron.com; > > > > frieder.schre...@exceet.de; linux- m...@li

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-09-22 Thread Boris Brezillon
m; > > > abs...@codeaurora.org; peterpand...@micron.com; > > > frieder.schre...@exceet.de; linux- > > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > > ; > > > nagasureshkumarre...@gmail.com > > > Subject: Re: [LINUX

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-09-22 Thread Miquel Raynal
..@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > ; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for > > Arasan NAND > > Flash Controller > > > > Hi Naga, > > > > On

RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-09-10 Thread Naga Sureshkumar Relli
ek.va...@gmail.com; kyungmin.p...@samsung.com; > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > ; > nagasureshkumarre...@gmail.com > Subject: Re: [LINUX PATCH v10 2/

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-21 Thread Miquel Raynal
Hi Naga, > > And why is it an s32 and not a u32? > To monitor NAND_CMD_STATUS. > Sometimes core will just send status command without reading back the status > data and later > It will try to read one byte using ->exec_op(). > So Arasan has FLASH_STS register and whenever we initiate a status

RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-21 Thread Naga Sureshkumar Relli
forpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com; > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > ; > nagasureshkumarre...@gmail.com > Subject: Re

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
Hi Naga, On Fri, 17 Aug 2018 18:49:24 +0530 Naga Sureshkumar Relli wrote: > > +config MTD_NAND_ARASAN > + tristate "Support for Arasan Nand Flash controller" > + depends on HAS_IOMEM > + depends on HAS_DMA Just nitpicking, but you can place them on the same line: depends

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
chal Simek ; computersforpe...@gmail.com; > > dw...@infradead.org; > > peterpand...@micron.com > > Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for > > Arasan > > NAND Flash Controller > > > > On Mon, 20 Aug 2018 10:49:38 + > > Naga

RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Naga Sureshkumar Relli
n.p...@samsung.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; miquel.ray...@bootlin.com; > nagasureshkumarre...@gmail.com; > Michal Simek ; computersforpe...@gmail.com; > dw...@infradead.org; > peterpand...@micron.com > Subject: Re: [LINUX PATCH v10

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 10:49:38 + Naga Sureshkumar Relli wrote: > > Thanks for your suggestion and are you saying something like Marvell parser > patterns for nfcv1 as below? > > static const struct nand_op_parser marvell_nfcv1_op_parser = NAND_OP_PARSER( > /* Naked commands not

RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Naga Sureshkumar Relli
.com; > > > kyungmin.p...@samsung.com; abs...@codeaurora.org; > > > peterpand...@micron.com; frieder.schre...@exceet.de; linux- > > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > > ; nagasureshkumarre...@gmail.com > > > Subjec

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-20 Thread Boris Brezillon
> > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > ; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for > > Arasan > > NAND Flash Controller > > > >

RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-17 Thread Naga Sureshkumar Relli
forpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com; > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > ; > nagasureshkumarre...@gmail.com > Subject: Re

RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-17 Thread Naga Sureshkumar Relli
forpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com; > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > ; > nagasureshkumarre...@gmail.com > Subject: Re

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-17 Thread Boris Brezillon
Hi Naga, On Fri, 17 Aug 2018 18:49:24 +0530 Naga Sureshkumar Relli wrote: > +static int anfc_exec_op_cmd(struct nand_chip *chip, > +const struct nand_subop *subop) > +{ > + const struct nand_op_instr *instr; > + struct anfc_op nfc_op = {}; > + struct

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-17 Thread kbuild test robot
Hi Naga, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mtd/nand/next] [also build test WARNING on next-20180817] [cannot apply to v4.18] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-08-17 Thread Miquel Raynal
Hi Naga, A user of Xilinx BSP reported a problem with lockdep that I can see is not yet fixed in this code: Naga Sureshkumar Relli wrote on Fri, 17 Aug 2018 18:49:24 +0530: > +static int anfc_probe(struct platform_device *pdev) > +{ > + struct anfc_nand_controller *nfc; > + struct