Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-11 Thread Rafael J. Wysocki
On Sat, Jan 9, 2021 at 6:08 PM Rafael J. Wysocki wrote: > > On Saturday, January 9, 2021 10:37:41 AM CET Dexuan Cui wrote: > > > From: Andy Shevchenko > > > Sent: Saturday, January 9, 2021 12:52 AM > > >> > > >> Hi Rafael, Len, and all, > > >> Can you please take a look at the v2 patch? > > >> >

Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-09 Thread Andy Shevchenko
On Sat, Jan 9, 2021 at 7:08 PM Rafael J. Wysocki wrote: > On Saturday, January 9, 2021 10:37:41 AM CET Dexuan Cui wrote: ... > > Do you want a simple strlen() check like the below, or a full > > check of the AAA or format? > > It would be good to check the format too while at it.

Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-09 Thread Rafael J. Wysocki
On Saturday, January 9, 2021 10:37:41 AM CET Dexuan Cui wrote: > > From: Andy Shevchenko > > Sent: Saturday, January 9, 2021 12:52 AM > >> > >> Hi Rafael, Len, and all, > >> Can you please take a look at the v2 patch? > >> > >> The Linux mainline has been broken for several weeks when it > >>

RE: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-09 Thread Dexuan Cui
> From: Andy Shevchenko > Sent: Saturday, January 9, 2021 12:52 AM >> >> Hi Rafael, Len, and all, >> Can you please take a look at the v2 patch? >> >> The Linux mainline has been broken for several weeks when it >> runs as a guest on Hyper-V, so we'd like this to be fixed ASAP, >> as more

RE: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-07 Thread Dexuan Cui
> From: Rafael J. Wysocki > Sent: Thursday, January 7, 2021 5:48 AM > > > > Linux VM on Hyper-V crashes with the latest mainline: > > > > ... > The root cause is a VM issue AFAICS, though. Yes. > It doesn't look like the right fix to me, though. > > The problem appears to be that the string

Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-07 Thread Rafael J. Wysocki
On Tue, Jan 5, 2021 at 11:02 PM Dexuan Cui wrote: > > > From: Michael Kelley > > Sent: Tuesday, December 22, 2020 5:56 AM > > From: Dexuan Cui > > Sent: Thursday, December 17, 2020 > > 8:08 PM > > > > > > Linux VM on Hyper-V crashes with the latest mainline: > > > ... > > > ---

Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-07 Thread Dwaipayan Ray
On 18/12/20 9:38 am, Dexuan Cui wrote: Linux VM on Hyper-V crashes with the latest mainline: [4.069624] detected buffer overflow in strcpy [4.077733] kernel BUG at lib/string.c:1149! .. [4.085819] RIP: 0010:fortify_panic+0xf/0x11 ... [4.085819] Call Trace: [4.085819]

RE: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2021-01-05 Thread Dexuan Cui
> From: Michael Kelley > Sent: Tuesday, December 22, 2020 5:56 AM > From: Dexuan Cui > Sent: Thursday, December 17, 2020 > 8:08 PM > > > > Linux VM on Hyper-V crashes with the latest mainline: > > ... > > --- a/drivers/acpi/scan.c > > +++ b/drivers/acpi/scan.c > > @@ -674,7 +674,8 @@ int

RE: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2020-12-22 Thread Michael Kelley
From: Dexuan Cui Sent: Thursday, December 17, 2020 8:08 PM > > Linux VM on Hyper-V crashes with the latest mainline: > > [4.069624] detected buffer overflow in strcpy > [4.077733] kernel BUG at lib/string.c:1149! > .. > [4.085819] RIP: 0010:fortify_panic+0xf/0x11 > ... > [

RE: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

2020-12-18 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Thursday, December 17, 2020 8:08 PM > > Linux VM on Hyper-V crashes with the latest mainline: > ... > This is because of the recent buffer overflow detection in the > commit 6a39e62abbaf ("lib: string.h: detect intra-object overflow in fortified > string functions") >