Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Oliver Neukum writes: > On Tuesday 05 March 2013 11:07:05 Bjørn Mork wrote: >> "Fangxiaozhi (Franko)" writes: >> >> > -- commit 200e0d99 and commit cd060956, only put the switch >> > command into kernel, instead of userspace usb_modeswitch utility. >> >> Yes. And that is the problem. It

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Oliver Neukum
On Tuesday 05 March 2013 11:07:05 Bjørn Mork wrote: > "Fangxiaozhi (Franko)" writes: > > > -- commit 200e0d99 and commit cd060956, only put the switch > > command into kernel, instead of userspace usb_modeswitch utility. > > Yes. And that is the problem. It was agreed years ago that this >

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Oliver Neukum writes: > On Monday 04 March 2013 23:28:47 Josua Dietze wrote: >> > I guess the real problem will be verifying that all of the entries can >> > go away. This type of hardware tends to get old very fast, but there is >> > always someone having a really ancient device. >> >> I will

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
"Fangxiaozhi (Franko)" writes: > -- commit 200e0d99 and commit cd060956, only put the switch > command into kernel, instead of userspace usb_modeswitch utility. Yes. And that is the problem. It was agreed years ago that this functionality belongs in userspace. Ref e.g

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Oliver Neukum
On Monday 04 March 2013 23:28:47 Josua Dietze wrote: > > I guess the real problem will be verifying that all of the entries can > > go away. This type of hardware tends to get old very fast, but there is > > always someone having a really ancient device. > > I will check this and add any missing

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Oliver Neukum
On Monday 04 March 2013 23:28:47 Josua Dietze wrote: I guess the real problem will be verifying that all of the entries can go away. This type of hardware tends to get old very fast, but there is always someone having a really ancient device. I will check this and add any missing USB IDs

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Fangxiaozhi (Franko) fangxiao...@huawei.com writes: -- commit 200e0d99 and commit cd060956, only put the switch command into kernel, instead of userspace usb_modeswitch utility. Yes. And that is the problem. It was agreed years ago that this functionality belongs in userspace. Ref e.g

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Monday 04 March 2013 23:28:47 Josua Dietze wrote: I guess the real problem will be verifying that all of the entries can go away. This type of hardware tends to get old very fast, but there is always someone having a really ancient device. I will

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Oliver Neukum
On Tuesday 05 March 2013 11:07:05 Bjørn Mork wrote: Fangxiaozhi (Franko) fangxiao...@huawei.com writes: -- commit 200e0d99 and commit cd060956, only put the switch command into kernel, instead of userspace usb_modeswitch utility. Yes. And that is the problem. It was agreed years ago

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Tuesday 05 March 2013 11:07:05 Bjørn Mork wrote: Fangxiaozhi (Franko) fangxiao...@huawei.com writes: -- commit 200e0d99 and commit cd060956, only put the switch command into kernel, instead of userspace usb_modeswitch utility. Yes. And that

RE: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Fangxiaozhi (Franko)
> -Original Message- > From: Bjørn Mork [mailto:bj...@mork.no] > Sent: Monday, March 04, 2013 9:19 PM > To: linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Fangxiaozhi (Franko); Xueguiying (Zihan); > Linlei (Lei Lin); Greg KH; Yili (Neil); Wangyuhua (Roger, Credit); Huqiao

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Josua Dietze
Am 04.03.2013 20:22, schrieb Bjørn Mork: Matthew Dharm writes: The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies with Greg and myself for letting it through. I had just assumed

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Matthew Dharm writes: > Frankly, I consider it appropriate. OK, I'll try to cook something up. > The question is not one of reminding me of what I said earlier > it's one of pointing people in the right direction. Frankly, some of > the fault for this patch lies with Greg and myself for

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Matthew Dharm
Frankly, I consider it appropriate. The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies with Greg and myself for letting it through. I had just assumed that the Huawei guys had

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Ben Hutchings writes: > On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: > [...] >> In-kernel mode switching was deprecated years ago with the >> development of the more user friendly userspace alternatives. The >> existing list of devices in usb-storage was only kept to prevent >> breaking

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Ben Hutchings
On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: [...] > In-kernel mode switching was deprecated years ago with the > development of the more user friendly userspace alternatives. The > existing list of devices in usb-storage was only kept to prevent > breaking already working systems. The

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Ben Hutchings
On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: [...] In-kernel mode switching was deprecated years ago with the development of the more user friendly userspace alternatives. The existing list of devices in usb-storage was only kept to prevent breaking already working systems. The long

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Ben Hutchings b...@decadent.org.uk writes: On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: [...] In-kernel mode switching was deprecated years ago with the development of the more user friendly userspace alternatives. The existing list of devices in usb-storage was only kept to prevent

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Matthew Dharm
Frankly, I consider it appropriate. The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies with Greg and myself for letting it through. I had just assumed that the Huawei guys had

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Matthew Dharm mdharm-...@one-eyed-alien.net writes: Frankly, I consider it appropriate. OK, I'll try to cook something up. The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Josua Dietze
Am 04.03.2013 20:22, schrieb Bjørn Mork: Matthew Dharm mdharm-...@one-eyed-alien.net writes: The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies with Greg and myself for letting it

RE: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Fangxiaozhi (Franko)
-Original Message- From: Bjørn Mork [mailto:bj...@mork.no] Sent: Monday, March 04, 2013 9:19 PM To: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Fangxiaozhi (Franko); Xueguiying (Zihan); Linlei (Lei Lin); Greg KH; Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (C);