RE: [PATCH] acpi: Fix format string type mistakes

2016-12-21 Thread Zheng, Lv
g type mistakes > > These formatting changes will not compile under: > > Gcc 4.4.5 > Gcc 5.4.0 > > The printf formatting stuff is very delicate, as ACPICA has to be compiled > under many different > compilers. > > Bob > > > From: Zheng, Lv > > Subj

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-21 Thread Zheng, Lv
g type mistakes > > These formatting changes will not compile under: > > Gcc 4.4.5 > Gcc 5.4.0 > > The printf formatting stuff is very delicate, as ACPICA has to be compiled > under many different > compilers. > > Bob > > > From: Zheng, Lv > > Subj

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-21 Thread Moore, Robert
o: Kees Cook <keesc...@chromium.org>; Moore, Robert > <robert.mo...@intel.com> > Cc: Wysocki, Rafael J <rafael.j.wyso...@intel.com>; linux- > ker...@vger.kernel.org; linux-a...@vger.kernel.org; Emese Revfy > <re.em...@gmail.com>; de...@acpica.org > Subject: RE: [P

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-21 Thread Moore, Robert
o: Kees Cook ; Moore, Robert > > Cc: Wysocki, Rafael J ; linux- > ker...@vger.kernel.org; linux-a...@vger.kernel.org; Emese Revfy > ; de...@acpica.org > Subject: RE: [PATCH] acpi: Fix format string type mistakes > > Hi, Kees and Emese > > The pull request is under rebasing.

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-21 Thread Zheng, Lv
Hi, Kees and Emese The pull request is under rebasing. So if you cannot reach the URL, find the commit here: https://github.com/acpica/acpica/pull/196 Thanks and best regards Lv > From: Zheng, Lv > Subject: RE: [PATCH] acpi: Fix format string type mistakes > > Hi, Kees and Emese

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-21 Thread Zheng, Lv
Hi, Kees and Emese The pull request is under rebasing. So if you cannot reach the URL, find the commit here: https://github.com/acpica/acpica/pull/196 Thanks and best regards Lv > From: Zheng, Lv > Subject: RE: [PATCH] acpi: Fix format string type mistakes > > Hi, Kees and Emese

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-20 Thread Zheng, Lv
Hi, Kees and Emese I just helped to back port the commit here: https://github.com/acpica/acpica/pull/196/commits/5e64857f If you can see something wrong in it, please let me know. Thanks and best regards Lv > From: Devel [mailto:devel-boun...@acpica.org] On Behalf Of Zheng, Lv > Subject: Re:

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-20 Thread Zheng, Lv
Hi, Kees and Emese I just helped to back port the commit here: https://github.com/acpica/acpica/pull/196/commits/5e64857f If you can see something wrong in it, please let me know. Thanks and best regards Lv > From: Devel [mailto:devel-boun...@acpica.org] On Behalf Of Zheng, Lv > Subject: Re:

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-19 Thread Moore, Robert
l Mailing List > <linux-kernel@vger.kernel.org>; Zheng, Lv <lv.zh...@intel.com>; Wysocki, > Rafael J <rafael.j.wyso...@intel.com>; Len Brown <l...@kernel.org>; ACPI > Devel Maling List <linux-a...@vger.kernel.org>; Emese Revfy > <re.em...@gmail.com>; de...@acpic

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-19 Thread Moore, Robert
wn ; ACPI > Devel Maling List ; Emese Revfy > ; de...@acpica.org > Subject: Re: [PATCH] acpi: Fix format string type mistakes > > On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki > wrote: > > On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook > wrote: > >> From: Eme

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-18 Thread Zheng, Lv
Hi, > From: Kees Cook [mailto:keesc...@chromium.org] > Subject: [PATCH] acpi: Fix format string type mistakes > > From: Emese Revfy > > This adds the missing __printf attribute which allows compile time > format string checking (and will be used by the coming initify gcc >

RE: [PATCH] acpi: Fix format string type mistakes

2016-12-18 Thread Zheng, Lv
Hi, > From: Kees Cook [mailto:keesc...@chromium.org] > Subject: [PATCH] acpi: Fix format string type mistakes > > From: Emese Revfy > > This adds the missing __printf attribute which allows compile time > format string checking (and will be used by the coming initify gcc > plugin).

Re: [PATCH] acpi: Fix format string type mistakes

2016-12-16 Thread Rafael J. Wysocki
On Sat, Dec 17, 2016 at 12:04 AM, Kees Cook wrote: > On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki wrote: >> On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook wrote: >>> From: Emese Revfy >>> >>> This adds the

Re: [PATCH] acpi: Fix format string type mistakes

2016-12-16 Thread Rafael J. Wysocki
On Sat, Dec 17, 2016 at 12:04 AM, Kees Cook wrote: > On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki wrote: >> On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook wrote: >>> From: Emese Revfy >>> >>> This adds the missing __printf attribute which allows compile time >>> format string checking (and

Re: [PATCH] acpi: Fix format string type mistakes

2016-12-16 Thread Kees Cook
On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki wrote: > On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook wrote: >> From: Emese Revfy >> >> This adds the missing __printf attribute which allows compile time >> format string checking

Re: [PATCH] acpi: Fix format string type mistakes

2016-12-16 Thread Kees Cook
On Fri, Dec 16, 2016 at 2:36 PM, Rafael J. Wysocki wrote: > On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook wrote: >> From: Emese Revfy >> >> This adds the missing __printf attribute which allows compile time >> format string checking (and will be used by the coming initify gcc >> plugin).

Re: [PATCH] acpi: Fix format string type mistakes

2016-12-16 Thread Rafael J. Wysocki
On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook wrote: > From: Emese Revfy > > This adds the missing __printf attribute which allows compile time > format string checking (and will be used by the coming initify gcc > plugin). Additionally, this fixes the

Re: [PATCH] acpi: Fix format string type mistakes

2016-12-16 Thread Rafael J. Wysocki
On Fri, Dec 16, 2016 at 10:51 PM, Kees Cook wrote: > From: Emese Revfy > > This adds the missing __printf attribute which allows compile time > format string checking (and will be used by the coming initify gcc > plugin). Additionally, this fixes the warnings exposed by the attribute. > >