RE: [PATCH] drm/amdgpu: add function declaration in amdgpu.h

[Deucher, Alexander]

> -Original Message-
> From: Baoyou Xie [mailto:baoyou@linaro.org]
> Sent: Sunday, September 18, 2016 10:29 AM
> To: Deucher, Alexander; Koenig, Christian; airl...@linux.ie; Zhou,
> David(ChunMing); Liu, Monk; Zhu, Rex; Huang, JinHuiEric; Cui, Flora
> Cc: dri-de...@lists.freedesktop.org; linux-kernel@vger.kernel.org;
> a...@arndb.de; baoyou@linaro.org; xie.bao...@zte.com.cn
> Subject: [PATCH] drm/amdgpu: add function declaration in amdgpu.h
> 
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous
> prototype for 'init_cond_exec' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous
> prototype for 'patch_cond_exec' [-Wmissing-prototypes]
> 
> In fact, both functions are not declared in any files.
> 
> So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h.
> 
> Signed-off-by: Baoyou Xie 

These functions were unused so they were already dropped.

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 8e3d9b2..7b71cbe 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring,
> struct fence **fence);
>  void amdgpu_fence_process(struct amdgpu_ring *ring);
>  int amdgpu_fence_wait_empty(struct amdgpu_ring *ring);
>  unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring);
> +unsigned int init_cond_exec(struct amdgpu_ring *ring);
> +void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset);
> 
>  /*
>   * BO.
> --
> 2.7.4

RE: [PATCH] drm/amdgpu: add function declaration in amdgpu.h

[Deucher, Alexander]

> -Original Message-
> From: Baoyou Xie [mailto:baoyou@linaro.org]
> Sent: Sunday, September 18, 2016 10:29 AM
> To: Deucher, Alexander; Koenig, Christian; airl...@linux.ie; Zhou,
> David(ChunMing); Liu, Monk; Zhu, Rex; Huang, JinHuiEric; Cui, Flora
> Cc: dri-de...@lists.freedesktop.org; linux-kernel@vger.kernel.org;
> a...@arndb.de; baoyou@linaro.org; xie.bao...@zte.com.cn
> Subject: [PATCH] drm/amdgpu: add function declaration in amdgpu.h
> 
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous
> prototype for 'init_cond_exec' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous
> prototype for 'patch_cond_exec' [-Wmissing-prototypes]
> 
> In fact, both functions are not declared in any files.
> 
> So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h.
> 
> Signed-off-by: Baoyou Xie 

These functions were unused so they were already dropped.

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 8e3d9b2..7b71cbe 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring,
> struct fence **fence);
>  void amdgpu_fence_process(struct amdgpu_ring *ring);
>  int amdgpu_fence_wait_empty(struct amdgpu_ring *ring);
>  unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring);
> +unsigned int init_cond_exec(struct amdgpu_ring *ring);
> +void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset);
> 
>  /*
>   * BO.
> --
> 2.7.4

Re: [PATCH] drm/amdgpu: add function declaration in amdgpu.h

[Christian König]

Am 18.09.2016 um 16:29 schrieb Baoyou Xie:

We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous prototype 
for 'init_cond_exec' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous prototype 
for 'patch_cond_exec' [-Wmissing-prototypes]

In fact, both functions are not declared in any files.

So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h.

Signed-off-by: Baoyou Xie 


NAK, IIRC Alex posted a patch last week to remove those two.

Regards,
Christian.


---
  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 8e3d9b2..7b71cbe 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct 
fence **fence);
  void amdgpu_fence_process(struct amdgpu_ring *ring);
  int amdgpu_fence_wait_empty(struct amdgpu_ring *ring);
  unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring);
+unsigned int init_cond_exec(struct amdgpu_ring *ring);
+void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset);
  
  /*

   * BO.

Re: [PATCH] drm/amdgpu: add function declaration in amdgpu.h

[Christian König]

Am 18.09.2016 um 16:29 schrieb Baoyou Xie:

We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous prototype 
for 'init_cond_exec' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous prototype 
for 'patch_cond_exec' [-Wmissing-prototypes]

In fact, both functions are not declared in any files.

So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h.

Signed-off-by: Baoyou Xie 


NAK, IIRC Alex posted a patch last week to remove those two.

Regards,
Christian.


---
  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 8e3d9b2..7b71cbe 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct 
fence **fence);
  void amdgpu_fence_process(struct amdgpu_ring *ring);
  int amdgpu_fence_wait_empty(struct amdgpu_ring *ring);
  unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring);
+unsigned int init_cond_exec(struct amdgpu_ring *ring);
+void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset);
  
  /*

   * BO.