RE: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings
(sorry for only seeing this late)
[...]
> +maintainers:
> + - John Crispin
personally I think we should get at least John's Acked-by but I don't
know if there's any rule for adding a dt-binding for some other
maintainer
[...]
> +required:
> + - compatible
> + - reg
based on "DOs and DON’Ts for designing and writing Devicetree bindings"
from [0] I think this is incomplete
As far as I know CGU contains some PLLs. These PLLs need at least one
input: the main XTAL which is found on the board
Also the Lantiq code does not use the common clock framework yet. Once
that's used we also need #clock-cells = <1>. I don't know if that
should be added already (or not).
> +examples:
> + - |
> +cgu@103000 {
this should be clock-controller@...
Best regards,
Martin
[0]
https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-bindings.html
Re: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings
On Fri, Jan 01, 2021 at 07:01:18PM +0100, Aleksander Jan Bajkowski wrote: > Document the Lantiq Xway SoC series Clock Generation Unit (CGU) bindings. > > Signed-off-by: Aleksander Jan Bajkowski > --- > .../bindings/mips/lantiq/lantiq,cgu.yaml | 32 +++ > 1 file changed, 32 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]
Re: [PATCH] dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings
On Fri, 01 Jan 2021 19:01:18 +0100, Aleksander Jan Bajkowski wrote: > Document the Lantiq Xway SoC series Clock Generation Unit (CGU) bindings. > > Signed-off-by: Aleksander Jan Bajkowski > --- > .../bindings/mips/lantiq/lantiq,cgu.yaml | 32 +++ > 1 file changed, 32 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml > Reviewed-by: Rob Herring
