Re: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread Greg KH
On Mon, Aug 20, 2018 at 05:43:26PM +0800, Chuanhua Han wrote: > Signed-off-by: Chuanhua Han > --- > Changes in v2: > - Place the adjusted transfer bytes code in spi_mem_adjust_op_size() > and check spi_max_message_size(mem->spi) value before subtracting > opcode, addr and dummy

Re: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread Boris Brezillon
On Mon, 20 Aug 2018 13:01:13 + David Laight wrote: > From: Chuanhua Han > > Sent: 20 August 2018 13:44 > > Still no message here, and the subject prefix is still wrong. Fixes and Cc-stable tags should be placed here... > > Signed-off-by: Chuanhua Han > > --- > > Changes in v3: > > R

RE: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread David Laight
From: Chuanhua Han > Sent: 20 August 2018 13:44 > > Signed-off-by: Chuanhua Han > --- > Changes in v3: > Rename variable name "val" to "opcode_addr_dummy_sum". > Place the legitimacy of the transfer size(i.e., > "pi_max_message_size(mem->spi)" and > "opcode_addr_dummy_sum") into "if (! c

Re: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread kbuild test robot
Hi Chuanhua, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on spi/for-next] [also build test WARNING on v4.18 next-20180817] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

Re: [PATCH] mtd: m25p80: consider max message size when use the spi_mem_xx() API

2018-08-20 Thread Boris Brezillon
Hi Chuanhua, On Mon, 20 Aug 2018 17:43:26 +0800 Chuanhua Han wrote: Subject prefix should be "spi: spi-mem: " not "mtd: m25p80: ", and you need a commit message explaining what this patch does and why it's needed. > Signed-off-by: Chuanhua Han Fixes: c36ff266dc82 ("spi: Extend the core to eas