Re: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

2016-11-09 Thread Brian Norris
On Thu, Nov 10, 2016 at 12:20:53AM +0200, Kalle Valo wrote: > Brian Norris writes: > > > SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length > > when we print them out. > > > > This can be easily noticed by connecting to a network with a 32-octet > >

Re: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

2016-11-09 Thread Brian Norris
On Thu, Nov 10, 2016 at 12:20:53AM +0200, Kalle Valo wrote: > Brian Norris writes: > > > SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length > > when we print them out. > > > > This can be easily noticed by connecting to a network with a 32-octet > > SSID: > > > > [ 3903.502925]

Re: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

2016-11-09 Thread Kalle Valo
Brian Norris writes: > SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length > when we print them out. > > This can be easily noticed by connecting to a network with a 32-octet > SSID: > > [ 3903.502925] mwifiex_pcie :01:00.0: info: trying to

Re: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

2016-11-09 Thread Kalle Valo
Brian Norris writes: > SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length > when we print them out. > > This can be easily noticed by connecting to a network with a 32-octet > SSID: > > [ 3903.502925] mwifiex_pcie :01:00.0: info: trying to associate to >

RE: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

2016-11-08 Thread Amitkumar Karwar
> From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Wednesday, November 09, 2016 7:58 AM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-kernel@vger.kernel.org; linux-wirel...@vger.kernel.org; Cathy > Luo; secur...@kernel.org; sta...@vger.kernel.org; Brian Norris >

RE: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

2016-11-08 Thread Amitkumar Karwar
> From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Wednesday, November 09, 2016 7:58 AM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-kernel@vger.kernel.org; linux-wirel...@vger.kernel.org; Cathy > Luo; secur...@kernel.org; sta...@vger.kernel.org; Brian Norris >