RE: [PATCH] net/ncsi: add control packet payload to NC-SI commands from netlink

2019-08-20 Thread Ben Wei
> Hi Ben, > > > Hi Justin, > > > > > Hi Ben, > > > > > > I have similar fix locally with different approach as the command handler > > > may have some expectation for those byes. > > > We can use NCSI_PKT_CMD_OEM handler as it only copies data based on the > > > payload length. > > > >

RE: [PATCH] net/ncsi: add control packet payload to NC-SI commands from netlink

2019-08-20 Thread Justin.Lee1
Hi Ben, > Hi Justin, > > > Hi Ben, > > > > I have similar fix locally with different approach as the command handler > > may have some expectation for those byes. > > We can use NCSI_PKT_CMD_OEM handler as it only copies data based on the > > payload length. > > Great! Yes I was thinking

RE: [PATCH] net/ncsi: add control packet payload to NC-SI commands from netlink

2019-08-19 Thread Ben Wei
Hi Justin, > Hi Ben, > > I have similar fix locally with different approach as the command handler may > have some expectation for those byes. > We can use NCSI_PKT_CMD_OEM handler as it only copies data based on the > payload length. Great! Yes I was thinking the same, we just need some way

RE: [PATCH] net/ncsi: add control packet payload to NC-SI commands from netlink

2019-08-19 Thread Justin.Lee1
Hi Ben, I have similar fix locally with different approach as the command handler may have some expectation for those byes. We can use NCSI_PKT_CMD_OEM handler as it only copies data based on the payload length. diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index 5c3fad8..3b01f65