RE: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-25 Thread Keith Packard
David Laight writes: > I think you meant lenovo_info. I posted an updated patch already; nice to know that so many people are looking at this kernel patch :-) -- keith.pack...@intel.com pgp7s9JXIJnNo.pgp Description: PGP signature

RE: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-25 Thread David Laight
From: Keith Packard > The Lenovo OneLink dock includes a USB ethernet adapter using the > AX88179 chip, but with a different USB ID. Add this new USB id to the > driver so that it will autodetect the adapter correctly. > > Signed-off-by: Keith Packard > Tested-by: Carl Worth > --- >

Re: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-25 Thread Bjørn Mork
Keith Packard writes: > Kyle McMartin says: > >> _info, surely. > > Yeah, Daniel Stone caught the same bug. Not a big deal; the only > difference between any of these elements is the string produced by the > kernel. Yes, and that mess should really be cleaned up in this driver (and probably

Re: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-25 Thread Bjørn Mork
Keith Packard kei...@keithp.com writes: Kyle McMartin says: lenovo_info, surely. Yeah, Daniel Stone caught the same bug. Not a big deal; the only difference between any of these elements is the string produced by the kernel. Yes, and that mess should really be cleaned up in this driver

RE: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-25 Thread David Laight
From: Keith Packard The Lenovo OneLink dock includes a USB ethernet adapter using the AX88179 chip, but with a different USB ID. Add this new USB id to the driver so that it will autodetect the adapter correctly. Signed-off-by: Keith Packard kei...@keithp.com Tested-by: Carl Worth

RE: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-25 Thread Keith Packard
David Laight david.lai...@aculab.com writes: I think you meant lenovo_info. I posted an updated patch already; nice to know that so many people are looking at this kernel patch :-) -- keith.pack...@intel.com pgp7s9JXIJnNo.pgp Description: PGP signature

Re: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-24 Thread Kyle McMartin
On Mon, Feb 24, 2014 at 03:13:49PM -0800, Keith Packard wrote: > +static const struct driver_info lenovo_info = { > +}, { > + /* Lenovo ThinkPad OneLink GigaLAN */ > + USB_DEVICE(0x17ef, 0x304b), > + .driver_info = (unsigned long)_info, _info, surely. --Kyle -- To unsubscribe from

Re: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-24 Thread Kyle McMartin
On Mon, Feb 24, 2014 at 03:13:49PM -0800, Keith Packard wrote: +static const struct driver_info lenovo_info = { snip +}, { + /* Lenovo ThinkPad OneLink GigaLAN */ + USB_DEVICE(0x17ef, 0x304b), + .driver_info = (unsigned long)samsung_info, lenovo_info, surely. --Kyle -- To