Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-12 Thread Marc Zyngier
On 11/02/16 23:15, Rob Herring wrote: > On Thu, Feb 11, 2016 at 5:04 AM, Marc Zyngier wrote: >> On 09/02/16 11:04, Robin Murphy wrote: >>> The existing msi-map code is fine for shifting the entire RID space >>> upwards, but attempting finer-grained remapping reveals a bug. It turns >>> out that

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-12 Thread Marc Zyngier
On 11/02/16 23:15, Rob Herring wrote: > On Thu, Feb 11, 2016 at 5:04 AM, Marc Zyngier wrote: >> On 09/02/16 11:04, Robin Murphy wrote: >>> The existing msi-map code is fine for shifting the entire RID space >>> upwards, but attempting finer-grained remapping reveals a bug.

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-11 Thread Rob Herring
On Thu, Feb 11, 2016 at 5:04 AM, Marc Zyngier wrote: > On 09/02/16 11:04, Robin Murphy wrote: >> The existing msi-map code is fine for shifting the entire RID space >> upwards, but attempting finer-grained remapping reveals a bug. It turns >> out that we are mistakenly treating the msi-base part

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-11 Thread Frank Rowand
On 2/11/2016 3:04 AM, Marc Zyngier wrote: > On 09/02/16 11:04, Robin Murphy wrote: >> The existing msi-map code is fine for shifting the entire RID space >> upwards, but attempting finer-grained remapping reveals a bug. It turns >> out that we are mistakenly treating the msi-base part as an

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-11 Thread Marc Zyngier
On 09/02/16 11:04, Robin Murphy wrote: > The existing msi-map code is fine for shifting the entire RID space > upwards, but attempting finer-grained remapping reveals a bug. It turns > out that we are mistakenly treating the msi-base part as an offset, not > as a new base to remap onto, so things

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-11 Thread Rob Herring
On Thu, Feb 11, 2016 at 5:04 AM, Marc Zyngier wrote: > On 09/02/16 11:04, Robin Murphy wrote: >> The existing msi-map code is fine for shifting the entire RID space >> upwards, but attempting finer-grained remapping reveals a bug. It turns >> out that we are mistakenly

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-11 Thread Frank Rowand
On 2/11/2016 3:04 AM, Marc Zyngier wrote: > On 09/02/16 11:04, Robin Murphy wrote: >> The existing msi-map code is fine for shifting the entire RID space >> upwards, but attempting finer-grained remapping reveals a bug. It turns >> out that we are mistakenly treating the msi-base part as an

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-11 Thread Marc Zyngier
On 09/02/16 11:04, Robin Murphy wrote: > The existing msi-map code is fine for shifting the entire RID space > upwards, but attempting finer-grained remapping reveals a bug. It turns > out that we are mistakenly treating the msi-base part as an offset, not > as a new base to remap onto, so things

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Mark Rutland
On Tue, Feb 09, 2016 at 04:17:33PM +, Robin Murphy wrote: > On 09/02/16 16:08, Mark Rutland wrote: > [...] > > having msi-map-mask clash with a nonzero rid-base, as that's another > thing one can easily get wrong. > > [...] > > + if (rid_base & ~map_mask) { > +

RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Stuart Yoder
> -Original Message- > From: Robin Murphy [mailto:robin.mur...@arm.com] > Sent: Tuesday, February 09, 2016 5:05 AM > To: robh...@kernel.org; frowand.l...@gmail.com; grant.lik...@linaro.org; > devicet...@vger.kernel.org > Cc: marc.zyng...@arm.com; mark.rutl...@arm.com;

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread David Daney
On 02/09/2016 03:04 AM, Robin Murphy wrote: The existing msi-map code is fine for shifting the entire RID space upwards, but attempting finer-grained remapping reveals a bug. It turns out that we are mistakenly treating the msi-base part as an offset, not as a new base to remap onto, so things

RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Stuart Yoder
.kernel.org; david.da...@cavium.com; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > sta...@vger.kernel.org > Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base > > On Tue, Feb 09, 2016 at 03:56:55PM +, Stuart Yoder wrote: > > &

RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Stuart Yoder
avid.da...@cavium.com; Stuart Yoder > ; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > sta...@vger.kernel.org > Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base > > Hi Robin, > > On 09/02/16 11:04, Robin Murphy wrote: >

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Robin Murphy
On 09/02/16 16:08, Mark Rutland wrote: [...] having msi-map-mask clash with a nonzero rid-base, as that's another thing one can easily get wrong. [...] + if (rid_base & ~map_mask) { + dev_err(parent_dev, + "Invalid msi-map

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Mark Rutland
.com; > > grant.lik...@linaro.org; devicet...@vger.kernel.org > > Cc: mark.rutl...@arm.com; david.da...@cavium.com; Stuart Yoder > > ; > > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > > sta...@vger.kernel.org > > Subject: Re: [PATCH] o

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Marc Zyngier
Hi Robin, On 09/02/16 11:04, Robin Murphy wrote: > The existing msi-map code is fine for shifting the entire RID space > upwards, but attempting finer-grained remapping reveals a bug. It turns > out that we are mistakenly treating the msi-base part as an offset, not > as a new base to remap onto,

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Marc Zyngier
Hi Robin, On 09/02/16 11:04, Robin Murphy wrote: > The existing msi-map code is fine for shifting the entire RID space > upwards, but attempting finer-grained remapping reveals a bug. It turns > out that we are mistakenly treating the msi-base part as an offset, not > as a new base to remap onto,

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Mark Rutland
.org; > > frowand.l...@gmail.com; > > grant.lik...@linaro.org; devicet...@vger.kernel.org > > Cc: mark.rutl...@arm.com; david.da...@cavium.com; Stuart Yoder > > <stuart.yo...@nxp.com>; > > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > > sta.

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Robin Murphy
On 09/02/16 16:08, Mark Rutland wrote: [...] having msi-map-mask clash with a nonzero rid-base, as that's another thing one can easily get wrong. [...] + if (rid_base & ~map_mask) { + dev_err(parent_dev, + "Invalid msi-map

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread David Daney
On 02/09/2016 03:04 AM, Robin Murphy wrote: The existing msi-map code is fine for shifting the entire RID space upwards, but attempting finer-grained remapping reveals a bug. It turns out that we are mistakenly treating the msi-base part as an offset, not as a new base to remap onto, so things

RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Stuart Yoder
.@kernel.org; frowand.l...@gmail.com; grant.lik...@linaro.org; > devicet...@vger.kernel.org; david.da...@cavium.com; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > sta...@vger.kernel.org > Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-ba

RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Stuart Yoder
t; Cc: mark.rutl...@arm.com; david.da...@cavium.com; Stuart Yoder > <stuart.yo...@nxp.com>; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > sta...@vger.kernel.org > Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base > > H

RE: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Stuart Yoder
> -Original Message- > From: Robin Murphy [mailto:robin.mur...@arm.com] > Sent: Tuesday, February 09, 2016 5:05 AM > To: robh...@kernel.org; frowand.l...@gmail.com; grant.lik...@linaro.org; > devicet...@vger.kernel.org > Cc: marc.zyng...@arm.com; mark.rutl...@arm.com;

Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base

2016-02-09 Thread Mark Rutland
On Tue, Feb 09, 2016 at 04:17:33PM +, Robin Murphy wrote: > On 09/02/16 16:08, Mark Rutland wrote: > [...] > > having msi-map-mask clash with a nonzero rid-base, as that's another > thing one can easily get wrong. > > [...] > > + if (rid_base & ~map_mask) { > +