Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread Andy Shevchenko
On Mon, Aug 6, 2018 at 7:42 PM, Joe Perches wrote: > On Mon, 2018-08-06 at 16:41 +, David Laight wrote: >> From: Andy Shevchenko >> > Sent: 05 August 2018 11:26 >> > > static bool has_cap(u32 cap) >> > > { >> > > if ((interface->capability & cap) != 0) >> > > - return

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread Andy Shevchenko
On Mon, Aug 6, 2018 at 7:42 PM, Joe Perches wrote: > On Mon, 2018-08-06 at 16:41 +, David Laight wrote: >> From: Andy Shevchenko >> > Sent: 05 August 2018 11:26 >> > > static bool has_cap(u32 cap) >> > > { >> > > if ((interface->capability & cap) != 0) >> > > - return

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread Gustavo A. R. Silva
On 08/06/2018 11:42 AM, Joe Perches wrote: > On Mon, 2018-08-06 at 16:41 +, David Laight wrote: >> From: Andy Shevchenko >>> Sent: 05 August 2018 11:26 >>> >>> On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva >>> wrote: Return statements in functions returning bool should use true

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread Gustavo A. R. Silva
On 08/06/2018 11:42 AM, Joe Perches wrote: > On Mon, 2018-08-06 at 16:41 +, David Laight wrote: >> From: Andy Shevchenko >>> Sent: 05 August 2018 11:26 >>> >>> On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva >>> wrote: Return statements in functions returning bool should use true

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread Joe Perches
On Mon, 2018-08-06 at 16:41 +, David Laight wrote: > From: Andy Shevchenko > > Sent: 05 August 2018 11:26 > > > > On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva > > wrote: > > > Return statements in functions returning bool should use true or false > > > instead of an integer value. > >

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread Joe Perches
On Mon, 2018-08-06 at 16:41 +, David Laight wrote: > From: Andy Shevchenko > > Sent: 05 August 2018 11:26 > > > > On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva > > wrote: > > > Return statements in functions returning bool should use true or false > > > instead of an integer value. > >

RE: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread David Laight
From: Andy Shevchenko > Sent: 05 August 2018 11:26 > > On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva > wrote: > > Return statements in functions returning bool should use true or false > > instead of an integer value. > > > > This code was detected with the help of Coccinelle. > > >

RE: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread David Laight
From: Andy Shevchenko > Sent: 05 August 2018 11:26 > > On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva > wrote: > > Return statements in functions returning bool should use true or false > > instead of an integer value. > > > > This code was detected with the help of Coccinelle. > > >

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-05 Thread Andy Shevchenko
On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use true or false > instead of an integer value. > > This code was detected with the help of Coccinelle. > static bool has_cap(u32 cap) > { > if ((interface->capability &

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-05 Thread Andy Shevchenko
On Sun, Aug 5, 2018 at 3:18 AM, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use true or false > instead of an integer value. > > This code was detected with the help of Coccinelle. > static bool has_cap(u32 cap) > { > if ((interface->capability &