RE: [PATCH] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

On 03/02/21 10:23, Song Bao Hua (Barry Song) wrote: >> -Original Message- >> From: Valentin Schneider [mailto:valentin.schnei...@arm.com] >> Thoughts? > > I guess the original purpose of overlapping groups is creating as few groups > as possible. If we totally remove overlapping groups, it

RE: [PATCH] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

om; > linux-kernel@vger.kernel.org > Cc: linux...@openeuler.org; xuwei (O) ; Liguozhu (Kenneth) > ; tiantao (H) ; wanghuiqiang > ; Zengtao (B) ; Jonathan > Cameron ; guodong...@linaro.org; Meelis Roos > > Subject: RE: [PATCH] sched/topology: fix the issue groups don't sp

RE: [PATCH] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

: [PATCH] sched/topology: fix the issue groups don't span > domain->span for NUMA diameter > 2 > > On 01/02/21 16:38, Barry Song wrote: > > @@ -964,6 +941,12 @@ static void init_overlap_sched_group(struct > > sched_domain > *sd, > > > > build_balance

Re: [PATCH] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

On 02/02/21 15:17, Valentin Schneider wrote: > That is, rather than building overlapping groups and fixing them whenever > that breaks (distance > 2), we could have: > - the local group being the child domain's span (as always) > - all non-local NUMA groups spanning a single node each, with the

Re: [PATCH] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

On 01/02/21 16:38, Barry Song wrote: > @@ -964,6 +941,12 @@ static void init_overlap_sched_group(struct sched_domain > *sd, > > build_balance_mask(sd, sg, mask); > cpu = cpumask_first_and(sched_group_span(sg), mask); > + /* > + * for the group generated by grandchild, use the

RE: [PATCH] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

: [PATCH] sched/topology: fix the issue groups don't span > domain->span for NUMA diameter > 2 > > > Hi, > > On 01/02/21 16:38, Barry Song wrote: > > A tricky thing is that we shouldn't use the sgc of the 1st CPU of node2 > > for the sched_group generated by

Re: [PATCH] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

Hi, On 01/02/21 16:38, Barry Song wrote: > A tricky thing is that we shouldn't use the sgc of the 1st CPU of node2 > for the sched_group generated by grandchild, otherwise, when this cpu > becomes the balance_cpu of another sched_group of cpus other than node0, > our sched_group generated by

Re: [PATCH] sched/topology: fix the issue groups don't span domain->span for NUMA diameter > 2

Hi Barry, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/sched/core] [also build test WARNING on next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in