RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

Hi, "Du, Changbin" writes: > Hi, Balbi, > >> > Hmm, I agree from this point. I will combine this patch with other two >> patches >> > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as >> well, >> >> you are creating a dependency that doesn't exist.

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

Hi, "Du, Changbin" writes: > Hi, Balbi, > >> > Hmm, I agree from this point. I will combine this patch with other two >> patches >> > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as >> well, >> >> you are creating a dependency that doesn't exist. Please stop that. You >>

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

Hi, Balbi, > > Hmm, I agree from this point. I will combine this patch with other two > patches > > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as > well, > > you are creating a dependency that doesn't exist. Please stop that. You > should have two separate branches based

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

Hi, Balbi, > > Hmm, I agree from this point. I will combine this patch with other two > patches > > (due to their dependency). And I'd like remove the 'dwc->root=NULL' as > well, > > you are creating a dependency that doesn't exist. Please stop that. You > should have two separate branches based

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

Hi Changbin, "Du, Changbin" writes: >> Hi, >> >> "Du, Changbin" writes: >> >> >> >> >> > +dwc->regset = NULL; >> >> >> >> >> >> setting regset to NULL is unnecessary. We only call >> dwc3_debugfs_exit() >> >> >> when removing the driver. >> >>

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

Hi Changbin, "Du, Changbin" writes: >> Hi, >> >> "Du, Changbin" writes: >> >> >> >> >> > +dwc->regset = NULL; >> >> >> >> >> >> setting regset to NULL is unnecessary. We only call >> dwc3_debugfs_exit() >> >> >> when removing the driver. >> >> >> >> >> >> -- >> >> >> Balbi >> >> > I'd

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

> Hi, > > "Du, Changbin" writes: > >> > >> >> > + dwc->regset = NULL; > >> >> > >> >> setting regset to NULL is unnecessary. We only call > dwc3_debugfs_exit() > >> >> when removing the driver. > >> >> > >> >> -- > >> >> Balbi > >> > I'd like keep this line even it is

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

> Hi, > > "Du, Changbin" writes: > >> > >> >> > + dwc->regset = NULL; > >> >> > >> >> setting regset to NULL is unnecessary. We only call > dwc3_debugfs_exit() > >> >> when removing the driver. > >> >> > >> >> -- > >> >> Balbi > >> > I'd like keep this line even it is unnecessary, because It

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

Hi, "Du, Changbin" writes: >> >> >> > + dwc->regset = NULL; >> >> >> >> setting regset to NULL is unnecessary. We only call dwc3_debugfs_exit() >> >> when removing the driver. >> >> >> >> -- >> >> Balbi >> > I'd like keep this line even it is unnecessary, because

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

Hi, "Du, Changbin" writes: >> >> >> > + dwc->regset = NULL; >> >> >> >> setting regset to NULL is unnecessary. We only call dwc3_debugfs_exit() >> >> when removing the driver. >> >> >> >> -- >> >> Balbi >> > I'd like keep this line even it is unnecessary, because It is a good habit >> >

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

> > >> > +dwc->regset = NULL; > >> > >> setting regset to NULL is unnecessary. We only call dwc3_debugfs_exit() > >> when removing the driver. > >> > >> -- > >> Balbi > > I'd like keep this line even it is unnecessary, because It is a good habit > > to > > Avoid wild pointers. Just like

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

> > >> > +dwc->regset = NULL; > >> > >> setting regset to NULL is unnecessary. We only call dwc3_debugfs_exit() > >> when removing the driver. > >> > >> -- > >> Balbi > > I'd like keep this line even it is unnecessary, because It is a good habit > > to > > Avoid wild pointers. Just like

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

"Du, Changbin" writes: >> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c >> > index 9ac37fe..9eeb444 100644 >> > --- a/drivers/usb/dwc3/debugfs.c >> > +++ b/drivers/usb/dwc3/debugfs.c >> > @@ -687,4 +687,7 @@ void dwc3_debugfs_exit(struct dwc3 *dwc)

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

"Du, Changbin" writes: >> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c >> > index 9ac37fe..9eeb444 100644 >> > --- a/drivers/usb/dwc3/debugfs.c >> > +++ b/drivers/usb/dwc3/debugfs.c >> > @@ -687,4 +687,7 @@ void dwc3_debugfs_exit(struct dwc3 *dwc) >> > { >> >

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c > > index 9ac37fe..9eeb444 100644 > > --- a/drivers/usb/dwc3/debugfs.c > > +++ b/drivers/usb/dwc3/debugfs.c > > @@ -687,4 +687,7 @@ void dwc3_debugfs_exit(struct dwc3 *dwc) > > { > > debugfs_remove_recursive(dwc->root);

RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c > > index 9ac37fe..9eeb444 100644 > > --- a/drivers/usb/dwc3/debugfs.c > > +++ b/drivers/usb/dwc3/debugfs.c > > @@ -687,4 +687,7 @@ void dwc3_debugfs_exit(struct dwc3 *dwc) > > { > > debugfs_remove_recursive(dwc->root);

Re: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

changbin...@intel.com writes: > From: "Du, Changbin" > > dwc->regset is allocated on dwc3_debugfs_init, and should > be released on dwc3_debugfs_exit. > > Signed-off-by: Du, Changbin > --- > This patch is seperated from patch set: > [PATCH v2 0/3]

Re: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

changbin...@intel.com writes: > From: "Du, Changbin" > > dwc->regset is allocated on dwc3_debugfs_init, and should > be released on dwc3_debugfs_exit. > > Signed-off-by: Du, Changbin > --- > This patch is seperated from patch set: > [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs