RE: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-12 Thread Jun Li
Saturday, October 10, 2020 12:06 AM > > >> To: Jun Li > > >> Cc: Jun Li ; Guenter Roeck > > >> ; Greg KH ; Heikki > > >> Krogerus ; Linux USB List > > >> ; lkml ; > > >> cy_huang > > >> Subject: Re: [PATCH] usb: typec: t

RE: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-12 Thread Jun Li
> -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Sunday, October 11, 2020 3:32 AM > To: Jun Li ; ChiYuan Huang > Cc: Jun Li ; Greg KH ; > Heikki Krogerus ; Linux USB List > ; lkml ; > cy_huang > Subject: Re: [PATCH] usb: typec:

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-12 Thread ChiYuan Huang
er Roeck ; > >> Greg KH ; Heikki Krogerus > >> ; Linux USB List > >> ; lkml ; > >> cy_huang > >> Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, > >> hard_reset_count > >> not reset issue > >> > >> Jun

RE: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-10 Thread Jun Li
: Guenter Roeck ; Greg KH > > > ; Heikki Krogerus > > > ; Linux USB List > > > ; lkml ; > > > cy_huang ; Jun Li > > > Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, > > > hard_reset_count not reset issue > > > > &g

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-10 Thread Guenter Roeck
; From: ChiYuan Huang >>>> Sent: Wednesday, October 7, 2020 6:13 PM >>>> To: Jun Li >>>> Cc: Guenter Roeck ; Greg KH >>>> ; Heikki Krogerus >>>> ; Linux USB List >>>> ; lkml ; >>>> cy_huang ; Jun Li >>>>

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-10 Thread Guenter Roeck
On Sat, Oct 10, 2020 at 12:06:13AM +0800, ChiYuan Huang wrote: [ ... ] > > Like I mentioned before, whatever the condition is, hard_reset_count > must be reset to zero during tcpm_detach. > > But refer to Guenter's mail, he prefer to narrow down the condition > to reset this counter. > > I

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-09 Thread ChiYuan Huang
kml ; > > cy_huang ; Jun Li > > Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, > > hard_reset_count > > not reset issue > > > > ChiYuan Huang 於 2020年10月7日 週三 上午1:39寫道: > > > > > > Jun Li 於 2020年10月7日 週三 上午12:52寫道: > > >

RE: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-09 Thread Jun Li
> -Original Message- > From: ChiYuan Huang > Sent: Wednesday, October 7, 2020 6:13 PM > To: Jun Li > Cc: Guenter Roeck ; Greg KH > ; Heikki Krogerus > ; Linux USB List > ; lkml ; > cy_huang ; Jun Li > Subject: Re: [PATCH] usb: typec: tcpm: Fix if vb

RE: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-08 Thread Jun Li
> -Original Message- > From: ChiYuan Huang > Sent: Wednesday, October 7, 2020 1:39 AM > To: Jun Li > Cc: Guenter Roeck ; Greg KH > ; Heikki Krogerus > ; Linux USB List > ; lkml ; > cy_huang ; Jun Li > Subject: Re: [PATCH] usb: typec: tcpm: Fix if vb

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-07 Thread ChiYuan Huang
ChiYuan Huang 於 2020年10月7日 週三 上午1:39寫道: > > Jun Li 於 2020年10月7日 週三 上午12:52寫道: > > > > ChiYuan Huang 于2020年10月6日周二 下午12:38写道: > > > > > > Guenter Roeck 於 2020年10月5日 週一 下午11:30寫道: > > > > > > > > On 10/5/20 4:08 AM, Greg KH wrote: > > > > [ ... ] > > > > >>> What ever happened with this patch,

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-06 Thread ChiYuan Huang
Jun Li 於 2020年10月7日 週三 上午12:52寫道: > > ChiYuan Huang 于2020年10月6日周二 下午12:38写道: > > > > Guenter Roeck 於 2020年10月5日 週一 下午11:30寫道: > > > > > > On 10/5/20 4:08 AM, Greg KH wrote: > > > [ ... ] > > > >>> What ever happened with this patch, is there still disagreement? > > > >>> > > > >> > > > >> Yes,

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-06 Thread Jun Li
ChiYuan Huang 于2020年10月6日周二 下午12:38写道: > > Guenter Roeck 於 2020年10月5日 週一 下午11:30寫道: > > > > On 10/5/20 4:08 AM, Greg KH wrote: > > [ ... ] > > >>> What ever happened with this patch, is there still disagreement? > > >>> > > >> > > >> Yes, there is. I wouldn't have added the conditional without

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-05 Thread ChiYuan Huang
Guenter Roeck 於 2020年10月5日 週一 下午11:30寫道: > > On 10/5/20 4:08 AM, Greg KH wrote: > [ ... ] > >>> What ever happened with this patch, is there still disagreement? > >>> > >> > >> Yes, there is. I wouldn't have added the conditional without reason, > >> and I am concerned that removing it entirely

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-05 Thread Guenter Roeck
On 10/5/20 4:08 AM, Greg KH wrote: [ ... ] >>> What ever happened with this patch, is there still disagreement? >>> >> >> Yes, there is. I wouldn't have added the conditional without reason, >> and I am concerned that removing it entirely will open another problem. >> Feel free to apply, though -

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-05 Thread Greg KH
On Fri, Oct 02, 2020 at 07:26:24AM -0700, Guenter Roeck wrote: > On 10/2/20 6:31 AM, Greg KH wrote: > > On Tue, Sep 15, 2020 at 11:07:18AM +0800, ChiYuan Huang wrote: > >> Hi, Guenter: > >> > >> ChiYuan Huang 於 2020年9月6日 週日 下午11:22寫道: > >>> > >>> Guenter Roeck 於 2020年9月5日 週六 下午11:51寫道: > >

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-02 Thread Guenter Roeck
On 10/2/20 6:31 AM, Greg KH wrote: > On Tue, Sep 15, 2020 at 11:07:18AM +0800, ChiYuan Huang wrote: >> Hi, Guenter: >> >> ChiYuan Huang 於 2020年9月6日 週日 下午11:22寫道: >>> >>> Guenter Roeck 於 2020年9月5日 週六 下午11:51寫道: On 9/4/20 6:24 PM, ChiYuan Huang wrote: > Guenter Roeck 於 2020年9月5日 週六

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-10-02 Thread Greg KH
On Tue, Sep 15, 2020 at 11:07:18AM +0800, ChiYuan Huang wrote: > Hi, Guenter: > > ChiYuan Huang 於 2020年9月6日 週日 下午11:22寫道: > > > > Guenter Roeck 於 2020年9月5日 週六 下午11:51寫道: > > > > > > On 9/4/20 6:24 PM, ChiYuan Huang wrote: > > > > Guenter Roeck 於 2020年9月5日 週六 上午3:41寫道: > > > >> > > > >> On

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-09-14 Thread ChiYuan Huang
Hi, Guenter: ChiYuan Huang 於 2020年9月6日 週日 下午11:22寫道: > > Guenter Roeck 於 2020年9月5日 週六 下午11:51寫道: > > > > On 9/4/20 6:24 PM, ChiYuan Huang wrote: > > > Guenter Roeck 於 2020年9月5日 週六 上午3:41寫道: > > >> > > >> On 9/3/20 9:21 AM, ChiYuan Huang wrote: > > >>> Guenter Roeck 於 2020年9月3日 週四 上午12:57寫道: >

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-09-06 Thread ChiYuan Huang
Guenter Roeck 於 2020年9月5日 週六 下午11:51寫道: > > On 9/4/20 6:24 PM, ChiYuan Huang wrote: > > Guenter Roeck 於 2020年9月5日 週六 上午3:41寫道: > >> > >> On 9/3/20 9:21 AM, ChiYuan Huang wrote: > >>> Guenter Roeck 於 2020年9月3日 週四 上午12:57寫道: > > On Wed, Sep 02, 2020 at 11:35:33PM +0800, cy_huang wrote:

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-09-05 Thread Guenter Roeck
On 9/4/20 6:24 PM, ChiYuan Huang wrote: > Guenter Roeck 於 2020年9月5日 週六 上午3:41寫道: >> >> On 9/3/20 9:21 AM, ChiYuan Huang wrote: >>> Guenter Roeck 於 2020年9月3日 週四 上午12:57寫道: On Wed, Sep 02, 2020 at 11:35:33PM +0800, cy_huang wrote: > From: ChiYuan Huang > > Fix: If vbus event

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-09-04 Thread ChiYuan Huang
Guenter Roeck 於 2020年9月5日 週六 上午3:41寫道: > > On 9/3/20 9:21 AM, ChiYuan Huang wrote: > > Guenter Roeck 於 2020年9月3日 週四 上午12:57寫道: > >> > >> On Wed, Sep 02, 2020 at 11:35:33PM +0800, cy_huang wrote: > >>> From: ChiYuan Huang > >>> > >>> Fix: If vbus event is before cc_event trigger,

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-09-04 Thread Guenter Roeck
On 9/3/20 9:21 AM, ChiYuan Huang wrote: > Guenter Roeck 於 2020年9月3日 週四 上午12:57寫道: >> >> On Wed, Sep 02, 2020 at 11:35:33PM +0800, cy_huang wrote: >>> From: ChiYuan Huang >>> >>> Fix: If vbus event is before cc_event trigger, hard_reset_count >>> won't bt reset for some case. >>> >>>

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-09-03 Thread ChiYuan Huang
Guenter Roeck 於 2020年9月3日 週四 上午12:57寫道: > > On Wed, Sep 02, 2020 at 11:35:33PM +0800, cy_huang wrote: > > From: ChiYuan Huang > > > > Fix: If vbus event is before cc_event trigger, hard_reset_count > > won't bt reset for some case. > > > > Signed-off-by: ChiYuan Huang > > --- > > Below's the

Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue

2020-09-02 Thread Guenter Roeck
On Wed, Sep 02, 2020 at 11:35:33PM +0800, cy_huang wrote: > From: ChiYuan Huang > > Fix: If vbus event is before cc_event trigger, hard_reset_count > won't bt reset for some case. > > Signed-off-by: ChiYuan Huang > --- > Below's the flow. > > _tcpm_pd_vbus_off() -> run_state_machine to change