Re: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-27 Thread Paul E. McKenney
On Sun, Dec 27, 2020 at 10:08:51PM +0800, Lai Jiangshan wrote: > On Sat, Dec 26, 2020 at 10:52 PM Paul E. McKenney wrote: > > > > > > > Can you please specify a bit what you encountered in rcutorture > > > before this patchset? You know we cant have a correct estimation > > > of the fix diameter

Re: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-27 Thread Lai Jiangshan
On Sat, Dec 26, 2020 at 10:52 PM Paul E. McKenney wrote: > > > > Can you please specify a bit what you encountered in rcutorture > > before this patchset? You know we cant have a correct estimation > > of the fix diameter without your help. > > It triggers the following in sched_cpu_dying() in

Re: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-26 Thread Paul E. McKenney
On Sat, Dec 26, 2020 at 06:34:21PM +0800, Hillf Danton wrote: > On Wed, 23 Dec 2020 11:49:51 -0800 "Paul E. McKenney" wrote: > >On Sat, Dec 19, 2020 at 01:09:09AM +0800, Lai Jiangshan wrote: > >> From: Lai Jiangshan > >> > >> 06249738a41a ("workqueue: Manually break affinity on hotplug") > >>

RE: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-23 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Wednesday, December 23, 2020 12:27 PM > ... > The warning only repros if there are more than 1 node, and it only prints once > for the first vCPU of the second node (i.e. node #1). A correction: if I configure the 32 vCPUs evenly into 4 nodes, I get the warning once for

RE: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-23 Thread Dexuan Cui
> From: Lai Jiangshan > Sent: Wednesday, December 23, 2020 7:02 AM > > > > Hi, > > I tested this patchset on today's tip.git's master branch > > (981316394e35 ("Merge branch 'locking/urgent'")). > > > > Every time the kernel boots with 32 CPUs (I'm running the Linux VM on > > Hyper-V), I get the

Re: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-23 Thread Paul E. McKenney
On Sat, Dec 19, 2020 at 01:09:09AM +0800, Lai Jiangshan wrote: > From: Lai Jiangshan > > 06249738a41a ("workqueue: Manually break affinity on hotplug") > said that scheduler will not force break affinity for us. > > But workqueue highly depends on the old behavior. Many parts of the codes >

Re: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-23 Thread Lai Jiangshan
On Wed, Dec 23, 2020 at 5:39 AM Dexuan-Linux Cui wrote: > > On Fri, Dec 18, 2020 at 8:11 AM Lai Jiangshan wrote: > > > > From: Lai Jiangshan > > > > 06249738a41a ("workqueue: Manually break affinity on hotplug") > > said that scheduler will not force break affinity for us. > > > > But workqueue

Re: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-23 Thread Lai Jiangshan
On Wed, Dec 23, 2020 at 5:39 AM Dexuan-Linux Cui wrote: > > On Fri, Dec 18, 2020 at 8:11 AM Lai Jiangshan wrote: > > > > From: Lai Jiangshan > > > > 06249738a41a ("workqueue: Manually break affinity on hotplug") > > said that scheduler will not force break affinity for us. > > > > But workqueue

Re: [PATCH -tip V2 00/10] workqueue: break affinity initiatively

2020-12-22 Thread Dexuan-Linux Cui
On Fri, Dec 18, 2020 at 8:11 AM Lai Jiangshan wrote: > > From: Lai Jiangshan > > 06249738a41a ("workqueue: Manually break affinity on hotplug") > said that scheduler will not force break affinity for us. > > But workqueue highly depends on the old behavior. Many parts of the codes > relies on