RE: [PATCH 1/1] mwifiex: remove superfluous condition

2016-08-01 Thread Amitkumar Karwar
> From: Heinrich Schuchardt [mailto:xypron.g...@gmx.de] > Sent: Sunday, July 31, 2016 4:09 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Heinrich Schuchardt > Subject: [PATCH 1/1] mwifiex:

RE: [PATCH 1/1] mwifiex: remove superfluous condition

2016-08-01 Thread Amitkumar Karwar
> From: Heinrich Schuchardt [mailto:xypron.g...@gmx.de] > Sent: Sunday, July 31, 2016 4:09 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Heinrich Schuchardt > Subject: [PATCH 1/1] mwifiex:

Re: [PATCH 1/1] mwifiex: remove superfluous condition (2)

2016-07-31 Thread Kalle Valo
Heinrich Schuchardt writes: > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt Please try to make the commit titles unique, for example you can use function names

Re: [PATCH 1/1] mwifiex: remove superfluous condition (2)

2016-07-31 Thread Kalle Valo
Heinrich Schuchardt writes: > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt Please try to make the commit titles unique, for example you can use function names or something else. Adding "(2)" is not