Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-24 Thread Benjamin Tissoires
Hi, I have this review in my inbox for a while, but couldn't find the time to finish it earlier. Sorry about that. On Mar 30 2017 or thereabouts, Masaki Ota wrote: > From Masaki Ota > > -Support Alps HID I2C T4 Touchpad device. > -Laptop names that use this Touchpad:HP

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-24 Thread Benjamin Tissoires
Hi, I have this review in my inbox for a while, but couldn't find the time to finish it earlier. Sorry about that. On Mar 30 2017 or thereabouts, Masaki Ota wrote: > From Masaki Ota > > -Support Alps HID I2C T4 Touchpad device. > -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-06 Thread Nikolaus Rath
t Regards, > Masaki Ota > -Original Message- > From: Nikolaus Rath [mailto:nikol...@rath.org] > Sent: Thursday, April 06, 2017 3:36 AM > To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> > Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-06 Thread Nikolaus Rath
l...@rath.org] > Sent: Thursday, April 06, 2017 3:36 AM > To: 太田 真喜 Masaki Ota > Cc: linux-kernel ; linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Masaki, > > Could you be a little more specific about what you need? I don't

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-05 Thread Masaki Ota
.alps.com> Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Masaki, Could you be a little more specific about what you need? I don't like executing scripts containing several instances of 'sudo rm -r

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-05 Thread Masaki Ota
olaus Rath [mailto:nikol...@rath.org] > Sent: Wednesday, April 05, 2017 9:01 AM > To: 太田 真喜 Masaki Ota > Cc: linux-kernel ; > linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Masaki, > > Well, I'd be pleasent

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-05 Thread Nikolaus Rath
ent: Wednesday, April 05, 2017 9:01 AM > To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> > Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Masaki, > > Well, I'd be pleasently surprised

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-05 Thread Nikolaus Rath
2017 9:01 AM > To: 太田 真喜 Masaki Ota > Cc: linux-kernel ; linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Masaki, > > Well, I'd be pleasently surprised if every bug always came together > with an associated error message :-). No matte

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-05 Thread Masaki Ota
] Sent: Wednesday, April 05, 2017 9:01 AM To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Masaki, Well, I'd be pleasently surprised if every bug always c

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-05 Thread Masaki Ota
] Sent: Wednesday, April 05, 2017 9:01 AM To: 太田 真喜 Masaki Ota Cc: linux-kernel ; linux-in...@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Masaki, Well, I'd be pleasently surprised if every bug always came together with an associated error message :-). No matter

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Nikolaus Rath
mailto:nikol...@rath.org] > Sent: Wednesday, April 05, 2017 8:43 AM > To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> > Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Masaki, >

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Nikolaus Rath
t: Wednesday, April 05, 2017 8:43 AM > To: 太田 真喜 Masaki Ota > Cc: linux-kernel ; linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Masaki, > > Yes, without your patch the touchpad is mostly working - I just can't > configure it.

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Masaki, Yes, without your patch the touchpad is mostly working - I just can't configure it. Please take a look at https://bugs.freedesktop.org/show_bug.cgi?id=1

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
-in...@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Masaki, Yes, without your patch the touchpad is mostly working - I just can't configure it. Please take a look at https://bugs.freedesktop.org/show_bug.cgi?id=100345. Best, -Nikolaus On Apr 04 2017, Masaki Ota wrote: >

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Nikolaus Rath
ednesday, April 05, 2017 2:09 AM > To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> > Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Masaki, > > Yes, I think I have a 0

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Nikolaus Rath
:09 AM > To: 太田 真喜 Masaki Ota > Cc: linux-kernel ; linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Masaki, > > Yes, I think I have a 044E:120C. Is there a way to find out for sure? > It's not listed by e.g. lspci. > > The to

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
Masaki Ota <masaki@jp.alps.com> Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Masaki, Yes, I think I have a 044E:120C. Is there a way to find out for sure? It's not listed by e.g. lspci.

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
Masaki Ota Cc: linux-kernel ; linux-in...@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Masaki, Yes, I think I have a 044E:120C. Is there a way to find out for sure? It's not listed by e.g. lspci. The touchpad is definitely not reacting to anything. evemu-record does

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Nikolaus Rath
aki Ota <masaki@jp.alps.com>; linux-kernel > <linux-kernel@vger.kernel.org>; linux-in...@vger.kernel.org > Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support > > Hi Ota, > >> -Support Alps HID I2C T4 Touchpad device. >> -Laptop names that use this T

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Nikolaus Rath
Touchpad does not work completely, there is something an error. > What does dmesg show? > > Best Regards, > Masaki Ota > -Original Message- > From: Nikolaus Rath [mailto:nikol...@rath.org] > Sent: Tuesday, April 04, 2017 12:09 PM > To: 太田 真喜 Masaki Ota ; linux-kernel > ;

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Ota, > -Support Alps HID I2C T4 Touchpad device. > -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio > G1, Elitebook 1030 G1, Elitebook 1040 G3 > > Signed-off-by: Masaki Ota <masaki.ota@xxx>

RE: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-04 Thread Masaki Ota
. What does dmesg show? Best Regards, Masaki Ota -Original Message- From: Nikolaus Rath [mailto:nikol...@rath.org] Sent: Tuesday, April 04, 2017 12:09 PM To: 太田 真喜 Masaki Ota ; linux-kernel ; linux-in...@vger.kernel.org Subject: Re: [PATCH 1/2] Alps HID I2C T4 device support Hi Ota

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-03 Thread Nikolaus Rath
Hi Ota, > -Support Alps HID I2C T4 Touchpad device. > -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1, > Elitebook 1030 G1, Elitebook 1040 G3 > > Signed-off-by: Masaki Ota > --- > drivers/hid/hid-alps.c | 500 >

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-03 Thread Nikolaus Rath
Hi Ota, > -Support Alps HID I2C T4 Touchpad device. > -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1, > Elitebook 1030 G1, Elitebook 1040 G3 > > Signed-off-by: Masaki Ota > --- > drivers/hid/hid-alps.c | 500 > +++-- >