RE: [PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-18 Thread Kershner, David A
t.org; *S-Par-Maintainer > <sparmaintai...@unisys.com>; erik.arfvid...@gmail.com; > wadgaonkar...@gmail.com > Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging > > On Fri, Nov 17, 2017 at 12:27:39PM -0500, David Kershner wrote: > > {drivers/staging/u

RE: [PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-18 Thread Kershner, David A
er > ; erik.arfvid...@gmail.com; > wadgaonkar...@gmail.com > Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging > > On Fri, Nov 17, 2017 at 12:27:39PM -0500, David Kershner wrote: > > {drivers/staging/unisys/include => include/linux/visorbus}/visorbus.h | 0 > &

Re: [PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-18 Thread Greg KH
On Fri, Nov 17, 2017 at 12:27:39PM -0500, David Kershner wrote: > {drivers/staging/unisys/include => include/linux/visorbus}/visorbus.h | 0 > .../staging/unisys/include => include/linux/visorbus}/visorchannel.h | 0 Do we really need two different include/linux .h files for this bus subsystem?

Re: [PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-18 Thread Greg KH
On Fri, Nov 17, 2017 at 12:27:39PM -0500, David Kershner wrote: > {drivers/staging/unisys/include => include/linux/visorbus}/visorbus.h | 0 > .../staging/unisys/include => include/linux/visorbus}/visorchannel.h | 0 Do we really need two different include/linux .h files for this bus subsystem?

RE: [PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-17 Thread Kershner, David A
kernel.org; driverdev-de...@linuxdriverproject.org; *S-Par- > Maintainer <sparmaintai...@unisys.com>; erik.arfvid...@gmail.com; > wadgaonkar...@gmail.com > Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging > > Please don' tcreate new subdirectories under include/linux > i

RE: [PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-17 Thread Kershner, David A
roject.org; *S-Par- > Maintainer ; erik.arfvid...@gmail.com; > wadgaonkar...@gmail.com > Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging > > Please don' tcreate new subdirectories under include/linux > if you don't have to. > Thanks for the feedback,

Re: [PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-17 Thread Christoph Hellwig
Please don' tcreate new subdirectories under include/linux if you don't have to. Also who outside of unisys has reviewed this whole code? Instead of a move please send an actual patchset to add the new files so people can review it just like any other code.

Re: [PATCH 2/2] drivers: visorbus: move driver out of staging

2017-11-17 Thread Christoph Hellwig
Please don' tcreate new subdirectories under include/linux if you don't have to. Also who outside of unisys has reviewed this whole code? Instead of a move please send an actual patchset to add the new files so people can review it just like any other code.