RE: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-05-03 Thread Shameerali Kolothum Thodi
gt;; Mark Salter <msal...@redhat.com>; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver > > On 2018-04-02 02:37, Yisheng Xie wrote: > > Hi Neil, > > > > On 2018/4/1 13:44, Neil Leeder wrote: > >> Hi Yish

RE: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-05-03 Thread Shameerali Kolothum Thodi
gt; Masters ; Timur Tabi ; Will > Deacon ; linux-kernel@vger.kernel.org; Mark Brown > ; Mark Salter ; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver > > On 2018-04-02 02:37, Yisheng Xie wrote: > > Hi Neil, > > > &g

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-05-02 Thread Agustin Vega-Frias
On 2018-04-02 02:37, Yisheng Xie wrote: Hi Neil, On 2018/4/1 13:44, Neil Leeder wrote: Hi Yisheng Xie, On 3/29/2018 03:03 AM, Yisheng Xie wrote: Hi Neil, On 2017/8/5 3:59, Neil Leeder wrote: +mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); +mem_map_0 =

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-05-02 Thread Agustin Vega-Frias
On 2018-04-02 02:37, Yisheng Xie wrote: Hi Neil, On 2018/4/1 13:44, Neil Leeder wrote: Hi Yisheng Xie, On 3/29/2018 03:03 AM, Yisheng Xie wrote: Hi Neil, On 2017/8/5 3:59, Neil Leeder wrote: +mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); +mem_map_0 =

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-18 Thread Yisheng Xie
...@vger.kernel.org; Mark Brown <broo...@kernel.org>; Mark Salter >> <msal...@redhat.com>; linux-arm-ker...@lists.infradead.org >> Subject: Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver >> >> Hi Neil, >> >> On 2017/8/5 3:59, Neil Leeder wrot

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-18 Thread Yisheng Xie
Neil Leeder ; Will Deacon >> ; Mark Rutland >> Cc: Mark Langsdorf ; Jon Masters >> ; Timur Tabi ; linux- >> ker...@vger.kernel.org; Mark Brown ; Mark Salter >> ; linux-arm-ker...@lists.infradead.org >> Subject: Re: [PATCH 2/2] perf: add arm64 sm

RE: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-18 Thread Shameerali Kolothum Thodi
Rutland <mark.rutl...@arm.com> > Cc: Mark Langsdorf <mlang...@redhat.com>; Jon Masters > <j...@redhat.com>; Timur Tabi <ti...@codeaurora.org>; linux- > ker...@vger.kernel.org; Mark Brown <broo...@kernel.org>; Mark Salter > <msal...@redhat.com>; linux-ar

RE: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-18 Thread Shameerali Kolothum Thodi
imur Tabi ; linux- > ker...@vger.kernel.org; Mark Brown ; Mark Salter > ; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver > > Hi Neil, > > On 2017/8/5 3:59, Neil Leeder wrote: > > + mem_resource_0 = platform_get_res

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-04 Thread Lorenzo Pieralisi
On Tue, Apr 03, 2018 at 09:15:11AM +0800, Hanjun Guo wrote: > [+Cc Lorenzo] > > Hi Neil, > > On 2018/4/3 1:59, Neil Leeder wrote: > > Hi Hanjun, > > > > On 4/2/2018 10:24 AM, Hanjun Guo wrote: > > > >> > >> I think we need to wait for the new version of IORT spec, > >> which includes the fix

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-04 Thread Lorenzo Pieralisi
On Tue, Apr 03, 2018 at 09:15:11AM +0800, Hanjun Guo wrote: > [+Cc Lorenzo] > > Hi Neil, > > On 2018/4/3 1:59, Neil Leeder wrote: > > Hi Hanjun, > > > > On 4/2/2018 10:24 AM, Hanjun Guo wrote: > > > >> > >> I think we need to wait for the new version of IORT spec, > >> which includes the fix

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-02 Thread Hanjun Guo
[+Cc Lorenzo] Hi Neil, On 2018/4/3 1:59, Neil Leeder wrote: > Hi Hanjun, > > On 4/2/2018 10:24 AM, Hanjun Guo wrote: > >> >> I think we need to wait for the new version of IORT spec, >> which includes the fix for the two base address for SMMUv3 >> PMCG (now just represent one). >> >> Thanks >>

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-02 Thread Hanjun Guo
[+Cc Lorenzo] Hi Neil, On 2018/4/3 1:59, Neil Leeder wrote: > Hi Hanjun, > > On 4/2/2018 10:24 AM, Hanjun Guo wrote: > >> >> I think we need to wait for the new version of IORT spec, >> which includes the fix for the two base address for SMMUv3 >> PMCG (now just represent one). >> >> Thanks >>

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-02 Thread Neil Leeder
Hi Hanjun, On 4/2/2018 10:24 AM, Hanjun Guo wrote: I think we need to wait for the new version of IORT spec, which includes the fix for the two base address for SMMUv3 PMCG (now just represent one). Thanks Hanjun It's in rev D which is available now:

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-02 Thread Neil Leeder
Hi Hanjun, On 4/2/2018 10:24 AM, Hanjun Guo wrote: I think we need to wait for the new version of IORT spec, which includes the fix for the two base address for SMMUv3 PMCG (now just represent one). Thanks Hanjun It's in rev D which is available now:

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-02 Thread Hanjun Guo
On 2018/4/2 14:37, Yisheng Xie wrote: > Hi Neil, > > On 2018/4/1 13:44, Neil Leeder wrote: >> Hi Yisheng Xie, >> >> On 3/29/2018 03:03 AM, Yisheng Xie wrote: >>> >>> Hi Neil, >>> >>> On 2017/8/5 3:59, Neil Leeder wrote: +mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0);

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-02 Thread Hanjun Guo
On 2018/4/2 14:37, Yisheng Xie wrote: > Hi Neil, > > On 2018/4/1 13:44, Neil Leeder wrote: >> Hi Yisheng Xie, >> >> On 3/29/2018 03:03 AM, Yisheng Xie wrote: >>> >>> Hi Neil, >>> >>> On 2017/8/5 3:59, Neil Leeder wrote: +mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0);

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-02 Thread Yisheng Xie
Hi Neil, On 2018/4/1 13:44, Neil Leeder wrote: > Hi Yisheng Xie, > > On 3/29/2018 03:03 AM, Yisheng Xie wrote: >> >> Hi Neil, >> >> On 2017/8/5 3:59, Neil Leeder wrote: >>> +mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> +mem_map_0 = devm_ioremap_resource(>dev,

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-04-02 Thread Yisheng Xie
Hi Neil, On 2018/4/1 13:44, Neil Leeder wrote: > Hi Yisheng Xie, > > On 3/29/2018 03:03 AM, Yisheng Xie wrote: >> >> Hi Neil, >> >> On 2017/8/5 3:59, Neil Leeder wrote: >>> +mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> +mem_map_0 = devm_ioremap_resource(>dev,

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-03-31 Thread Neil Leeder
Hi Yisheng Xie, On 3/29/2018 03:03 AM, Yisheng Xie wrote: Hi Neil, On 2017/8/5 3:59, Neil Leeder wrote: +    mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); +    mem_map_0 = devm_ioremap_resource(>dev, mem_resource_0); + Can we use devm_ioremap instead? for the reg_base of

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-03-31 Thread Neil Leeder
Hi Yisheng Xie, On 3/29/2018 03:03 AM, Yisheng Xie wrote: Hi Neil, On 2017/8/5 3:59, Neil Leeder wrote: +    mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); +    mem_map_0 = devm_ioremap_resource(>dev, mem_resource_0); + Can we use devm_ioremap instead? for the reg_base of

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-03-29 Thread Yisheng Xie
Hi Neil, On 2017/8/5 3:59, Neil Leeder wrote: > + mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + mem_map_0 = devm_ioremap_resource(>dev, mem_resource_0); > + Can we use devm_ioremap instead? for the reg_base of smmu_pmu is IMPLEMENTATION DEFINED. If the reg of

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2018-03-29 Thread Yisheng Xie
Hi Neil, On 2017/8/5 3:59, Neil Leeder wrote: > + mem_resource_0 = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + mem_map_0 = devm_ioremap_resource(>dev, mem_resource_0); > + Can we use devm_ioremap instead? for the reg_base of smmu_pmu is IMPLEMENTATION DEFINED. If the reg of

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2017-12-04 Thread Linu Cherian
Hi Robin, On Mon Aug 07, 2017 at 03:31:24PM +0100, Robin Murphy wrote: > On 04/08/17 20:59, Neil Leeder wrote: > > Adds a new driver to support the SMMU v3 PMU and add it into the > > perf events framework. > > > > Each SMMU node may have multiple PMUs associated with it, each of > > which may

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2017-12-04 Thread Linu Cherian
Hi Robin, On Mon Aug 07, 2017 at 03:31:24PM +0100, Robin Murphy wrote: > On 04/08/17 20:59, Neil Leeder wrote: > > Adds a new driver to support the SMMU v3 PMU and add it into the > > perf events framework. > > > > Each SMMU node may have multiple PMUs associated with it, each of > > which may

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2017-08-07 Thread Leeder, Neil
Hi Robin, Thank you for your comments. On 8/7/2017 10:31 AM, Robin Murphy wrote: > On 04/08/17 20:59, Neil Leeder wrote: >> PMUs are named smmu_0_ where >> is the physical page address of the SMMU PMCG. >> For example, the SMMU PMCG at 0xff8884 is named smmu_0_ff88840 > > This seems a bit

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2017-08-07 Thread Leeder, Neil
Hi Robin, Thank you for your comments. On 8/7/2017 10:31 AM, Robin Murphy wrote: > On 04/08/17 20:59, Neil Leeder wrote: >> PMUs are named smmu_0_ where >> is the physical page address of the SMMU PMCG. >> For example, the SMMU PMCG at 0xff8884 is named smmu_0_ff88840 > > This seems a bit

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2017-08-07 Thread Robin Murphy
On 04/08/17 20:59, Neil Leeder wrote: > Adds a new driver to support the SMMU v3 PMU and add it into the > perf events framework. > > Each SMMU node may have multiple PMUs associated with it, each of > which may support different events. > > PMUs are named smmu_0_ where > is the physical page

Re: [PATCH 2/2] perf: add arm64 smmuv3 pmu driver

2017-08-07 Thread Robin Murphy
On 04/08/17 20:59, Neil Leeder wrote: > Adds a new driver to support the SMMU v3 PMU and add it into the > perf events framework. > > Each SMMU node may have multiple PMUs associated with it, each of > which may support different events. > > PMUs are named smmu_0_ where > is the physical page