Re: [PATCH 3/5] net/mlx4_en: Call netif_carrier_off() after register_netdev()

2012-08-14 Thread Ben Hutchings
On Tue, 2012-08-14 at 12:36 +, sathya.pe...@emulex.com wrote: > >-Original Message- > >From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > >Behalf Of Ilya Shchepetkov > > > >For carrier detection to work properly when binding the driver with a > >cable

RE: [PATCH 3/5] net/mlx4_en: Call netif_carrier_off() after register_netdev()

2012-08-14 Thread Sathya.Perla
>-Original Message- >From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >Behalf Of Ilya Shchepetkov > >For carrier detection to work properly when binding the driver with a >cable unplugged, netif_carrier_off() should be called after >register_netdev(), not before.

RE: [PATCH 3/5] net/mlx4_en: Call netif_carrier_off() after register_netdev()

2012-08-14 Thread Sathya.Perla
-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Ilya Shchepetkov For carrier detection to work properly when binding the driver with a cable unplugged, netif_carrier_off() should be called after register_netdev(), not before.

Re: [PATCH 3/5] net/mlx4_en: Call netif_carrier_off() after register_netdev()

2012-08-14 Thread Ben Hutchings
On Tue, 2012-08-14 at 12:36 +, sathya.pe...@emulex.com wrote: -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Ilya Shchepetkov For carrier detection to work properly when binding the driver with a cable unplugged,