Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Tue, Oct 09, 2018 at 01:55:06PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Tuesday, October 9, 2018 8:45 AM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > > ; Zhu, Rex ; Sasha Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > > for smu7/8 > > > > On Mon, Oct 08, 2018 at 06:01:50PM +, Deucher, Alexander wrote: > > > > -Original Message- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, October 8, 2018 1:11 PM > > > > To: Deucher, Alexander > > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > > > Harry ; Zhu, Rex ; > > Sasha > > > > Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > to DC for smu7/8 > > > > > > > > On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > > > > > -Original Message- > > > > > > From: Greg Kroah-Hartman > > > > > > Sent: Monday, October 8, 2018 10:44 AM > > > > > > To: Deucher, Alexander > > > > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; > > > > > > Wentland, Harry ; Zhu, Rex > > > > > > ; > > > > Sasha > > > > > > Levin > > > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > > values to DC for smu7/8 > > > > > > > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander > > wrote: > > > > > > > > -Original Message- > > > > > > > > From: Greg Kroah-Hartman > > > > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > > > > To: linux-kernel@vger.kernel.org > > > > > > > > Cc: Greg Kroah-Hartman ; > > > > > > > > sta...@vger.kernel.org; Wentland, Harry > > > > > > > > ; Deucher, Alexander > > > > > > > > ; Zhu, Rex > > ; > > > > Sasha > > > > > > > > Levin > > > > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > > > > values to DC for > > > > > > > > smu7/8 > > > > > > > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, > > > > > > > > please let me > > > > > > know. > > > > > > > > > > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > > > > > > > Is it reverted in "upstream" as well? If not, please get the > > > > > > fix in there and then I will be glad to backport it here. > > > > > > > > > > > > > > > > There's no breakage in upstream. This patch addressed breakages > > > > > in > > > > > 4.19 specifically due to some other refactoring we did in the driver. > > > > > I'll try and dig out the exact series of patches this addressed. > > > > > > > > So there is no problem in 4.19-rc7? That contridicts the statement > > > > of looking in drm-next for the fixes. > > > > > > Sorry, what statement about drm-next? This patch was for 4.19 and was > > not intended for 4.18. It was picked up by Sasha's auto select system for > > stable. > > > > I thought this thread said that. > > > > Ok, so I should just revert it? > > Yes, please. Now reverted, thanks. greg k-h
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Tue, Oct 09, 2018 at 01:55:06PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Tuesday, October 9, 2018 8:45 AM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > > ; Zhu, Rex ; Sasha Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > > for smu7/8 > > > > On Mon, Oct 08, 2018 at 06:01:50PM +, Deucher, Alexander wrote: > > > > -Original Message- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, October 8, 2018 1:11 PM > > > > To: Deucher, Alexander > > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > > > Harry ; Zhu, Rex ; > > Sasha > > > > Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > to DC for smu7/8 > > > > > > > > On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > > > > > -Original Message- > > > > > > From: Greg Kroah-Hartman > > > > > > Sent: Monday, October 8, 2018 10:44 AM > > > > > > To: Deucher, Alexander > > > > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; > > > > > > Wentland, Harry ; Zhu, Rex > > > > > > ; > > > > Sasha > > > > > > Levin > > > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > > values to DC for smu7/8 > > > > > > > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander > > wrote: > > > > > > > > -Original Message- > > > > > > > > From: Greg Kroah-Hartman > > > > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > > > > To: linux-kernel@vger.kernel.org > > > > > > > > Cc: Greg Kroah-Hartman ; > > > > > > > > sta...@vger.kernel.org; Wentland, Harry > > > > > > > > ; Deucher, Alexander > > > > > > > > ; Zhu, Rex > > ; > > > > Sasha > > > > > > > > Levin > > > > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > > > > values to DC for > > > > > > > > smu7/8 > > > > > > > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, > > > > > > > > please let me > > > > > > know. > > > > > > > > > > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > > > > > > > Is it reverted in "upstream" as well? If not, please get the > > > > > > fix in there and then I will be glad to backport it here. > > > > > > > > > > > > > > > > There's no breakage in upstream. This patch addressed breakages > > > > > in > > > > > 4.19 specifically due to some other refactoring we did in the driver. > > > > > I'll try and dig out the exact series of patches this addressed. > > > > > > > > So there is no problem in 4.19-rc7? That contridicts the statement > > > > of looking in drm-next for the fixes. > > > > > > Sorry, what statement about drm-next? This patch was for 4.19 and was > > not intended for 4.18. It was picked up by Sasha's auto select system for > > stable. > > > > I thought this thread said that. > > > > Ok, so I should just revert it? > > Yes, please. Now reverted, thanks. greg k-h
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message- > From: Greg Kroah-Hartman > Sent: Tuesday, October 9, 2018 8:45 AM > To: Deucher, Alexander > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > ; Zhu, Rex ; Sasha Levin > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > for smu7/8 > > On Mon, Oct 08, 2018 at 06:01:50PM +, Deucher, Alexander wrote: > > > -Original Message- > > > From: Greg Kroah-Hartman > > > Sent: Monday, October 8, 2018 1:11 PM > > > To: Deucher, Alexander > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > > Harry ; Zhu, Rex ; > Sasha > > > Levin > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > to DC for smu7/8 > > > > > > On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > > > > -Original Message- > > > > > From: Greg Kroah-Hartman > > > > > Sent: Monday, October 8, 2018 10:44 AM > > > > > To: Deucher, Alexander > > > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; > > > > > Wentland, Harry ; Zhu, Rex > > > > > ; > > > Sasha > > > > > Levin > > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > values to DC for smu7/8 > > > > > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander > wrote: > > > > > > > -Original Message- > > > > > > > From: Greg Kroah-Hartman > > > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > > > To: linux-kernel@vger.kernel.org > > > > > > > Cc: Greg Kroah-Hartman ; > > > > > > > sta...@vger.kernel.org; Wentland, Harry > > > > > > > ; Deucher, Alexander > > > > > > > ; Zhu, Rex > ; > > > Sasha > > > > > > > Levin > > > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > > > values to DC for > > > > > > > smu7/8 > > > > > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, > > > > > > > please let me > > > > > know. > > > > > > > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > > > > > Is it reverted in "upstream" as well? If not, please get the > > > > > fix in there and then I will be glad to backport it here. > > > > > > > > > > > > > There's no breakage in upstream. This patch addressed breakages > > > > in > > > > 4.19 specifically due to some other refactoring we did in the driver. > > > > I'll try and dig out the exact series of patches this addressed. > > > > > > So there is no problem in 4.19-rc7? That contridicts the statement > > > of looking in drm-next for the fixes. > > > > Sorry, what statement about drm-next? This patch was for 4.19 and was > not intended for 4.18. It was picked up by Sasha's auto select system for > stable. > > I thought this thread said that. > > Ok, so I should just revert it? Yes, please. Thanks, Alex
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message- > From: Greg Kroah-Hartman > Sent: Tuesday, October 9, 2018 8:45 AM > To: Deucher, Alexander > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > ; Zhu, Rex ; Sasha Levin > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > for smu7/8 > > On Mon, Oct 08, 2018 at 06:01:50PM +, Deucher, Alexander wrote: > > > -Original Message- > > > From: Greg Kroah-Hartman > > > Sent: Monday, October 8, 2018 1:11 PM > > > To: Deucher, Alexander > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > > Harry ; Zhu, Rex ; > Sasha > > > Levin > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > to DC for smu7/8 > > > > > > On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > > > > -Original Message- > > > > > From: Greg Kroah-Hartman > > > > > Sent: Monday, October 8, 2018 10:44 AM > > > > > To: Deucher, Alexander > > > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; > > > > > Wentland, Harry ; Zhu, Rex > > > > > ; > > > Sasha > > > > > Levin > > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > values to DC for smu7/8 > > > > > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander > wrote: > > > > > > > -Original Message- > > > > > > > From: Greg Kroah-Hartman > > > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > > > To: linux-kernel@vger.kernel.org > > > > > > > Cc: Greg Kroah-Hartman ; > > > > > > > sta...@vger.kernel.org; Wentland, Harry > > > > > > > ; Deucher, Alexander > > > > > > > ; Zhu, Rex > ; > > > Sasha > > > > > > > Levin > > > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > > > values to DC for > > > > > > > smu7/8 > > > > > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, > > > > > > > please let me > > > > > know. > > > > > > > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > > > > > Is it reverted in "upstream" as well? If not, please get the > > > > > fix in there and then I will be glad to backport it here. > > > > > > > > > > > > > There's no breakage in upstream. This patch addressed breakages > > > > in > > > > 4.19 specifically due to some other refactoring we did in the driver. > > > > I'll try and dig out the exact series of patches this addressed. > > > > > > So there is no problem in 4.19-rc7? That contridicts the statement > > > of looking in drm-next for the fixes. > > > > Sorry, what statement about drm-next? This patch was for 4.19 and was > not intended for 4.18. It was picked up by Sasha's auto select system for > stable. > > I thought this thread said that. > > Ok, so I should just revert it? Yes, please. Thanks, Alex
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On 2018-10-08 12:17 PM, Deucher, Alexander wrote:
>> -Original Message-
>> From: Sasha Levin
>> Sent: Monday, October 8, 2018 10:49 AM
>> To: Deucher, Alexander
>> Cc: Greg Kroah-Hartman ; linux-
>> ker...@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry
>> ; Zhu, Rex ; Sasha Levin
>>
>> Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
>> for smu7/8
>>
>> On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote:
>>>> -Original Message-
>>>> From: Greg Kroah-Hartman
>>>> Sent: Monday, September 24, 2018 7:53 AM
>>>> To: linux-kernel@vger.kernel.org
>>>> Cc: Greg Kroah-Hartman ;
>>>> sta...@vger.kernel.org; Wentland, Harry ;
>>>> Deucher, Alexander ; Zhu, Rex
>>>> ; Sasha Levin
>>>> Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
>>>> for
>>>> smu7/8
>>>>
>>>> 4.18-stable review patch. If anyone has any objections, please let me
>> know.
>>>>
>>>
>>> This regresses power usage on 4.18. Please revert.
>>> https://bugzilla.kernel.org/show_bug.cgi?id=201275
>>
>> Hi Alex,
>>
>> Thank you for the report.
>>
>> I'm working on improving this process, I'd be very grateful if you could
>> answer a few questions about this:
>>
>> 1. Is the same breakage seen upstream? (if so, it should be reverted there as
>> well and we can grab the revert into -stable).
>
> No regression in 4.19 or -next.
>
>> 2. Does the issue reported by this patch ("pipes seem to hang with a 4k DP
>> and 1080p HDMI display") exist in the 4.18 stable tree?
>
> I don't think so, but I'm not 100% sure. Harry, Rex do you know if this is a
> general issue or was it just fall out from the changes to the interface?
>
It was intended to deal with fallout to smu7/8 caused by the change to move the
kHz-to-10kHz-conversion from display to powerplay. I believe that conversion
initially overlooked these blocks. Rex, please correct me if I'm wrong. You
probably know more about this than I do.
So yes, I agree, it was never intended to be used without the change to drop
the *10 in display code, which was done with this change:
commit 23ec3d1479fd79658cd52c47618d8ddd2f32550b
Author: Rex Zhu
Date: Mon Jun 18 18:15:15 2018 +0800
drm/amd/pp: Convert clock unit to KHz as defined
Convert clock unit 10KHz to KHz as the data sturct defined.
e.g.
struct pp_clock_with_latency {
uint32_t clocks_in_khz;
uint32_t latency_in_us;
};
Meanwhile revert the same conversion in display side.
Acked-by: Alex Deucher
Acked-by: Harry Wentland
Signed-off-by: Rex Zhu
Signed-off-by: Alex Deucher
I don't see this change in the 4.18.y stable tree. I probably should've caught
that with the initial 4.18-stable review patch.
Harry
>> 3. If not, could you briefly explain why?
>
> We refactored the interface between the power and display components and this
> patch fixed up some of that fallout due to the differences in units used in
> each component.
>
>>
>>
>> The algorithm I use was very confident about this patch being stable
>> material,
>> and when I looked at it back then (and again now) I was very confident of the
>> same. If I can understand where I was wrong I could improve my process.
>
> There are some other dependent patches required that were not flagged in the
> patch itself. IIRC, they were a bit big for stable.
>
> Alex
>
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On 2018-10-08 12:17 PM, Deucher, Alexander wrote:
>> -Original Message-
>> From: Sasha Levin
>> Sent: Monday, October 8, 2018 10:49 AM
>> To: Deucher, Alexander
>> Cc: Greg Kroah-Hartman ; linux-
>> ker...@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry
>> ; Zhu, Rex ; Sasha Levin
>>
>> Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
>> for smu7/8
>>
>> On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote:
>>>> -Original Message-
>>>> From: Greg Kroah-Hartman
>>>> Sent: Monday, September 24, 2018 7:53 AM
>>>> To: linux-kernel@vger.kernel.org
>>>> Cc: Greg Kroah-Hartman ;
>>>> sta...@vger.kernel.org; Wentland, Harry ;
>>>> Deucher, Alexander ; Zhu, Rex
>>>> ; Sasha Levin
>>>> Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
>>>> for
>>>> smu7/8
>>>>
>>>> 4.18-stable review patch. If anyone has any objections, please let me
>> know.
>>>>
>>>
>>> This regresses power usage on 4.18. Please revert.
>>> https://bugzilla.kernel.org/show_bug.cgi?id=201275
>>
>> Hi Alex,
>>
>> Thank you for the report.
>>
>> I'm working on improving this process, I'd be very grateful if you could
>> answer a few questions about this:
>>
>> 1. Is the same breakage seen upstream? (if so, it should be reverted there as
>> well and we can grab the revert into -stable).
>
> No regression in 4.19 or -next.
>
>> 2. Does the issue reported by this patch ("pipes seem to hang with a 4k DP
>> and 1080p HDMI display") exist in the 4.18 stable tree?
>
> I don't think so, but I'm not 100% sure. Harry, Rex do you know if this is a
> general issue or was it just fall out from the changes to the interface?
>
It was intended to deal with fallout to smu7/8 caused by the change to move the
kHz-to-10kHz-conversion from display to powerplay. I believe that conversion
initially overlooked these blocks. Rex, please correct me if I'm wrong. You
probably know more about this than I do.
So yes, I agree, it was never intended to be used without the change to drop
the *10 in display code, which was done with this change:
commit 23ec3d1479fd79658cd52c47618d8ddd2f32550b
Author: Rex Zhu
Date: Mon Jun 18 18:15:15 2018 +0800
drm/amd/pp: Convert clock unit to KHz as defined
Convert clock unit 10KHz to KHz as the data sturct defined.
e.g.
struct pp_clock_with_latency {
uint32_t clocks_in_khz;
uint32_t latency_in_us;
};
Meanwhile revert the same conversion in display side.
Acked-by: Alex Deucher
Acked-by: Harry Wentland
Signed-off-by: Rex Zhu
Signed-off-by: Alex Deucher
I don't see this change in the 4.18.y stable tree. I probably should've caught
that with the initial 4.18-stable review patch.
Harry
>> 3. If not, could you briefly explain why?
>
> We refactored the interface between the power and display components and this
> patch fixed up some of that fallout due to the differences in units used in
> each component.
>
>>
>>
>> The algorithm I use was very confident about this patch being stable
>> material,
>> and when I looked at it back then (and again now) I was very confident of the
>> same. If I can understand where I was wrong I could improve my process.
>
> There are some other dependent patches required that were not flagged in the
> patch itself. IIRC, they were a bit big for stable.
>
> Alex
>
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Mon, Oct 08, 2018 at 06:01:50PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Monday, October 8, 2018 1:11 PM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > > ; Zhu, Rex ; Sasha Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > > for smu7/8 > > > > On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > > > -Original Message- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, October 8, 2018 10:44 AM > > > > To: Deucher, Alexander > > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > > > Harry ; Zhu, Rex ; > > Sasha > > > > Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > to DC for smu7/8 > > > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > > > > -Original Message- > > > > > > From: Greg Kroah-Hartman > > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > > To: linux-kernel@vger.kernel.org > > > > > > Cc: Greg Kroah-Hartman ; > > > > > > sta...@vger.kernel.org; Wentland, Harry > > > > > > ; Deucher, Alexander > > > > > > ; Zhu, Rex ; > > Sasha > > > > > > Levin > > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > > > to DC for > > > > > > smu7/8 > > > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, please > > > > > > let me > > > > know. > > > > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > > > Is it reverted in "upstream" as well? If not, please get the fix in > > > > there and then I will be glad to backport it here. > > > > > > > > > > There's no breakage in upstream. This patch addressed breakages in > > > 4.19 specifically due to some other refactoring we did in the driver. > > > I'll try and dig out the exact series of patches this addressed. > > > > So there is no problem in 4.19-rc7? That contridicts the statement of > > looking > > in drm-next for the fixes. > > Sorry, what statement about drm-next? This patch was for 4.19 and was not > intended for 4.18. It was picked up by Sasha's auto select system for stable. I thought this thread said that. Ok, so I should just revert it? thanks, greg k-h
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Mon, Oct 08, 2018 at 06:01:50PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Monday, October 8, 2018 1:11 PM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > > ; Zhu, Rex ; Sasha Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > > for smu7/8 > > > > On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > > > -Original Message- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, October 8, 2018 10:44 AM > > > > To: Deucher, Alexander > > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > > > Harry ; Zhu, Rex ; > > Sasha > > > > Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > to DC for smu7/8 > > > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > > > > -Original Message- > > > > > > From: Greg Kroah-Hartman > > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > > To: linux-kernel@vger.kernel.org > > > > > > Cc: Greg Kroah-Hartman ; > > > > > > sta...@vger.kernel.org; Wentland, Harry > > > > > > ; Deucher, Alexander > > > > > > ; Zhu, Rex ; > > Sasha > > > > > > Levin > > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > > > to DC for > > > > > > smu7/8 > > > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, please > > > > > > let me > > > > know. > > > > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > > > Is it reverted in "upstream" as well? If not, please get the fix in > > > > there and then I will be glad to backport it here. > > > > > > > > > > There's no breakage in upstream. This patch addressed breakages in > > > 4.19 specifically due to some other refactoring we did in the driver. > > > I'll try and dig out the exact series of patches this addressed. > > > > So there is no problem in 4.19-rc7? That contridicts the statement of > > looking > > in drm-next for the fixes. > > Sorry, what statement about drm-next? This patch was for 4.19 and was not > intended for 4.18. It was picked up by Sasha's auto select system for stable. I thought this thread said that. Ok, so I should just revert it? thanks, greg k-h
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message- > From: Greg Kroah-Hartman > Sent: Monday, October 8, 2018 1:11 PM > To: Deucher, Alexander > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > ; Zhu, Rex ; Sasha Levin > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > for smu7/8 > > On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > > -Original Message- > > > From: Greg Kroah-Hartman > > > Sent: Monday, October 8, 2018 10:44 AM > > > To: Deucher, Alexander > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > > Harry ; Zhu, Rex ; > Sasha > > > Levin > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > to DC for smu7/8 > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > > > -Original Message- > > > > > From: Greg Kroah-Hartman > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > To: linux-kernel@vger.kernel.org > > > > > Cc: Greg Kroah-Hartman ; > > > > > sta...@vger.kernel.org; Wentland, Harry > > > > > ; Deucher, Alexander > > > > > ; Zhu, Rex ; > Sasha > > > > > Levin > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > > to DC for > > > > > smu7/8 > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, please > > > > > let me > > > know. > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > Is it reverted in "upstream" as well? If not, please get the fix in > > > there and then I will be glad to backport it here. > > > > > > > There's no breakage in upstream. This patch addressed breakages in > > 4.19 specifically due to some other refactoring we did in the driver. > > I'll try and dig out the exact series of patches this addressed. > > So there is no problem in 4.19-rc7? That contridicts the statement of looking > in drm-next for the fixes. Sorry, what statement about drm-next? This patch was for 4.19 and was not intended for 4.18. It was picked up by Sasha's auto select system for stable. Alex
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message- > From: Greg Kroah-Hartman > Sent: Monday, October 8, 2018 1:11 PM > To: Deucher, Alexander > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > ; Zhu, Rex ; Sasha Levin > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > for smu7/8 > > On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > > -Original Message- > > > From: Greg Kroah-Hartman > > > Sent: Monday, October 8, 2018 10:44 AM > > > To: Deucher, Alexander > > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > > Harry ; Zhu, Rex ; > Sasha > > > Levin > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > to DC for smu7/8 > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > > > -Original Message- > > > > > From: Greg Kroah-Hartman > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > To: linux-kernel@vger.kernel.org > > > > > Cc: Greg Kroah-Hartman ; > > > > > sta...@vger.kernel.org; Wentland, Harry > > > > > ; Deucher, Alexander > > > > > ; Zhu, Rex ; > Sasha > > > > > Levin > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > > to DC for > > > > > smu7/8 > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, please > > > > > let me > > > know. > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > Is it reverted in "upstream" as well? If not, please get the fix in > > > there and then I will be glad to backport it here. > > > > > > > There's no breakage in upstream. This patch addressed breakages in > > 4.19 specifically due to some other refactoring we did in the driver. > > I'll try and dig out the exact series of patches this addressed. > > So there is no problem in 4.19-rc7? That contridicts the statement of looking > in drm-next for the fixes. Sorry, what statement about drm-next? This patch was for 4.19 and was not intended for 4.18. It was picked up by Sasha's auto select system for stable. Alex
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Monday, October 8, 2018 10:44 AM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > > ; Zhu, Rex ; Sasha Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > > for smu7/8 > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > > -Original Message- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > To: linux-kernel@vger.kernel.org > > > > Cc: Greg Kroah-Hartman ; > > > > sta...@vger.kernel.org; Wentland, Harry ; > > > > Deucher, Alexander ; Zhu, Rex > > > > ; Sasha Levin > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to > > > > DC for > > > > smu7/8 > > > > > > > > 4.18-stable review patch. If anyone has any objections, please let me > > know. > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > Is it reverted in "upstream" as well? If not, please get the fix in there > > and > > then I will be glad to backport it here. > > > > There's no breakage in upstream. This patch addressed breakages in > 4.19 specifically due to some other refactoring we did in the driver. > I'll try and dig out the exact series of patches this addressed. So there is no problem in 4.19-rc7? That contridicts the statement of looking in drm-next for the fixes. confused, greg k-h
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Mon, Oct 08, 2018 at 04:02:19PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Monday, October 8, 2018 10:44 AM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > > ; Zhu, Rex ; Sasha Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > > for smu7/8 > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > > -Original Message- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > To: linux-kernel@vger.kernel.org > > > > Cc: Greg Kroah-Hartman ; > > > > sta...@vger.kernel.org; Wentland, Harry ; > > > > Deucher, Alexander ; Zhu, Rex > > > > ; Sasha Levin > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to > > > > DC for > > > > smu7/8 > > > > > > > > 4.18-stable review patch. If anyone has any objections, please let me > > know. > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > Is it reverted in "upstream" as well? If not, please get the fix in there > > and > > then I will be glad to backport it here. > > > > There's no breakage in upstream. This patch addressed breakages in > 4.19 specifically due to some other refactoring we did in the driver. > I'll try and dig out the exact series of patches this addressed. So there is no problem in 4.19-rc7? That contridicts the statement of looking in drm-next for the fixes. confused, greg k-h
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message-
> From: Sasha Levin
> Sent: Monday, October 8, 2018 10:49 AM
> To: Deucher, Alexander
> Cc: Greg Kroah-Hartman ; linux-
> ker...@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry
> ; Zhu, Rex ; Sasha Levin
>
> Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
> for smu7/8
>
> On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote:
> >> -Original Message-
> >> From: Greg Kroah-Hartman
> >> Sent: Monday, September 24, 2018 7:53 AM
> >> To: linux-kernel@vger.kernel.org
> >> Cc: Greg Kroah-Hartman ;
> >> sta...@vger.kernel.org; Wentland, Harry ;
> >> Deucher, Alexander ; Zhu, Rex
> >> ; Sasha Levin
> >> Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
> >> for
> >> smu7/8
> >>
> >> 4.18-stable review patch. If anyone has any objections, please let me
> know.
> >>
> >
> >This regresses power usage on 4.18. Please revert.
> >https://bugzilla.kernel.org/show_bug.cgi?id=201275
>
> Hi Alex,
>
> Thank you for the report.
>
> I'm working on improving this process, I'd be very grateful if you could
> answer a few questions about this:
>
> 1. Is the same breakage seen upstream? (if so, it should be reverted there as
> well and we can grab the revert into -stable).
No regression in 4.19 or -next.
> 2. Does the issue reported by this patch ("pipes seem to hang with a 4k DP
> and 1080p HDMI display") exist in the 4.18 stable tree?
I don't think so, but I'm not 100% sure. Harry, Rex do you know if this is a
general issue or was it just fall out from the changes to the interface?
> 3. If not, could you briefly explain why?
We refactored the interface between the power and display components and this
patch fixed up some of that fallout due to the differences in units used in
each component.
>
>
> The algorithm I use was very confident about this patch being stable material,
> and when I looked at it back then (and again now) I was very confident of the
> same. If I can understand where I was wrong I could improve my process.
There are some other dependent patches required that were not flagged in the
patch itself. IIRC, they were a bit big for stable.
Alex
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message-
> From: Sasha Levin
> Sent: Monday, October 8, 2018 10:49 AM
> To: Deucher, Alexander
> Cc: Greg Kroah-Hartman ; linux-
> ker...@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry
> ; Zhu, Rex ; Sasha Levin
>
> Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
> for smu7/8
>
> On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote:
> >> -Original Message-
> >> From: Greg Kroah-Hartman
> >> Sent: Monday, September 24, 2018 7:53 AM
> >> To: linux-kernel@vger.kernel.org
> >> Cc: Greg Kroah-Hartman ;
> >> sta...@vger.kernel.org; Wentland, Harry ;
> >> Deucher, Alexander ; Zhu, Rex
> >> ; Sasha Levin
> >> Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC
> >> for
> >> smu7/8
> >>
> >> 4.18-stable review patch. If anyone has any objections, please let me
> know.
> >>
> >
> >This regresses power usage on 4.18. Please revert.
> >https://bugzilla.kernel.org/show_bug.cgi?id=201275
>
> Hi Alex,
>
> Thank you for the report.
>
> I'm working on improving this process, I'd be very grateful if you could
> answer a few questions about this:
>
> 1. Is the same breakage seen upstream? (if so, it should be reverted there as
> well and we can grab the revert into -stable).
No regression in 4.19 or -next.
> 2. Does the issue reported by this patch ("pipes seem to hang with a 4k DP
> and 1080p HDMI display") exist in the 4.18 stable tree?
I don't think so, but I'm not 100% sure. Harry, Rex do you know if this is a
general issue or was it just fall out from the changes to the interface?
> 3. If not, could you briefly explain why?
We refactored the interface between the power and display components and this
patch fixed up some of that fallout due to the differences in units used in
each component.
>
>
> The algorithm I use was very confident about this patch being stable material,
> and when I looked at it back then (and again now) I was very confident of the
> same. If I can understand where I was wrong I could improve my process.
There are some other dependent patches required that were not flagged in the
patch itself. IIRC, they were a bit big for stable.
Alex
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
Hi Alex, Yes, we have fixed this issue in drm-next. I am trying to dig out the patches in drm-next and will sent them out. Regards Rex > -Original Message- > From: Deucher, Alexander > Sent: Tuesday, October 9, 2018 12:02 AM > To: Greg Kroah-Hartman > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > ; Zhu, Rex ; Sasha Levin > > Subject: RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > for smu7/8 > > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Monday, October 8, 2018 10:44 AM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > Harry ; Zhu, Rex ; > Sasha > > Levin > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to > > DC for smu7/8 > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > > -Original Message- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > To: linux-kernel@vger.kernel.org > > > > Cc: Greg Kroah-Hartman ; > > > > sta...@vger.kernel.org; Wentland, Harry ; > > > > Deucher, Alexander ; Zhu, Rex > > > > ; Sasha Levin > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to > > > > DC for > > > > smu7/8 > > > > > > > > 4.18-stable review patch. If anyone has any objections, please > > > > let me > > know. > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > Is it reverted in "upstream" as well? If not, please get the fix in > > there and then I will be glad to backport it here. > > > > There's no breakage in upstream. This patch addressed breakages in 4.19 > specifically due to some other refactoring we did in the driver. I'll try > and dig > out the exact series of patches this addressed. > > Alex > > > thanks, > > > > greg k-h
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
Hi Alex, Yes, we have fixed this issue in drm-next. I am trying to dig out the patches in drm-next and will sent them out. Regards Rex > -Original Message- > From: Deucher, Alexander > Sent: Tuesday, October 9, 2018 12:02 AM > To: Greg Kroah-Hartman > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > ; Zhu, Rex ; Sasha Levin > > Subject: RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > for smu7/8 > > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Monday, October 8, 2018 10:44 AM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, > > Harry ; Zhu, Rex ; > Sasha > > Levin > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to > > DC for smu7/8 > > > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > > -Original Message- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > To: linux-kernel@vger.kernel.org > > > > Cc: Greg Kroah-Hartman ; > > > > sta...@vger.kernel.org; Wentland, Harry ; > > > > Deucher, Alexander ; Zhu, Rex > > > > ; Sasha Levin > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to > > > > DC for > > > > smu7/8 > > > > > > > > 4.18-stable review patch. If anyone has any objections, please > > > > let me > > know. > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > Is it reverted in "upstream" as well? If not, please get the fix in > > there and then I will be glad to backport it here. > > > > There's no breakage in upstream. This patch addressed breakages in 4.19 > specifically due to some other refactoring we did in the driver. I'll try > and dig > out the exact series of patches this addressed. > > Alex > > > thanks, > > > > greg k-h
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message- > From: Greg Kroah-Hartman > Sent: Monday, October 8, 2018 10:44 AM > To: Deucher, Alexander > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > ; Zhu, Rex ; Sasha Levin > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > for smu7/8 > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > -Original Message- > > > From: Greg Kroah-Hartman > > > Sent: Monday, September 24, 2018 7:53 AM > > > To: linux-kernel@vger.kernel.org > > > Cc: Greg Kroah-Hartman ; > > > sta...@vger.kernel.org; Wentland, Harry ; > > > Deucher, Alexander ; Zhu, Rex > > > ; Sasha Levin > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to > > > DC for > > > smu7/8 > > > > > > 4.18-stable review patch. If anyone has any objections, please let me > know. > > > > > > > This regresses power usage on 4.18. Please revert. > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > Is it reverted in "upstream" as well? If not, please get the fix in there and > then I will be glad to backport it here. > There's no breakage in upstream. This patch addressed breakages in 4.19 specifically due to some other refactoring we did in the driver. I'll try and dig out the exact series of patches this addressed. Alex > thanks, > > greg k-h
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message- > From: Greg Kroah-Hartman > Sent: Monday, October 8, 2018 10:44 AM > To: Deucher, Alexander > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Wentland, Harry > ; Zhu, Rex ; Sasha Levin > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > for smu7/8 > > On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > > -Original Message- > > > From: Greg Kroah-Hartman > > > Sent: Monday, September 24, 2018 7:53 AM > > > To: linux-kernel@vger.kernel.org > > > Cc: Greg Kroah-Hartman ; > > > sta...@vger.kernel.org; Wentland, Harry ; > > > Deucher, Alexander ; Zhu, Rex > > > ; Sasha Levin > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to > > > DC for > > > smu7/8 > > > > > > 4.18-stable review patch. If anyone has any objections, please let me > know. > > > > > > > This regresses power usage on 4.18. Please revert. > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > Is it reverted in "upstream" as well? If not, please get the fix in there and > then I will be glad to backport it here. > There's no breakage in upstream. This patch addressed breakages in 4.19 specifically due to some other refactoring we did in the driver. I'll try and dig out the exact series of patches this addressed. Alex > thanks, > > greg k-h
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote:
-Original Message-
From: Greg Kroah-Hartman
Sent: Monday, September 24, 2018 7:53 AM
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman ;
sta...@vger.kernel.org; Wentland, Harry ;
Deucher, Alexander ; Zhu, Rex
; Sasha Levin
Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for
smu7/8
4.18-stable review patch. If anyone has any objections, please let me know.
This regresses power usage on 4.18. Please revert.
https://bugzilla.kernel.org/show_bug.cgi?id=201275
Hi Alex,
Thank you for the report.
I'm working on improving this process, I'd be very grateful if you could
answer a few questions about this:
1. Is the same breakage seen upstream? (if so, it should be reverted
there as well and we can grab the revert into -stable).
2. Does the issue reported by this patch ("pipes seem to hang with a 4k
DP and 1080p HDMI display") exist in the 4.18 stable tree?
3. If not, could you briefly explain why?
The algorithm I use was very confident about this patch being stable
material, and when I looked at it back then (and again now) I was very
confident of the same. If I can understand where I was wrong I could
improve my process.
Thank you!
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote:
-Original Message-
From: Greg Kroah-Hartman
Sent: Monday, September 24, 2018 7:53 AM
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman ;
sta...@vger.kernel.org; Wentland, Harry ;
Deucher, Alexander ; Zhu, Rex
; Sasha Levin
Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for
smu7/8
4.18-stable review patch. If anyone has any objections, please let me know.
This regresses power usage on 4.18. Please revert.
https://bugzilla.kernel.org/show_bug.cgi?id=201275
Hi Alex,
Thank you for the report.
I'm working on improving this process, I'd be very grateful if you could
answer a few questions about this:
1. Is the same breakage seen upstream? (if so, it should be reverted
there as well and we can grab the revert into -stable).
2. Does the issue reported by this patch ("pipes seem to hang with a 4k
DP and 1080p HDMI display") exist in the 4.18 stable tree?
3. If not, could you briefly explain why?
The algorithm I use was very confident about this patch being stable
material, and when I looked at it back then (and again now) I was very
confident of the same. If I can understand where I was wrong I could
improve my process.
Thank you!
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Monday, September 24, 2018 7:53 AM > > To: linux-kernel@vger.kernel.org > > Cc: Greg Kroah-Hartman ; > > sta...@vger.kernel.org; Wentland, Harry ; > > Deucher, Alexander ; Zhu, Rex > > ; Sasha Levin > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for > > smu7/8 > > > > 4.18-stable review patch. If anyone has any objections, please let me know. > > > > This regresses power usage on 4.18. Please revert. > https://bugzilla.kernel.org/show_bug.cgi?id=201275 Is it reverted in "upstream" as well? If not, please get the fix in there and then I will be glad to backport it here. thanks, greg k-h
Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
On Mon, Oct 08, 2018 at 02:33:56PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Monday, September 24, 2018 7:53 AM > > To: linux-kernel@vger.kernel.org > > Cc: Greg Kroah-Hartman ; > > sta...@vger.kernel.org; Wentland, Harry ; > > Deucher, Alexander ; Zhu, Rex > > ; Sasha Levin > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for > > smu7/8 > > > > 4.18-stable review patch. If anyone has any objections, please let me know. > > > > This regresses power usage on 4.18. Please revert. > https://bugzilla.kernel.org/show_bug.cgi?id=201275 Is it reverted in "upstream" as well? If not, please get the fix in there and then I will be glad to backport it here. thanks, greg k-h
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message-
> From: Greg Kroah-Hartman
> Sent: Monday, September 24, 2018 7:53 AM
> To: linux-kernel@vger.kernel.org
> Cc: Greg Kroah-Hartman ;
> sta...@vger.kernel.org; Wentland, Harry ;
> Deucher, Alexander ; Zhu, Rex
> ; Sasha Levin
> Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for
> smu7/8
>
> 4.18-stable review patch. If anyone has any objections, please let me know.
>
This regresses power usage on 4.18. Please revert.
https://bugzilla.kernel.org/show_bug.cgi?id=201275
Thanks,
Alex
> --
>
> From: Harry Wentland
>
> [ Upstream commit c3cb424a086921f6bb0449b10d998352a756d6d5 ]
>
> The previous change wasn't covering smu 7 and 8 and therefore DC was
> seeing wrong clock values.
>
> This fixes an issue where the pipes seem to hang with a 4k DP and 1080p
> HDMI display.
>
> Fixes: c3df50abc84b ("drm/amd/pp: Convert clock unit to KHz as defined")
> Signed-off-by: Harry Wentland
> Acked-by: Alex Deucher
> Cc:rex@amd.com
> Signed-off-by: Alex Deucher
> Signed-off-by: Sasha Levin
> Signed-off-by: Greg Kroah-Hartman
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c |8
> drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c |6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -4555,12 +4555,12 @@ static int smu7_get_sclks(struct pp_hwmg
> return -EINVAL;
> dep_sclk_table = table_info->vdd_dep_on_sclk;
> for (i = 0; i < dep_sclk_table->count; i++)
> - clocks->clock[i] = dep_sclk_table->entries[i].clk;
> + clocks->clock[i] = dep_sclk_table->entries[i].clk * 10;
> clocks->count = dep_sclk_table->count;
> } else if (hwmgr->pp_table_version == PP_TABLE_V0) {
> sclk_table = hwmgr->dyn_state.vddc_dependency_on_sclk;
> for (i = 0; i < sclk_table->count; i++)
> - clocks->clock[i] = sclk_table->entries[i].clk;
> + clocks->clock[i] = sclk_table->entries[i].clk * 10;
> clocks->count = sclk_table->count;
> }
>
> @@ -4592,7 +4592,7 @@ static int smu7_get_mclks(struct pp_hwmg
> return -EINVAL;
> dep_mclk_table = table_info->vdd_dep_on_mclk;
> for (i = 0; i < dep_mclk_table->count; i++) {
> - clocks->clock[i] = dep_mclk_table->entries[i].clk;
> + clocks->clock[i] = dep_mclk_table->entries[i].clk * 10;
> clocks->latency[i] = smu7_get_mem_latency(hwmgr,
> dep_mclk_table-
> >entries[i].clk);
> }
> @@ -4600,7 +4600,7 @@ static int smu7_get_mclks(struct pp_hwmg
> } else if (hwmgr->pp_table_version == PP_TABLE_V0) {
> mclk_table = hwmgr-
> >dyn_state.vddc_dependency_on_mclk;
> for (i = 0; i < mclk_table->count; i++)
> - clocks->clock[i] = mclk_table->entries[i].clk;
> + clocks->clock[i] = mclk_table->entries[i].clk * 10;
> clocks->count = mclk_table->count;
> }
> return 0;
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c
> @@ -1605,17 +1605,17 @@ static int smu8_get_clock_by_type(struct
> switch (type) {
> case amd_pp_disp_clock:
> for (i = 0; i < clocks->count; i++)
> - clocks->clock[i] = data->sys_info.display_clock[i];
> + clocks->clock[i] = data->sys_info.display_clock[i] * 10;
> break;
> case amd_pp_sys_clock:
> table = hwmgr->dyn_state.vddc_dependency_on_sclk;
> for (i = 0; i < clocks->count; i++)
> - clocks->clock[i] = table->entries[i].clk;
> + clocks->clock[i] = table->entries[i].clk * 10;
> break;
> case amd_pp_mem_clock:
> clocks->count = SMU8_NUM_NBPMEMORYCLOCK;
> for (i = 0; i < clocks->count; i++)
> - clocks->clock[i] = data-
> >sys_info.nbp_memory_clock[clocks->count - 1 - i];
> + clocks->clock[i] = data-
> >sys_info.nbp_memory_clock[clocks->count - 1
> +- i] * 10;
> break;
> default:
> return -1;
>
RE: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8
> -Original Message-
> From: Greg Kroah-Hartman
> Sent: Monday, September 24, 2018 7:53 AM
> To: linux-kernel@vger.kernel.org
> Cc: Greg Kroah-Hartman ;
> sta...@vger.kernel.org; Wentland, Harry ;
> Deucher, Alexander ; Zhu, Rex
> ; Sasha Levin
> Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for
> smu7/8
>
> 4.18-stable review patch. If anyone has any objections, please let me know.
>
This regresses power usage on 4.18. Please revert.
https://bugzilla.kernel.org/show_bug.cgi?id=201275
Thanks,
Alex
> --
>
> From: Harry Wentland
>
> [ Upstream commit c3cb424a086921f6bb0449b10d998352a756d6d5 ]
>
> The previous change wasn't covering smu 7 and 8 and therefore DC was
> seeing wrong clock values.
>
> This fixes an issue where the pipes seem to hang with a 4k DP and 1080p
> HDMI display.
>
> Fixes: c3df50abc84b ("drm/amd/pp: Convert clock unit to KHz as defined")
> Signed-off-by: Harry Wentland
> Acked-by: Alex Deucher
> Cc:rex@amd.com
> Signed-off-by: Alex Deucher
> Signed-off-by: Sasha Levin
> Signed-off-by: Greg Kroah-Hartman
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c |8
> drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c |6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -4555,12 +4555,12 @@ static int smu7_get_sclks(struct pp_hwmg
> return -EINVAL;
> dep_sclk_table = table_info->vdd_dep_on_sclk;
> for (i = 0; i < dep_sclk_table->count; i++)
> - clocks->clock[i] = dep_sclk_table->entries[i].clk;
> + clocks->clock[i] = dep_sclk_table->entries[i].clk * 10;
> clocks->count = dep_sclk_table->count;
> } else if (hwmgr->pp_table_version == PP_TABLE_V0) {
> sclk_table = hwmgr->dyn_state.vddc_dependency_on_sclk;
> for (i = 0; i < sclk_table->count; i++)
> - clocks->clock[i] = sclk_table->entries[i].clk;
> + clocks->clock[i] = sclk_table->entries[i].clk * 10;
> clocks->count = sclk_table->count;
> }
>
> @@ -4592,7 +4592,7 @@ static int smu7_get_mclks(struct pp_hwmg
> return -EINVAL;
> dep_mclk_table = table_info->vdd_dep_on_mclk;
> for (i = 0; i < dep_mclk_table->count; i++) {
> - clocks->clock[i] = dep_mclk_table->entries[i].clk;
> + clocks->clock[i] = dep_mclk_table->entries[i].clk * 10;
> clocks->latency[i] = smu7_get_mem_latency(hwmgr,
> dep_mclk_table-
> >entries[i].clk);
> }
> @@ -4600,7 +4600,7 @@ static int smu7_get_mclks(struct pp_hwmg
> } else if (hwmgr->pp_table_version == PP_TABLE_V0) {
> mclk_table = hwmgr-
> >dyn_state.vddc_dependency_on_mclk;
> for (i = 0; i < mclk_table->count; i++)
> - clocks->clock[i] = mclk_table->entries[i].clk;
> + clocks->clock[i] = mclk_table->entries[i].clk * 10;
> clocks->count = mclk_table->count;
> }
> return 0;
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c
> @@ -1605,17 +1605,17 @@ static int smu8_get_clock_by_type(struct
> switch (type) {
> case amd_pp_disp_clock:
> for (i = 0; i < clocks->count; i++)
> - clocks->clock[i] = data->sys_info.display_clock[i];
> + clocks->clock[i] = data->sys_info.display_clock[i] * 10;
> break;
> case amd_pp_sys_clock:
> table = hwmgr->dyn_state.vddc_dependency_on_sclk;
> for (i = 0; i < clocks->count; i++)
> - clocks->clock[i] = table->entries[i].clk;
> + clocks->clock[i] = table->entries[i].clk * 10;
> break;
> case amd_pp_mem_clock:
> clocks->count = SMU8_NUM_NBPMEMORYCLOCK;
> for (i = 0; i < clocks->count; i++)
> - clocks->clock[i] = data-
> >sys_info.nbp_memory_clock[clocks->count - 1 - i];
> + clocks->clock[i] = data-
> >sys_info.nbp_memory_clock[clocks->count - 1
> +- i] * 10;
> break;
> default:
> return -1;
>
