RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-30 Thread Lijun Pan
> Rivera Jose-B46482 ; Li Yang-Leo-R58472 > ; ag...@suse.de; Hamciuc Bogdan-BHAMCIU1 > ; Marginean Alexandru-R89243 > ; Sharma Bhupesh-B45370 > ; Erez Nir-RM30794 > ; Schmitt Richard-B43082 > ; dan.carpen...@oracle.com > Subject: RE: [PATCH 5/5] stagi

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-30 Thread Lijun Pan
n Alexandru-R89243 > <r89...@freescale.com>; Sharma Bhupesh-B45370 > <bhupesh.sha...@freescale.com>; Erez Nir-RM30794 > <nir.e...@freescale.com>; Schmitt Richard-B43082 > <richard.schm...@freescale.com>; dan.carpen...@oracle.com > Subject: RE: [PATCH 5/5] stagin

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-29 Thread Lijun Pan
> Rivera Jose-B46482 ; Li Yang-Leo-R58472 > ; ag...@suse.de; Hamciuc Bogdan-BHAMCIU1 > ; Marginean Alexandru-R89243 > ; Sharma Bhupesh-B45370 > ; Erez Nir-RM30794 > ; Schmitt Richard-B43082 > ; dan.carpen...@oracle.com > Subject: Re: [PATCH 5/5] staging: fsl-mc: Management C

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-29 Thread Lijun Pan
n Alexandru-R89243 > <r89...@freescale.com>; Sharma Bhupesh-B45370 > <bhupesh.sha...@freescale.com>; Erez Nir-RM30794 > <nir.e...@freescale.com>; Schmitt Richard-B43082 > <richard.schm...@freescale.com>; dan.carpen...@oracle.com > Subject: Re: [PATCH 5/5] s

Re: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Scott Wood
On Sun, 2015-10-25 at 17:41 -0500, Lijun Pan wrote: > The kernel support for the restool (a user space resource management > tool) is a driver for the /dev/dprc.N device file. > Its purpose is to provide an ioctl interface, > which the restool uses to interact with the MC bus driver > and with the

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Stuart Yoder
> -Original Message- > From: Lijun Pan [mailto:lijun@freescale.com] > Sent: Sunday, October 25, 2015 5:41 PM > To: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org > Cc: Yoder Stuart-B08248; katz Itai-RM05202; Rivera Jose-B46482;

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Lijun Pan
8248 > ; katz Itai-RM05202 ; > Rivera Jose-B46482 ; Li Yang-Leo-R58472 > ; Wood Scott-B07421 ; > ag...@suse.de; Hamciuc Bogdan-BHAMCIU1 ; > Marginean Alexandru-R89243 ; Sharma Bhupesh- > B45370 ; Erez Nir-RM30794 > ; Schmitt Richard-B43082 > > Subject: Re: [PATCH 5/5] stagi

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Stuart Yoder
> -Original Message- > From: Lijun Pan [mailto:lijun@freescale.com] > Sent: Sunday, October 25, 2015 5:41 PM > To: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org > Cc: Yoder Stuart-B08248; katz Itai-RM05202; Rivera Jose-B46482;

Re: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Dan Carpenter
A few style issues and error handling bugs. See below. On Sun, Oct 25, 2015 at 05:41:23PM -0500, Lijun Pan wrote: > +static int fsl_mc_restool_dev_open(struct inode *inode, struct file *filep) > +{ > + struct fsl_mc_device *root_mc_dev; > + int error = 0; > + struct fsl_mc_io

Re: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Dan Carpenter
A few style issues and error handling bugs. See below. On Sun, Oct 25, 2015 at 05:41:23PM -0500, Lijun Pan wrote: > +static int fsl_mc_restool_dev_open(struct inode *inode, struct file *filep) > +{ > + struct fsl_mc_device *root_mc_dev; > + int error = 0; > + struct fsl_mc_io

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Stuart Yoder
> -Original Message- > From: Lijun Pan [mailto:lijun@freescale.com] > Sent: Sunday, October 25, 2015 5:41 PM > To: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org > Cc: Yoder Stuart-B08248; katz Itai-RM05202; Rivera Jose-B46482;

Re: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Scott Wood
On Sun, 2015-10-25 at 17:41 -0500, Lijun Pan wrote: > The kernel support for the restool (a user space resource management > tool) is a driver for the /dev/dprc.N device file. > Its purpose is to provide an ioctl interface, > which the restool uses to interact with the MC bus driver > and with the

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Stuart Yoder
> -Original Message- > From: Lijun Pan [mailto:lijun@freescale.com] > Sent: Sunday, October 25, 2015 5:41 PM > To: gre...@linuxfoundation.org; a...@arndb.de; de...@driverdev.osuosl.org; > linux-kernel@vger.kernel.org > Cc: Yoder Stuart-B08248; katz Itai-RM05202; Rivera Jose-B46482;

RE: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Lijun Pan
gt; ag...@suse.de; Hamciuc Bogdan-BHAMCIU1 <bhamc...@freescale.com>; > Marginean Alexandru-R89243 <r89...@freescale.com>; Sharma Bhupesh- > B45370 <bhupesh.sha...@freescale.com>; Erez Nir-RM30794 > <nir.e...@freescale.com>; Schmitt Richard-B43082 > <richard.schm...@free