Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-11-12 Thread Schrempf Frieder
tersforpe...@gmail.com; >> frieder.schre...@exceet.de; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI >> controller >> >> Hi Yogesh, >> >> I didn't have time to look at all of the code, but nevert

Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-11-12 Thread Schrempf Frieder
tersforpe...@gmail.com; >> frieder.schre...@exceet.de; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI >> controller >> >> Hi Yogesh, >> >> I didn't have time to look at all of the code, but nevert

RE: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-11-12 Thread Yogesh Narayan Gaur
ail.com; > broo...@kernel.org; linux-...@vger.kernel.org; devicet...@vger.kernel.org > Cc: r...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; linux- > arm-ker...@lists.infradead.org; computersforpe...@gmail.com; > frieder.schre...@exceet.de; linux-kernel@vger.kernel.org > Subject:

RE: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-11-12 Thread Yogesh Narayan Gaur
ail.com; > broo...@kernel.org; linux-...@vger.kernel.org; devicet...@vger.kernel.org > Cc: r...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; linux- > arm-ker...@lists.infradead.org; computersforpe...@gmail.com; > frieder.schre...@exceet.de; linux-kernel@vger.kernel.org > Subject:

Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-11-07 Thread Schrempf Frieder
Hi Yogesh, I didn't have time to look at all of the code, but nevertheless here are some comments. On 23.10.18 10:56, Yogesh Narayan Gaur wrote: > - Add driver for NXP FlexSPI host controller > > (0) What is the FlexSPI controller? > FlexSPI is a flexsible SPI host controller which supports

Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-11-07 Thread Schrempf Frieder
Hi Yogesh, I didn't have time to look at all of the code, but nevertheless here are some comments. On 23.10.18 10:56, Yogesh Narayan Gaur wrote: > - Add driver for NXP FlexSPI host controller > > (0) What is the FlexSPI controller? > FlexSPI is a flexsible SPI host controller which supports

RE: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-23 Thread Yogesh Narayan Gaur
ernel.org; devicet...@vger.kernel.org; > r...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; linux-arm- > ker...@lists.infradead.org; computersforpe...@gmail.com; > frieder.schre...@exceet.de; linux-kernel@vger.kernel.org > Subject: Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSP

RE: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-23 Thread Yogesh Narayan Gaur
ernel.org; devicet...@vger.kernel.org; > r...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; linux-arm- > ker...@lists.infradead.org; computersforpe...@gmail.com; > frieder.schre...@exceet.de; linux-kernel@vger.kernel.org > Subject: Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSP

Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-23 Thread Boris Brezillon
On Tue, 23 Oct 2018 08:56:46 + Yogesh Narayan Gaur wrote: > +struct nxp_fspi { > + void __iomem *iobase; > + void __iomem *ahb_addr; > + u32 memmap_phy; > + u32 memmap_phy_size; > + struct clk *clk, *clk_en; > + struct device *dev; > + struct completion c; > +

Re: [PATCH RESEND v4 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2018-10-23 Thread Boris Brezillon
On Tue, 23 Oct 2018 08:56:46 + Yogesh Narayan Gaur wrote: > +struct nxp_fspi { > + void __iomem *iobase; > + void __iomem *ahb_addr; > + u32 memmap_phy; > + u32 memmap_phy_size; > + struct clk *clk, *clk_en; > + struct device *dev; > + struct completion c; > +