Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-09-02 Thread Charles Keepax
On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: > /sys/class/watchdog/watchdogn/device/modalias can help to identify the > driver/module for a given watchdog node. However, many wdt devices does not > set > its parent and so, we do not see an entry for device in sysfs for such >

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-09-02 Thread Charles Keepax
On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: > /sys/class/watchdog/watchdogn/device/modalias can help to identify the > driver/module for a given watchdog node. However, many wdt devices does not > set > its parent and so, we do not see an entry for device in sysfs for such >

RE: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-20 Thread Winkler, Tomas
> diff --git a/drivers/misc/mei/wd.c b/drivers/misc/mei/wd.c > index 2bc0f5089f82..b346638833b0 100644 > --- a/drivers/misc/mei/wd.c > +++ b/drivers/misc/mei/wd.c > @@ -364,6 +364,7 @@ int mei_watchdog_register(struct mei_device *dev) > > int ret; > > + amt_wd_dev.parent = dev->dev; >

RE: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-20 Thread Opensource [Adam Thomson]
On August 19, 2015 04:28, Pratyush Anand wrote: > diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c > index 2e9589652e1e..67e67977bd29 100644 > --- a/drivers/watchdog/da9052_wdt.c > +++ b/drivers/watchdog/da9052_wdt.c > @@ -195,6 +195,7 @@ static int

RE: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-20 Thread Winkler, Tomas
diff --git a/drivers/misc/mei/wd.c b/drivers/misc/mei/wd.c index 2bc0f5089f82..b346638833b0 100644 --- a/drivers/misc/mei/wd.c +++ b/drivers/misc/mei/wd.c @@ -364,6 +364,7 @@ int mei_watchdog_register(struct mei_device *dev) int ret; + amt_wd_dev.parent = dev-dev; /*

RE: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-20 Thread Opensource [Adam Thomson]
On August 19, 2015 04:28, Pratyush Anand wrote: diff --git a/drivers/watchdog/da9052_wdt.c b/drivers/watchdog/da9052_wdt.c index 2e9589652e1e..67e67977bd29 100644 --- a/drivers/watchdog/da9052_wdt.c +++ b/drivers/watchdog/da9052_wdt.c @@ -195,6 +195,7 @@ static int da9052_wdt_probe(struct

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Guenter Roeck
On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: > /sys/class/watchdog/watchdogn/device/modalias can help to identify the > driver/module for a given watchdog node. However, many wdt devices does not > set > its parent and so, we do not see an entry for device in sysfs for such >

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Maxime Coquelin
Hi Pratyush, On 08/19/2015 05:28 AM, Pratyush Anand wrote: diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c index 6785afdc0fca..14e9badf2bfa 100644 --- a/drivers/watchdog/st_lpc_wdt.c +++ b/drivers/watchdog/st_lpc_wdt.c @@ -241,6 +241,7 @@ static int

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Thierry Reding
On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: [...] > diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c > index 30451ea46902..7f97cdd53f29 100644 > --- a/drivers/watchdog/tegra_wdt.c > +++ b/drivers/watchdog/tegra_wdt.c > @@ -218,6 +218,7 @@ static int

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Uwe Kleine-König
Hello, On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: > /sys/class/watchdog/watchdogn/device/modalias can help to identify the > driver/module for a given watchdog node. However, many wdt devices does not > set s/es// > its parent and so, we do not see an entry for device in

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Guenter Roeck
On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: /sys/class/watchdog/watchdogn/device/modalias can help to identify the driver/module for a given watchdog node. However, many wdt devices does not set its parent and so, we do not see an entry for device in sysfs for such

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Maxime Coquelin
Hi Pratyush, On 08/19/2015 05:28 AM, Pratyush Anand wrote: diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c index 6785afdc0fca..14e9badf2bfa 100644 --- a/drivers/watchdog/st_lpc_wdt.c +++ b/drivers/watchdog/st_lpc_wdt.c @@ -241,6 +241,7 @@ static int

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Uwe Kleine-König
Hello, On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: /sys/class/watchdog/watchdogn/device/modalias can help to identify the driver/module for a given watchdog node. However, many wdt devices does not set s/es// its parent and so, we do not see an entry for device in sysfs

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Thierry Reding
On Wed, Aug 19, 2015 at 08:58:24AM +0530, Pratyush Anand wrote: [...] diff --git a/drivers/watchdog/tegra_wdt.c b/drivers/watchdog/tegra_wdt.c index 30451ea46902..7f97cdd53f29 100644 --- a/drivers/watchdog/tegra_wdt.c +++ b/drivers/watchdog/tegra_wdt.c @@ -218,6 +218,7 @@ static int