RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to > HNS3 driver > > On 07/27/2017 11:01 AM, Salil Mehta wrote: > > Hi Florian, > > > >> -Original Message- &g

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to > HNS3 driver > > On 07/27/2017 11:01 AM, Salil Mehta wrote: > > Hi Florian, > > > >> -Original Message- &g

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

angdaode; lipeng (Y); >> mehta.salil@gmail.com; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm >> Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to >> HNS3 driver >> >> >> >> On 07

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

angdaode; lipeng (Y); >> mehta.salil@gmail.com; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm >> Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to >> HNS3 driver >> >> >> >> On 07

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to > HNS3 driver > > > > On 07/22/2017 03:09 PM, Salil Mehta wrote: > > This patch adds the support of the Ethtool interface to &

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to > HNS3 driver > > > > On 07/22/2017 03:09 PM, Salil Mehta wrote: > > This patch adds the support of the Ethtool interface to &

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to > HNS3 driver > > On Sat, 22 Jul 2017 23:09:41 +0100 > Salil Mehta <salil.me...@huawei.com> wrote: > >

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

.org; linux- > ker...@vger.kernel.org; linux-r...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to > HNS3 driver > > On Sat, 22 Jul 2017 23:09:41 +0100 > Salil Mehta wrote: > > > + HNS3_NETDEV_STAT("rx_packets&q

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

From: Rustad, Mark D > Sent: 24 July 2017 21:32 > > On Jul 23, 2017, at 10:05 AM, Florian Fainelli wrote: > >> + > >> + strncpy(drvinfo->version, HNAE_DRIVER_VERSION, > >> + sizeof(drvinfo->version)); > >> + drvinfo->version[sizeof(drvinfo->version) - 1] = '\0'; >

RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

From: Rustad, Mark D > Sent: 24 July 2017 21:32 > > On Jul 23, 2017, at 10:05 AM, Florian Fainelli wrote: > >> + > >> + strncpy(drvinfo->version, HNAE_DRIVER_VERSION, > >> + sizeof(drvinfo->version)); > >> + drvinfo->version[sizeof(drvinfo->version) - 1] = '\0'; > > > > strlcpy() would

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

> On Jul 23, 2017, at 10:05 AM, Florian Fainelli wrote: >> + >> +strncpy(drvinfo->version, HNAE_DRIVER_VERSION, >> +sizeof(drvinfo->version)); >> +drvinfo->version[sizeof(drvinfo->version) - 1] = '\0'; > > strlcpy() would probably do that for you. You

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

> On Jul 23, 2017, at 10:05 AM, Florian Fainelli wrote: >> + >> +strncpy(drvinfo->version, HNAE_DRIVER_VERSION, >> +sizeof(drvinfo->version)); >> +drvinfo->version[sizeof(drvinfo->version) - 1] = '\0'; > > strlcpy() would probably do that for you. You need to be careful

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

On Sat, 22 Jul 2017 23:09:41 +0100 Salil Mehta wrote: > + HNS3_NETDEV_STAT("rx_packets", rx_packets), > + HNS3_NETDEV_STAT("tx_packets", tx_packets), > + HNS3_NETDEV_STAT("rx_bytes", rx_bytes), > + HNS3_NETDEV_STAT("tx_bytes", tx_bytes), > +

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

On Sat, 22 Jul 2017 23:09:41 +0100 Salil Mehta wrote: > + HNS3_NETDEV_STAT("rx_packets", rx_packets), > + HNS3_NETDEV_STAT("tx_packets", tx_packets), > + HNS3_NETDEV_STAT("rx_bytes", rx_bytes), > + HNS3_NETDEV_STAT("tx_bytes", tx_bytes), > + HNS3_NETDEV_STAT("rx_errors",

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

On 07/22/2017 03:09 PM, Salil Mehta wrote: > This patch adds the support of the Ethtool interface to > the HNS3 Ethernet driver. Various commands to read the > statistics, configure the offloading, loopback selftest etc. > are supported. > > Signed-off-by: Daode Huang

Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver

On 07/22/2017 03:09 PM, Salil Mehta wrote: > This patch adds the support of the Ethtool interface to > the HNS3 Ethernet driver. Various commands to read the > statistics, configure the offloading, loopback selftest etc. > are supported. > > Signed-off-by: Daode Huang > Signed-off-by: lipeng