RE: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

2013-04-19 Thread Haiyang Zhang
ect.org > Subject: Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send() > > From: Haiyang Zhang > Date: Tue, 16 Apr 2013 15:25:50 -0700 > > > Fixed: warning: cast from pointer to integer of different size > > > > The Hyper-V hosts always use 64 bit req

Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

2013-04-19 Thread David Miller
From: Haiyang Zhang Date: Tue, 16 Apr 2013 15:25:50 -0700 > Fixed: warning: cast from pointer to integer of different size > > The Hyper-V hosts always use 64 bit request id. The guests can have 32 or 64 > bit pointers which equal to the ulong type size. So we cast it to ulong type. > And, assig

RE: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

2013-04-16 Thread Haiyang Zhang
inuxdriverproject.org > Subject: Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send() > > On Tue, 2013-04-16 at 20:18 +, Haiyang Zhang wrote: > > > From: David Miller [mailto:da...@davemloft.net] It works fine, but > > > it's unclean. > > > Keep

Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

2013-04-16 Thread Joe Perches
On Tue, 2013-04-16 at 20:18 +, Haiyang Zhang wrote: > > From: David Miller [mailto:da...@davemloft.net] > > It works fine, but it's unclean. > > Keep the req_id type as "u64", because that's what it is, a 64-bit request > > ID. > I will make this update and submit a new patch, with the added

RE: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

2013-04-16 Thread Haiyang Zhang
project.org > Subject: Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send() > > From: Haiyang Zhang > Date: Tue, 16 Apr 2013 19:34:52 + > > > The Hyper-V hosts always use 64 bit request id. The guests can have > > 32 or 64 bit pointers which equal to the u

Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

2013-04-16 Thread David Miller
From: Haiyang Zhang Date: Tue, 16 Apr 2013 19:34:52 + > The Hyper-V hosts always use 64 bit request id. The guests can have > 32 or 64 bit pointers which equal to the ulong type size. So we cast > it to ulong type. And, assigning 32bit integer to 64 bit variable > works fine. It works fine,

RE: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

2013-04-16 Thread Haiyang Zhang
project.org > Subject: Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send() > > From: Haiyang Zhang > Date: Tue, 16 Apr 2013 12:03:51 -0700 > > > Fixed: warning: cast from pointer to integer of different size > > > > Reported-by: kbuild test robot &

Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()

2013-04-16 Thread David Miller
From: Haiyang Zhang Date: Tue, 16 Apr 2013 12:03:51 -0700 > Fixed: warning: cast from pointer to integer of different size > > Reported-by: kbuild test robot > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan If you're coding pointers into request IDs you better make that explici