RE: [PATCH net-next,1/1] hyperv: Move wait completion msg code into rndis_filter_halt_device()
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, August 03, 2012 7:52 PM > To: Haiyang Zhang > Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; > jasow...@redhat.com; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org > Subject: Re: [PATCH net-next,1/1] hyperv: Move wait completion msg code > into rndis_filter_halt_device() > > From: Haiyang Zhang > Date: Fri, 3 Aug 2012 12:32:18 -0700 > > > We need to wait for send_completion msg before put_rndis_request() at > > the end of rndis_filter_halt_device(). Otherwise, > > netvsc_send_completion() may reference freed memory which is > overwritten, and cause panic. > > > > Reported-by: Long Li > > Reported-by: Jason Wang > > Signed-off-by: Haiyang Zhang > > This is a bug fix, so applied to 'net'. Please target your patches properly. > > Don't just be afraid that I'll reject the patch if you target it at 'net', and > therefore just target everything at 'net-next'. That is certainly worse. I see. Thanks, - Haiyang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH net-next,1/1] hyperv: Move wait completion msg code into rndis_filter_halt_device()
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Friday, August 03, 2012 7:52 PM To: Haiyang Zhang Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-kernel@vger.kernel.org; de...@linuxdriverproject.org Subject: Re: [PATCH net-next,1/1] hyperv: Move wait completion msg code into rndis_filter_halt_device() From: Haiyang Zhang haiya...@microsoft.com Date: Fri, 3 Aug 2012 12:32:18 -0700 We need to wait for send_completion msg before put_rndis_request() at the end of rndis_filter_halt_device(). Otherwise, netvsc_send_completion() may reference freed memory which is overwritten, and cause panic. Reported-by: Long Li lon...@microsoft.com Reported-by: Jason Wang jasow...@redhat.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com This is a bug fix, so applied to 'net'. Please target your patches properly. Don't just be afraid that I'll reject the patch if you target it at 'net', and therefore just target everything at 'net-next'. That is certainly worse. I see. Thanks, - Haiyang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH net-next,1/1] hyperv: Move wait completion msg code into rndis_filter_halt_device()
From: Haiyang Zhang Date: Fri, 3 Aug 2012 12:32:18 -0700 > We need to wait for send_completion msg before put_rndis_request() at > the end of rndis_filter_halt_device(). Otherwise, netvsc_send_completion() > may reference freed memory which is overwritten, and cause panic. > > Reported-by: Long Li > Reported-by: Jason Wang > Signed-off-by: Haiyang Zhang This is a bug fix, so applied to 'net'. Please target your patches properly. Don't just be afraid that I'll reject the patch if you target it at 'net', and therefore just target everything at 'net-next'. That is certainly worse. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH net-next,1/1] hyperv: Move wait completion msg code into rndis_filter_halt_device()
From: Haiyang Zhang haiya...@microsoft.com Date: Fri, 3 Aug 2012 12:32:18 -0700 We need to wait for send_completion msg before put_rndis_request() at the end of rndis_filter_halt_device(). Otherwise, netvsc_send_completion() may reference freed memory which is overwritten, and cause panic. Reported-by: Long Li lon...@microsoft.com Reported-by: Jason Wang jasow...@redhat.com Signed-off-by: Haiyang Zhang haiya...@microsoft.com This is a bug fix, so applied to 'net'. Please target your patches properly. Don't just be afraid that I'll reject the patch if you target it at 'net', and therefore just target everything at 'net-next'. That is certainly worse. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
