Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-19 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Tue, 18 Mar 2014 15:15:22 -0700 +struct ndis_obj_header { + u8 type; + u8 rev; + u16 size; +} __packed; + + +/* ndis_recv_scale_cap/cap_flag */ One empty line is sufficient, we don't need two of them here. +extern u8

Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-19 Thread Sergei Shtylyov
Hello. On 03/19/2014 11:40 PM, David Miller wrote: +extern u8 netvsc_hash_key[]; We no longer use extern in header file function declarations. Wait, this is a variable declaration. :-) WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of

Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-19 Thread Stephen Rothwell
On Thu, 20 Mar 2014 00:56:05 +0300 Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: On 03/19/2014 11:40 PM, David Miller wrote: +extern u8 netvsc_hash_key[]; We no longer use extern in header file function declarations. Wait, this is a variable declaration. :-) And the

RE: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-19 Thread Haiyang Zhang
-Original Message- + + +/* ndis_recv_scale_cap/cap_flag */ One empty line is sufficient, we don't need two of them here. I will fix this and other formats you pointed out below, also check the whole patch for similar issues. - net = alloc_etherdev(sizeof(struct

Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-19 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Thu, 20 Mar 2014 00:56:05 +0300 Hello. On 03/19/2014 11:40 PM, David Miller wrote: +extern u8 netvsc_hash_key[]; We no longer use extern in header file function declarations. Wait, this is a variable declaration. :-)