RE: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

2014-11-12 Thread Haiyang Zhang
g; driverdev- > de...@linuxdriverproject.org > Subject: Re: [PATCH net-next] hyperv: Add processing of MTU reduced by > the host > > From: Haiyang Zhang > Date: Wed, 12 Nov 2014 20:02:11 + > > > The Hyper-V host doesn't support MTU below 1500. If we try setting MTU > to a > &

Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

2014-11-12 Thread David Miller
From: Haiyang Zhang Date: Wed, 12 Nov 2014 20:02:11 + > The Hyper-V host doesn't support MTU below 1500. If we try setting MTU to a > value < 1500, the host will use 1500 automatically and return 1500 in the > RNDIS_OID_GEN_MAXIMUM_FRAME_SIZE query and guest will also use it. That's > why

RE: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

2014-11-12 Thread Haiyang Zhang
g; driverdev- > de...@linuxdriverproject.org > Subject: Re: [PATCH net-next] hyperv: Add processing of MTU reduced by > the host > > From: Haiyang Zhang > Date: Tue, 11 Nov 2014 15:27:52 -0800 > > > - if (mtu < 68 || mtu > limit) > > + if (mtu < ETH_DATA_LEN || mtu >

Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

2014-11-12 Thread David Miller
From: Haiyang Zhang Date: Tue, 11 Nov 2014 15:27:52 -0800 > - if (mtu < 68 || mtu > limit) > + if (mtu < ETH_DATA_LEN || mtu > limit) > return -EINVAL; This is not correct. The test is against the minimally supported MTU, which should be 68 not ETH_DATA_LEN which is 1500.

Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

2014-11-12 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Tue, 11 Nov 2014 15:27:52 -0800 - if (mtu 68 || mtu limit) + if (mtu ETH_DATA_LEN || mtu limit) return -EINVAL; This is not correct. The test is against the minimally supported MTU, which should be 68 not ETH_DATA_LEN

RE: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

2014-11-12 Thread Haiyang Zhang
Subject: Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host From: Haiyang Zhang haiya...@microsoft.com Date: Tue, 11 Nov 2014 15:27:52 -0800 - if (mtu 68 || mtu limit) + if (mtu ETH_DATA_LEN || mtu limit) return -EINVAL; This is not correct

Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

2014-11-12 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Wed, 12 Nov 2014 20:02:11 + The Hyper-V host doesn't support MTU below 1500. If we try setting MTU to a value 1500, the host will use 1500 automatically and return 1500 in the RNDIS_OID_GEN_MAXIMUM_FRAME_SIZE query and guest will also use

RE: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

2014-11-12 Thread Haiyang Zhang
Subject: Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host From: Haiyang Zhang haiya...@microsoft.com Date: Wed, 12 Nov 2014 20:02:11 + The Hyper-V host doesn't support MTU below 1500. If we try setting MTU to a value 1500, the host will use 1500 automatically