RE: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-05 Thread Min Li
> > > > > > Any specific reason you are not using the misc_device api? That > > > would clean up this driver a lot, there's no need to create a whole > > > class just for a single driver. > > > > > > > Hi Greg > > > > No specific reason. I just didn't know the existence of misc_register API. > >

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 01:52:39AM +, Min Li wrote: > > > > Any specific reason you are not using the misc_device api? That would clean > > up this driver a lot, there's no need to create a whole class just for a > > single > > driver. > > > > Hi Greg > > No specific reason. I just

RE: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-04 Thread Min Li
> > Any specific reason you are not using the misc_device api? That would clean > up this driver a lot, there's no need to create a whole class just for a > single > driver. > Hi Greg No specific reason. I just didn't know the existence of misc_register API. Do you recommend using this API

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-04 Thread Greg KH
On Sat, Apr 03, 2021 at 06:08:34PM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide

RE: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-03 Thread Min Li
> > Then the patches are independant and they should be sent as such, > otherwise it causes confusion and our tools get messed up when trying to > grab the whole "series" of patches. > > Can you please fix this up and just send two independant patches? > Hi Greg These 2 patches are not

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-04-02 Thread Greg KH
On Mon, Mar 29, 2021 at 05:03:53PM +, Min Li wrote: > > > > Where is patch 1/2 of this series? > > > > Also, please fix up the errors that the testing bot found, and properly > > version > > your patch submission so I know which one is the "latest" one to look at. > > > > Hi Greg > > The

RE: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-29 Thread Min Li
> > Where is patch 1/2 of this series? > > Also, please fix up the errors that the testing bot found, and properly > version > your patch submission so I know which one is the "latest" one to look at. > Hi Greg The first patch is mfd so I was not sure if I should send that to you guys in

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-28 Thread Greg KH
On Fri, Mar 26, 2021 at 11:34:11AM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-27 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210326] url: https://github.com/0day-ci/linux/commits/min-li-xe-renesas-com/mfd-Add-Renesas-Synchronization-Management-Unit-SMU-support/20210327-150316 base:931294922e65a23e1aad6398b9ae02df74044679

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-27 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20210326] url: https://github.com/0day-ci/linux/commits/min-li-xe-renesas-com/mfd-Add-Renesas-Synchronization-Management-Unit-SMU-support/20210327-150316 base:931294922e65a23e1aad6398b9ae02df74044679