Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-04 Thread Lothar Waßmann
Hi, On Wed, 4 Jul 2018 01:42:54 + Robin Gong wrote: > On 二, 2018-07-03 at 08:10 -0300, Fabio Estevam wrote: > > Hi Anson, > > > > On Tue, Jul 3, 2018 at 4:44 AM, Anson Huang > > wrote: > > > > > > > > It is NOT easy to identify which switch is critical or NOT, and > > > different

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-04 Thread Lothar Waßmann
Hi, On Wed, 4 Jul 2018 01:42:54 + Robin Gong wrote: > On 二, 2018-07-03 at 08:10 -0300, Fabio Estevam wrote: > > Hi Anson, > > > > On Tue, Jul 3, 2018 at 4:44 AM, Anson Huang > > wrote: > > > > > > > > It is NOT easy to identify which switch is critical or NOT, and > > > different

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-03 Thread Robin Gong
On 二, 2018-07-03 at 08:10 -0300, Fabio Estevam wrote: > Hi Anson, > > On Tue, Jul 3, 2018 at 4:44 AM, Anson Huang > wrote: > > > > > It is NOT easy to identify which switch is critical or NOT, and > > different platforms > > have different board design, it will introduce many platform > >

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-03 Thread Robin Gong
On 二, 2018-07-03 at 08:10 -0300, Fabio Estevam wrote: > Hi Anson, > > On Tue, Jul 3, 2018 at 4:44 AM, Anson Huang > wrote: > > > > > It is NOT easy to identify which switch is critical or NOT, and > > different platforms > > have different board design, it will introduce many platform > >

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-03 Thread Fabio Estevam
Hi Anson, On Tue, Jul 3, 2018 at 4:44 AM, Anson Huang wrote: > It is NOT easy to identify which switch is critical or NOT, and different > platforms > have different board design, it will introduce many platform specified code, > so I think > just revert the pfuze100 switch enable/disable

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-03 Thread Fabio Estevam
Hi Anson, On Tue, Jul 3, 2018 at 4:44 AM, Anson Huang wrote: > It is NOT easy to identify which switch is critical or NOT, and different > platforms > have different board design, it will introduce many platform specified code, > so I think > just revert the pfuze100 switch enable/disable

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-03 Thread Anson Huang
ernel@vger.kernel.org; robh...@kernel.org; dl-linux-imx > ; ker...@pengutronix.de; Fabio Estevam > ; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > On Mon, Jul 02, 2018 at 02:12:52AM +, Robin Gong wrote: > > But in fac

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-03 Thread Anson Huang
ernel@vger.kernel.org; robh...@kernel.org; dl-linux-imx > ; ker...@pengutronix.de; Fabio Estevam > ; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > On Mon, Jul 02, 2018 at 02:12:52AM +, Robin Gong wrote: > > But in fac

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-02 Thread Shawn Guo
On Mon, Jul 02, 2018 at 02:12:52AM +, Robin Gong wrote: > But in fact, the original dts is not correct without 'regulator-always- > on'since SW4 is the critical DDR power rail, although, it's kept on in > the previous kernel by no switches enable/disable interfaces provided > in pfuze driver.

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-02 Thread Shawn Guo
On Mon, Jul 02, 2018 at 02:12:52AM +, Robin Gong wrote: > But in fact, the original dts is not correct without 'regulator-always- > on'since SW4 is the critical DDR power rail, although, it's kept on in > the previous kernel by no switches enable/disable interfaces provided > in pfuze driver.

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-02 Thread Fabio Estevam
Hi Robin, On Sun, Jul 1, 2018 at 11:12 PM, Robin Gong wrote: > But in fact, the original dts is not correct without 'regulator-always- > on'since SW4 is the critical DDR power rail, although, it's kept on in > the previous kernel by no switches enable/disable interfaces provided > in pfuze

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-02 Thread Fabio Estevam
Hi Robin, On Sun, Jul 1, 2018 at 11:12 PM, Robin Gong wrote: > But in fact, the original dts is not correct without 'regulator-always- > on'since SW4 is the critical DDR power rail, although, it's kept on in > the previous kernel by no switches enable/disable interfaces provided > in pfuze

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Robin Gong
On 日, 2018-07-01 at 22:17 -0300, Fabio Estevam wrote: > On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang > wrote: > > > > > On some new i.MX platforms, PFuze switches are used for supplying > > GPU/VPU > > or other non-critical modules only, these switches need to be > > turned off by > > runtime

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Robin Gong
On 日, 2018-07-01 at 22:17 -0300, Fabio Estevam wrote: > On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang > wrote: > > > > > On some new i.MX platforms, PFuze switches are used for supplying > > GPU/VPU > > or other non-critical modules only, these switches need to be > > turned off by > > runtime

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
> linux-kernel ; Rob Herring > ; dl-linux-imx ; Sascha Hauer > ; Fabio Estevam ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang > wrote: &

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
> linux-kernel ; Rob Herring > ; dl-linux-imx ; Sascha Hauer > ; Fabio Estevam ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang > wrote: &

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang wrote: > On some new i.MX platforms, PFuze switches are used for supplying GPU/VPU > or other non-critical modules only, these switches need to be turned off by > runtime PM to avoid very high power leakage, like on mScale850D. Ok, in this case I

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
On Sun, Jul 1, 2018 at 10:09 PM, Anson Huang wrote: > On some new i.MX platforms, PFuze switches are used for supplying GPU/VPU > or other non-critical modules only, these switches need to be turned off by > runtime PM to avoid very high power leakage, like on mScale850D. Ok, in this case I

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
> linux-kernel ; Rob Herring > ; dl-linux-imx ; Sascha Hauer > ; Fabio Estevam ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > On Sun, Jul 1, 2018 at 10:03 PM, Anson Huang > wrot

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
> linux-kernel ; Rob Herring > ; dl-linux-imx ; Sascha Hauer > ; Fabio Estevam ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > On Sun, Jul 1, 2018 at 10:03 PM, Anson Huang > wrot

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
On Sun, Jul 1, 2018 at 10:03 PM, Anson Huang wrote: > So that mean such kind of kernel patch will never be into kernel? Even if it > is a > necessary patch for fixing some other issues? I just wonder how this case > being > handled. What is the issue that 5fe156f1cab4f fixes? It is not clear

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
On Sun, Jul 1, 2018 at 10:03 PM, Anson Huang wrote: > So that mean such kind of kernel patch will never be into kernel? Even if it > is a > necessary patch for fixing some other issues? I just wonder how this case > being > handled. What is the issue that 5fe156f1cab4f fixes? It is not clear

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
> linux-kernel ; Rob Herring > ; dl-linux-imx ; Sascha Hauer > ; Fabio Estevam ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > Hi Anson, > > On Sun, Jul 1, 2018 at 9:57 PM, Anson H

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
> linux-kernel ; Rob Herring > ; dl-linux-imx ; Sascha Hauer > ; Fabio Estevam ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > Hi Anson, > > On Sun, Jul 1, 2018 at 9:57 PM, Anson H

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
Hi Anson, On Sun, Jul 1, 2018 at 9:57 PM, Anson Huang wrote: > Just want to know how to handle such case? The kernel patch will never > be applied or is there any way to make kernel patch and dtb patch applied > together to avoid any breakage? We always want to avoid breaking a working dtb

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
Hi Anson, On Sun, Jul 1, 2018 at 9:57 PM, Anson Huang wrote: > Just want to know how to handle such case? The kernel patch will never > be applied or is there any way to make kernel patch and dtb patch applied > together to avoid any breakage? We always want to avoid breaking a working dtb

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
EE BINDINGS ; > linux-kernel ; Rob Herring > ; dl-linux-imx ; Sascha Hauer > ; Fabio Estevam ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > Hi Anson, > > On Sun, Jul 1, 2018 at 9:53

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
EE BINDINGS ; > linux-kernel ; Rob Herring > ; dl-linux-imx ; Sascha Hauer > ; Fabio Estevam ; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > Hi Anson, > > On Sun, Jul 1, 2018 at 9:53

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
Hi Anson, On Sun, Jul 1, 2018 at 9:53 PM, Anson Huang wrote: > Yes, I think we can revert it to avoid breakage. Didn't notice that some > i.MX platform do NOT have those critical switches always-on. Ok, thanks for confirming. I will send a revert patch then. Thanks

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
Hi Anson, On Sun, Jul 1, 2018 at 9:53 PM, Anson Huang wrote: > Yes, I think we can revert it to avoid breakage. Didn't notice that some > i.MX platform do NOT have those critical switches always-on. Ok, thanks for confirming. I will send a revert patch then. Thanks

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
S ; linux-kernel > ; Rob Herring ; > dl-linux-imx ; Sascha Hauer ; > Fabio Estevam ; moderated list:ARM/FREESCALE > IMX / MXC ARM ARCHITECTURE > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo wrote: > > O

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Anson Huang
S ; linux-kernel > ; Rob Herring ; > dl-linux-imx ; Sascha Hauer ; > Fabio Estevam ; moderated list:ARM/FREESCALE > IMX / MXC ARM ARCHITECTURE > Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on > > On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo wrote: > > O

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo wrote: > On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote: >> SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should >> be kept always on. But it's disabled after switch disabled >> interface implemented in pfuze driver >> 'commit

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Fabio Estevam
On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo wrote: > On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote: >> SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should >> be kept always on. But it's disabled after switch disabled >> interface implemented in pfuze driver >> 'commit

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Shawn Guo
On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote: > SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should > be kept always on. But it's disabled after switch disabled > interface implemented in pfuze driver > 'commit 5fe156f1cab4 > ("regulator: pfuze100: add enable/disable for

Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-07-01 Thread Shawn Guo
On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote: > SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should > be kept always on. But it's disabled after switch disabled > interface implemented in pfuze driver > 'commit 5fe156f1cab4 > ("regulator: pfuze100: add enable/disable for

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-06-24 Thread Anson Huang
Acked-by: Anson Huang I also saw such issue on i.MX6SLL evk board, and also sent out patch for i.MX6SLL. Anson Huang Best Regards! > -Original Message- > From: Robin Gong > Sent: Monday, June 25, 2018 8:34 PM > To: shawn...@kernel.org; ker...@pengutronix.de; Fabio Estevam > ;

RE: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on

2018-06-24 Thread Anson Huang
Acked-by: Anson Huang I also saw such issue on i.MX6SLL evk board, and also sent out patch for i.MX6SLL. Anson Huang Best Regards! > -Original Message- > From: Robin Gong > Sent: Monday, June 25, 2018 8:34 PM > To: shawn...@kernel.org; ker...@pengutronix.de; Fabio Estevam > ;