Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-20 Thread Murali Karicheri
On 10/20/2015 04:24 AM, Arnd Bergmann wrote: On Monday 19 October 2015 14:50:57 Murali Karicheri wrote: Arnd, by your statement 'I don't see any code that does this' do you expect a piece of code that embed the license in the binary image? If so, that seems weired to me. Many of the drivers

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-20 Thread Arnd Bergmann
On Monday 19 October 2015 14:50:57 Murali Karicheri wrote: > Arnd, by your statement 'I don't see any code that does this' do you > expect a piece of code that embed the license in the binary image? If > so, that seems weired to me. > > Many of the drivers including this patch has the following

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-20 Thread Arnd Bergmann
On Monday 19 October 2015 14:50:57 Murali Karicheri wrote: > Arnd, by your statement 'I don't see any code that does this' do you > expect a piece of code that embed the license in the binary image? If > so, that seems weired to me. > > Many of the drivers including this patch has the following

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-20 Thread Murali Karicheri
On 10/20/2015 04:24 AM, Arnd Bergmann wrote: On Monday 19 October 2015 14:50:57 Murali Karicheri wrote: Arnd, by your statement 'I don't see any code that does this' do you expect a piece of code that embed the license in the binary image? If so, that seems weired to me. Many of the drivers

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-19 Thread Murali Karicheri
...@arm.com; ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; KISHON VIJAY ABRAHAM; Quadros, Roger; bhelg...@google.com; ssant...@kernel.org; li...@arm.linux.org.uk; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- p...@vger.kernel.org Subject: Re: [PATCH v1 1/2] phy: keystone

RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-19 Thread Kwok, WingMan
m.com; ijc+devicet...@hellion.org.uk; > ga...@codeaurora.org; KISHON VIJAY ABRAHAM; Quadros, Roger; > bhelg...@google.com; ssant...@kernel.org; li...@arm.linux.org.uk; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > p...@vger.kernel.org > Subject: Re: [PATCH v1 1/2] phy: keys

RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-19 Thread Kwok, WingMan
m.com; ijc+devicet...@hellion.org.uk; > ga...@codeaurora.org; KISHON VIJAY ABRAHAM; Quadros, Roger; > bhelg...@google.com; ssant...@kernel.org; li...@arm.linux.org.uk; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > p...@vger.kernel.org > Subject: Re: [PATCH v1 1/2] phy: keys

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-19 Thread Murali Karicheri
...@arm.com; ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; KISHON VIJAY ABRAHAM; Quadros, Roger; bhelg...@google.com; ssant...@kernel.org; li...@arm.linux.org.uk; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- p...@vger.kernel.org Subject: Re: [PATCH v1 1/2] phy: keystone

RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Kwok, WingMan
llion.org.uk; > ga...@codeaurora.org; KISHON VIJAY ABRAHAM; Quadros, Roger; Karicheri, > Muralidharan; bhelg...@google.com; ssant...@kernel.org; > li...@arm.linux.org.uk; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org > Subject: Re: [PATCH v1 1/2] phy

RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Kwok, WingMan
n Helgaas; Santosh Shilimkar; > Russell King - ARM Linux; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and > pcie > > On Thu

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 20:08:32 Kwok, WingMan wrote: > > > > +#define reg_rmw(addr, value, mask) \ > > > + __raw_writel(((__raw_readl(addr) & (~(mask))) | \ > > > + (value & (mask))), (addr)) > > > > not endian safe, and potentially racy. > > > > will change to > >

RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Kwok, WingMan
hellion.org.uk; ga...@codeaurora.org; > KISHON VIJAY ABRAHAM; Quadros, Roger; Karicheri, Muralidharan; > bhelg...@google.com; ssant...@kernel.org; li...@arm.linux.org.uk; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > p...@vger.kernel.org > Subject: Re: [PATCH v1 1/2] phy

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 12:01:04 Murali Karicheri wrote: > > >> + * Redistributions in binary form must reproduce the above copyright > >> + * notice, this list of conditions and the following disclaimer in the > >> + * documentation and/or other materials provided with the > >> + *

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Rob Herring
On Thu, Oct 15, 2015 at 9:25 AM, WingMan Kwok wrote: > On TI's Keystone platforms, several peripherals such as the > gbe ethernet switch, 10gbe ethernet switch and PCIe controller > require the use of a SerDes for converting SoC parallel data into > serialized data that can be output over a

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Murali Karicheri
On 10/15/2015 10:51 AM, Arnd Bergmann wrote: On Thursday 15 October 2015 10:25:44 WingMan Kwok wrote: On TI's Keystone platforms, several peripherals such as the gbe ethernet switch, 10gbe ethernet switch and PCIe controller require the use of a SerDes for converting SoC parallel data into

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 10:25:44 WingMan Kwok wrote: > On TI's Keystone platforms, several peripherals such as the > gbe ethernet switch, 10gbe ethernet switch and PCIe controller > require the use of a SerDes for converting SoC parallel data into > serialized data that can be output over a

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Rob Herring
On Thu, Oct 15, 2015 at 9:25 AM, WingMan Kwok wrote: > On TI's Keystone platforms, several peripherals such as the > gbe ethernet switch, 10gbe ethernet switch and PCIe controller > require the use of a SerDes for converting SoC parallel data into > serialized data that can be

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Murali Karicheri
On 10/15/2015 10:51 AM, Arnd Bergmann wrote: On Thursday 15 October 2015 10:25:44 WingMan Kwok wrote: On TI's Keystone platforms, several peripherals such as the gbe ethernet switch, 10gbe ethernet switch and PCIe controller require the use of a SerDes for converting SoC parallel data into

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 10:25:44 WingMan Kwok wrote: > On TI's Keystone platforms, several peripherals such as the > gbe ethernet switch, 10gbe ethernet switch and PCIe controller > require the use of a SerDes for converting SoC parallel data into > serialized data that can be output over a

RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Kwok, WingMan
n Helgaas; Santosh Shilimkar; > Russell King - ARM Linux; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and > pcie > > On Thu

RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Kwok, WingMan
llion.org.uk; > ga...@codeaurora.org; KISHON VIJAY ABRAHAM; Quadros, Roger; Karicheri, > Muralidharan; bhelg...@google.com; ssant...@kernel.org; > li...@arm.linux.org.uk; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org > Subject: Re: [PATCH v1 1/2] phy

RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Kwok, WingMan
hellion.org.uk; ga...@codeaurora.org; > KISHON VIJAY ABRAHAM; Quadros, Roger; Karicheri, Muralidharan; > bhelg...@google.com; ssant...@kernel.org; li...@arm.linux.org.uk; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > p...@vger.kernel.org > Subject: Re: [PATCH v1 1/2] phy

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 20:08:32 Kwok, WingMan wrote: > > > > +#define reg_rmw(addr, value, mask) \ > > > + __raw_writel(((__raw_readl(addr) & (~(mask))) | \ > > > + (value & (mask))), (addr)) > > > > not endian safe, and potentially racy. > > > > will change to > >

Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 12:01:04 Murali Karicheri wrote: > > >> + * Redistributions in binary form must reproduce the above copyright > >> + * notice, this list of conditions and the following disclaimer in the > >> + * documentation and/or other materials provided with the > >> + *