RE: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-07-09 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > > + > > + chan->is_dmacoherent = of_property_read_bool(node, "dma- > coherent"); > > + zdev->chan = chan; > > + tasklet_init(>tasklet, zynqmp_dma_do_tasklet, (ulong)chan); > > where is this killed? This is killed in the

RE: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-07-09 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > > + > > + chan->is_dmacoherent = of_property_read_bool(node, "dma- > coherent"); > > + zdev->chan = chan; > > + tasklet_init(>tasklet, zynqmp_dma_do_tasklet, (ulong)chan); > > where is this killed? This is killed in the

Re: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-07-07 Thread Vinod Koul
On Fri, Jul 01, 2016 at 05:07:06PM +0530, Kedareswara rao Appana wrote: > +static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, > +struct platform_device *pdev) > +{ > + struct zynqmp_dma_chan *chan; > + struct resource *res; > + struct device_node

Re: [PATCH v12 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-07-07 Thread Vinod Koul
On Fri, Jul 01, 2016 at 05:07:06PM +0530, Kedareswara rao Appana wrote: > +static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, > +struct platform_device *pdev) > +{ > + struct zynqmp_dma_chan *chan; > + struct resource *res; > + struct device_node