Re: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation
On Wed, Sep 25, 2019 at 10:23:28PM +, Haiyang Zhang wrote: -Original Message- From: Dexuan Cui Sent: Wednesday, September 25, 2019 6:04 PM To: KY Srinivasan ; Haiyang Zhang ; Stephen Hemminger ; sas...@kernel.org; da...@davemloft.net; linux-hyp...@vger.kernel.org; net...@vger.kernel.org; linux- ker...@vger.kernel.org; Michael Kelley Cc: Dexuan Cui Subject: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation The existing netvsc_detach() and netvsc_attach() APIs make it easy to implement the suspend/resume callbacks. Signed-off-by: Dexuan Cui Reviewed-by: Haiyang Zhang Queued up for hyperv-next, thanks! -- Thanks, Sasha
RE: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of kbuild test robot
> Sent: Thursday, September 26, 2019 9:18 PM
>
> Hi Dexuan,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on net/master]
>
> 'netvsc_drv.shutdown')
> >> drivers/net/hyperv/netvsc_drv.c:2487:3: error: 'struct hv_driver' has no
> member named 'resume'; did you mean 'remove'?
> .resume = netvsc_resume,
> ^~
This is a false alarm. Your code base needs to be merged with the latest
Linus's tree, which has the prerequisite patch:
271b2224d42f ("Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for
hibernation")
Thanks,
-- Dexuan
Re: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation
Hi Dexuan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
url:
https://github.com/0day-ci/linux/commits/Dexuan-Cui/hv_netvsc-Add-the-support-of-hibernation/20190926-061258
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All error/warnings (new ones prefixed by >>):
>> drivers/net/hyperv/netvsc_drv.c:2486:3: error: 'struct hv_driver' has no
>> member named 'suspend'
.suspend = netvsc_suspend,
^~~
>> drivers/net/hyperv/netvsc_drv.c:2486:13: error: initialization from
>> incompatible pointer type [-Werror=incompatible-pointer-types]
.suspend = netvsc_suspend,
^~
drivers/net/hyperv/netvsc_drv.c:2486:13: note: (near initialization for
'netvsc_drv.shutdown')
>> drivers/net/hyperv/netvsc_drv.c:2487:3: error: 'struct hv_driver' has no
>> member named 'resume'; did you mean 'remove'?
.resume = netvsc_resume,
^~
remove
>> drivers/net/hyperv/netvsc_drv.c:2487:12: warning: excess elements in struct
>> initializer
.resume = netvsc_resume,
^
drivers/net/hyperv/netvsc_drv.c:2487:12: note: (near initialization for
'netvsc_drv')
cc1: some warnings being treated as errors
vim +2486 drivers/net/hyperv/netvsc_drv.c
2479
2480 /* The one and only one */
2481 static struct hv_driver netvsc_drv = {
2482 .name = KBUILD_MODNAME,
2483 .id_table = id_table,
2484 .probe = netvsc_probe,
2485 .remove = netvsc_remove,
> 2486 .suspend = netvsc_suspend,
> 2487 .resume = netvsc_resume,
2488 .driver = {
2489 .probe_type = PROBE_FORCE_SYNCHRONOUS,
2490 },
2491 };
2492
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
RE: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation
> -Original Message- > From: Dexuan Cui > Sent: Wednesday, September 25, 2019 6:04 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; da...@davemloft.net; > linux-hyp...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Michael Kelley > Cc: Dexuan Cui > Subject: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation > > The existing netvsc_detach() and netvsc_attach() APIs make it easy to > implement the suspend/resume callbacks. > > Signed-off-by: Dexuan Cui Reviewed-by: Haiyang Zhang
