RE: [PATCH v2] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-03-04 Thread Haiyang Zhang


> -Original Message-
> From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev-
> ow...@vger.kernel.org] On Behalf Of Greg KH
> Sent: Monday, March 04, 2013 8:16 PM
> To: Haiyang Zhang
> Cc: florianschandi...@gmx.de; linux-fb...@vger.kernel.org;
> o...@aepfle.de; jasow...@redhat.com; linux-kernel@vger.kernel.org;
> de...@linuxdriverproject.org
> Subject: Re: [PATCH v2] video: Add Hyper-V Synthetic Video Frame Buffer
> Driver
> 
> On Mon, Mar 04, 2013 at 01:56:12PM -0800, Haiyang Zhang wrote:
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2951,3 +2951,6 @@
> >  #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001
> >
> >  #define PCI_VENDOR_ID_OCZ  0x1b85
> > +
> > +#define PCI_VENDOR_ID_MICROSOFT0x1414
> > +#define PCI_DEVICE_ID_HYPERV_VIDEO 0x5353
> 
> Please see the top of this while for why you shouldn't be adding any lines to
> this file.

I will move the defines back to the hyperv_fb.c.
Thanks for pointing this out.

- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v2] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-03-04 Thread Greg KH
On Mon, Mar 04, 2013 at 01:56:12PM -0800, Haiyang Zhang wrote:
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2951,3 +2951,6 @@
>  #define PCI_DEVICE_ID_XEN_PLATFORM   0x0001
>  
>  #define PCI_VENDOR_ID_OCZ0x1b85
> +
> +#define PCI_VENDOR_ID_MICROSOFT  0x1414
> +#define PCI_DEVICE_ID_HYPERV_VIDEO   0x5353

Please see the top of this while for why you shouldn't be adding any
lines to this file.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v2] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-03-04 Thread Greg KH
On Mon, Mar 04, 2013 at 01:56:12PM -0800, Haiyang Zhang wrote:
 --- a/include/linux/pci_ids.h
 +++ b/include/linux/pci_ids.h
 @@ -2951,3 +2951,6 @@
  #define PCI_DEVICE_ID_XEN_PLATFORM   0x0001
  
  #define PCI_VENDOR_ID_OCZ0x1b85
 +
 +#define PCI_VENDOR_ID_MICROSOFT  0x1414
 +#define PCI_DEVICE_ID_HYPERV_VIDEO   0x5353

Please see the top of this while for why you shouldn't be adding any
lines to this file.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH v2] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-03-04 Thread Haiyang Zhang


 -Original Message-
 From: linux-fbdev-ow...@vger.kernel.org [mailto:linux-fbdev-
 ow...@vger.kernel.org] On Behalf Of Greg KH
 Sent: Monday, March 04, 2013 8:16 PM
 To: Haiyang Zhang
 Cc: florianschandi...@gmx.de; linux-fb...@vger.kernel.org;
 o...@aepfle.de; jasow...@redhat.com; linux-kernel@vger.kernel.org;
 de...@linuxdriverproject.org
 Subject: Re: [PATCH v2] video: Add Hyper-V Synthetic Video Frame Buffer
 Driver
 
 On Mon, Mar 04, 2013 at 01:56:12PM -0800, Haiyang Zhang wrote:
  --- a/include/linux/pci_ids.h
  +++ b/include/linux/pci_ids.h
  @@ -2951,3 +2951,6 @@
   #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001
 
   #define PCI_VENDOR_ID_OCZ  0x1b85
  +
  +#define PCI_VENDOR_ID_MICROSOFT0x1414
  +#define PCI_DEVICE_ID_HYPERV_VIDEO 0x5353
 
 Please see the top of this while for why you shouldn't be adding any lines to
 this file.

I will move the defines back to the hyperv_fb.c.
Thanks for pointing this out.

- Haiyang

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/