RE: [PATCH v2 08/17] libnvdimm: introduce nvdimm_flush() and nvdimm_has_flush()

2016-07-10 Thread Li, Philip


> -Original Message-
> From: Williams, Dan J
> Sent: Sunday, July 10, 2016 1:01 PM
> To: lkp 
> Cc: kbuild-...@01.org; linux-nvd...@lists.01.org; linux-fsdevel  fsde...@vger.kernel.org>; Linux ACPI ; Ross
> Zwisler ; Christoph Hellwig ; 
> linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH v2 08/17] libnvdimm: introduce nvdimm_flush() and
> nvdimm_has_flush()
> 
> On Sat, Jul 9, 2016 at 9:47 PM, kbuild test robot  wrote:
> > Hi,
> >
> > [auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
> > [also build test ERROR on next-20160708]
> > [cannot apply to v4.7-rc6]
> > [if your patch is applied to the wrong git tree, please drop us a note to 
> > help
> improve the system]
> >
> > url:https://github.com/0day-ci/linux/commits/Dan-Williams/replace-
> pcommit-with-ADR-or-directed-flushing/20160710-113558
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
> libnvdimm-for-next
> > config: i386-randconfig-r0-201628 (attached as .config)
> > compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> > reproduce:
> > # save the attached .config to linux build tree
> > make ARCH=i386
> 
> Hi kbuild team,
> 
> Can we add an "i386 allmodconfig" build to the standard "BUILD
> SUCCESS" notification runs?  I had two positive build results on a

Thanks, yes, currently i386 allmodconfig has been covered for all kinds of test 
including
kbiuld on registered repo or LKML patches. If the test is running on a repo for 
its new commits,
a BUILD SUCCESS mail, it will list the current coverage by the time the mail is 
sent out like

m32r   m32104ut_defconfig
m32r mappi3.smp_defconfig
m32r opsput_defconfig
m32r   usrv_defconfig
xtensa   common_defconfig
xtensa  iss_defconfig
i386 allmodconfig
mips   jz4740
mips  allnoconfig

> private branch prior to posting this series, but the i386 runs did not
> build the nvdimm sub-system.
> 
> In any event this report is valid, so thank you for that!
> 
> 
> >
> > All errors (new ones prefixed by >>):
> >
> >drivers/nvdimm/region_devs.c: In function 'nvdimm_flush':
> >>> drivers/nvdimm/region_devs.c:887:4: error: implicit declaration of 
> >>> function
> 'writeq' [-Werror=implicit-function-declaration]
> >writeq(1, ndrd->flush_wpq[i][0]);
> >^~
> >cc1: some warnings being treated as errors
> >
> > vim +/writeq +887 drivers/nvdimm/region_devs.c
> >
> >881   * writes to avoid the cache via arch_memcpy_to_pmem().  The
> >882   * final wmb() ensures ordering for the NVDIMM flush write.
> >883   */
> >884  wmb();
> >885  for (i = 0; i < nd_region->ndr_mappings; i++)
> >886  if (ndrd->flush_wpq[i][0])
> >  > 887  writeq(1, ndrd->flush_wpq[i][0]);
> >888  wmb();
> >889  }
> >890  EXPORT_SYMBOL_GPL(nvdimm_flush);
> >
> > ---
> > 0-DAY kernel test infrastructureOpen Source Technology 
> > Center
> > https://lists.01.org/pipermail/kbuild-all   Intel 
> > Corporation



Re: [PATCH v2 08/17] libnvdimm: introduce nvdimm_flush() and nvdimm_has_flush()

2016-07-09 Thread Dan Williams
On Sat, Jul 9, 2016 at 9:47 PM, kbuild test robot  wrote:
> Hi,
>
> [auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
> [also build test ERROR on next-20160708]
> [cannot apply to v4.7-rc6]
> [if your patch is applied to the wrong git tree, please drop us a note to 
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Dan-Williams/replace-pcommit-with-ADR-or-directed-flushing/20160710-113558
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git 
> libnvdimm-for-next
> config: i386-randconfig-r0-201628 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386

Hi kbuild team,

Can we add an "i386 allmodconfig" build to the standard "BUILD
SUCCESS" notification runs?  I had two positive build results on a
private branch prior to posting this series, but the i386 runs did not
build the nvdimm sub-system.

In any event this report is valid, so thank you for that!


>
> All errors (new ones prefixed by >>):
>
>drivers/nvdimm/region_devs.c: In function 'nvdimm_flush':
>>> drivers/nvdimm/region_devs.c:887:4: error: implicit declaration of function 
>>> 'writeq' [-Werror=implicit-function-declaration]
>writeq(1, ndrd->flush_wpq[i][0]);
>^~
>cc1: some warnings being treated as errors
>
> vim +/writeq +887 drivers/nvdimm/region_devs.c
>
>881   * writes to avoid the cache via arch_memcpy_to_pmem().  The
>882   * final wmb() ensures ordering for the NVDIMM flush write.
>883   */
>884  wmb();
>885  for (i = 0; i < nd_region->ndr_mappings; i++)
>886  if (ndrd->flush_wpq[i][0])
>  > 887  writeq(1, ndrd->flush_wpq[i][0]);
>888  wmb();
>889  }
>890  EXPORT_SYMBOL_GPL(nvdimm_flush);
>
> ---
> 0-DAY kernel test infrastructureOpen Source Technology Center
> https://lists.01.org/pipermail/kbuild-all   Intel Corporation


Re: [PATCH v2 08/17] libnvdimm: introduce nvdimm_flush() and nvdimm_has_flush()

2016-07-09 Thread kbuild test robot
Hi,

[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on next-20160708]
[cannot apply to v4.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Dan-Williams/replace-pcommit-with-ADR-or-directed-flushing/20160710-113558
base:   https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git 
libnvdimm-for-next
config: i386-randconfig-r0-201628 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/nvdimm/region_devs.c: In function 'nvdimm_flush':
>> drivers/nvdimm/region_devs.c:887:4: error: implicit declaration of function 
>> 'writeq' [-Werror=implicit-function-declaration]
   writeq(1, ndrd->flush_wpq[i][0]);
   ^~
   cc1: some warnings being treated as errors

vim +/writeq +887 drivers/nvdimm/region_devs.c

   881   * writes to avoid the cache via arch_memcpy_to_pmem().  The
   882   * final wmb() ensures ordering for the NVDIMM flush write.
   883   */
   884  wmb();
   885  for (i = 0; i < nd_region->ndr_mappings; i++)
   886  if (ndrd->flush_wpq[i][0])
 > 887  writeq(1, ndrd->flush_wpq[i][0]);
   888  wmb();
   889  }
   890  EXPORT_SYMBOL_GPL(nvdimm_flush);

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: Binary data