RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-16 Thread Zheng, Lv
Hi, Yu > From: Zheng, Lv > Sent: Wednesday, November 11, 2015 1:07 PM > > Hi, Yu > > > From: Chen, Yu C > > Sent: Tuesday, November 10, 2015 5:43 PM > > > > Hi, Lv > > Sorry for my late feedback on the patch, one minor nit below: > > > > > From: Zheng, Lv > > > Sent: Tuesday, November 10, 2015

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-16 Thread Zheng, Lv
Hi, Yu > From: Zheng, Lv > Sent: Wednesday, November 11, 2015 1:07 PM > > Hi, Yu > > > From: Chen, Yu C > > Sent: Tuesday, November 10, 2015 5:43 PM > > > > Hi, Lv > > Sorry for my late feedback on the patch, one minor nit below: > > > > > From: Zheng, Lv > > > Sent: Tuesday, November 10, 2015

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Chen, Yu C
Hi, > -Original Message- > From: Zheng, Lv > Sent: Wednesday, November 11, 2015 1:07 PM > To: Chen, Yu C > Cc: Lv Zheng; linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; > Wysocki, Rafael J; Brown, Len > Subject: RE: [PATCH v2 5/7] ACPI / x86: intro

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Zheng, Lv
Hi, Yu > From: Chen, Yu C > Sent: Tuesday, November 10, 2015 5:43 PM > > Hi, Lv > Sorry for my late feedback on the patch, one minor nit below: > > > From: Zheng, Lv > > Sent: Tuesday, November 10, 2015 4:22 PM > > > > From: Chen Yu > > > > This patch implements acpi_os_readable(). The

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Chen, Yu C
Wysocki, Rafael J; Brown, Len > Subject: Re: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support > > On Tue, Nov 10, 2015 at 11:42 AM, Chen, Yu C wrote: > > Hi, Lv > > Sorry for my late feedback on the patch, one minor nit below: > > >>

Re: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Andy Shevchenko
On Tue, Nov 10, 2015 at 11:42 AM, Chen, Yu C wrote: > Hi, Lv > Sorry for my late feedback on the patch, one minor nit below: >> + start_pfn = page_to_pfn(virt_to_page(pointer)); >> + end_pfn = page_to_pfn(virt_to_page(pointer + length)); > Convert pointer to char* first? > end_pfn =

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Chen, Yu C
> -Original Message- > From: Chen, Yu C > Sent: Tuesday, November 10, 2015 5:43 PM > To: Zheng, Lv > Cc: Lv Zheng; linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; > Wysocki, Rafael J; Brown, Len > Subject: RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Chen, Yu C
Hi, Lv Sorry for my late feedback on the patch, one minor nit below: > -Original Message- > From: Zheng, Lv > Sent: Tuesday, November 10, 2015 4:22 PM > To: Wysocki, Rafael J; Brown, Len > Cc: Zheng, Lv; Lv Zheng; linux-kernel@vger.kernel.org; linux- > a...@vger.kernel.org; Chen, Yu C >

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Chen, Yu C
Hi, Lv Sorry for my late feedback on the patch, one minor nit below: > -Original Message- > From: Zheng, Lv > Sent: Tuesday, November 10, 2015 4:22 PM > To: Wysocki, Rafael J; Brown, Len > Cc: Zheng, Lv; Lv Zheng; linux-kernel@vger.kernel.org; linux- > a...@vger.kernel.org; Chen, Yu C >

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Chen, Yu C
> -Original Message- > From: Chen, Yu C > Sent: Tuesday, November 10, 2015 5:43 PM > To: Zheng, Lv > Cc: Lv Zheng; linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; > Wysocki, Rafael J; Brown, Len > Subject: RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Zheng, Lv
Hi, Yu > From: Chen, Yu C > Sent: Tuesday, November 10, 2015 5:43 PM > > Hi, Lv > Sorry for my late feedback on the patch, one minor nit below: > > > From: Zheng, Lv > > Sent: Tuesday, November 10, 2015 4:22 PM > > > > From: Chen Yu > > > > This patch implements

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Chen, Yu C
Hi, > -Original Message- > From: Zheng, Lv > Sent: Wednesday, November 11, 2015 1:07 PM > To: Chen, Yu C > Cc: Lv Zheng; linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; > Wysocki, Rafael J; Brown, Len > Subject: RE: [PATCH v2 5/7] ACPI / x86: intro

Re: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Andy Shevchenko
On Tue, Nov 10, 2015 at 11:42 AM, Chen, Yu C wrote: > Hi, Lv > Sorry for my late feedback on the patch, one minor nit below: >> + start_pfn = page_to_pfn(virt_to_page(pointer)); >> + end_pfn = page_to_pfn(virt_to_page(pointer + length)); > Convert pointer to char*

RE: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support

2015-11-10 Thread Chen, Yu C
Wysocki, Rafael J; Brown, Len > Subject: Re: [PATCH v2 5/7] ACPI / x86: introduce acpi_os_readable() support > > On Tue, Nov 10, 2015 at 11:42 AM, Chen, Yu C <yu.c.c...@intel.com> wrote: > > Hi, Lv > > Sorry for my late feedback on the patch, one minor nit below: > > &g