Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-16 Thread David Miller
From: David Laight Date: Thu, 16 Mar 2017 12:12:06 + > From: Shannon Nelson >> Sent: 16 March 2017 00:18 >> To: David Laight; net...@vger.kernel.org; da...@davemloft.net >> On 3/15/2017 1:50 AM, David Laight wrote: >> > From: Shannon Nelson >> >> Sent: 14 March 2017

Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-16 Thread David Miller
From: David Laight Date: Thu, 16 Mar 2017 12:12:06 + > From: Shannon Nelson >> Sent: 16 March 2017 00:18 >> To: David Laight; net...@vger.kernel.org; da...@davemloft.net >> On 3/15/2017 1:50 AM, David Laight wrote: >> > From: Shannon Nelson >> >> Sent: 14 March 2017 17:25 >> > ... >> >> + if

RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-16 Thread David Laight
From: Shannon Nelson > Sent: 16 March 2017 00:18 > To: David Laight; net...@vger.kernel.org; da...@davemloft.net > On 3/15/2017 1:50 AM, David Laight wrote: > > From: Shannon Nelson > >> Sent: 14 March 2017 17:25 > > ... > >> + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) > >> +

RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-16 Thread David Laight
From: Shannon Nelson > Sent: 16 March 2017 00:18 > To: David Laight; net...@vger.kernel.org; da...@davemloft.net > On 3/15/2017 1:50 AM, David Laight wrote: > > From: Shannon Nelson > >> Sent: 14 March 2017 17:25 > > ... > >> + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) > >> +

Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-15 Thread Shannon Nelson
On 3/15/2017 1:50 AM, David Laight wrote: From: Shannon Nelson Sent: 14 March 2017 17:25 ... + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) + dev->stats.multicast++; I'd guess that: dev->stats.multicast +=

Re: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-15 Thread Shannon Nelson
On 3/15/2017 1:50 AM, David Laight wrote: From: Shannon Nelson Sent: 14 March 2017 17:25 ... + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) + dev->stats.multicast++; I'd guess that: dev->stats.multicast +=

RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-15 Thread David Laight
From: Shannon Nelson > Sent: 14 March 2017 17:25 ... > + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) > + dev->stats.multicast++; I'd guess that: dev->stats.multicast += is_multicast_ether_addr(eth_hdr(skb)->h_dest); generates faster code. Especially if

RE: [PATCH v2 net-next 4/5] sunvnet: count multicast packets

2017-03-15 Thread David Laight
From: Shannon Nelson > Sent: 14 March 2017 17:25 ... > + if (unlikely(is_multicast_ether_addr(eth_hdr(skb)->h_dest))) > + dev->stats.multicast++; I'd guess that: dev->stats.multicast += is_multicast_ether_addr(eth_hdr(skb)->h_dest); generates faster code. Especially if