Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp

2016-09-02 Thread Doug Ledford 
On 8/29/2016 10:26 AM, Steve Wise wrote:
>> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>>
>> We get 1 warning when build kernel with W=1:
>> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
>> '_free_qp' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is declared
>> and don't need a declaration, but can be made static.
>> so this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie 
>> Reviewed-by: Yuval Shaia 
>> Reviewed-by: Leon Romanovsky 
> 
> Ignore my comment on v2...
> 
> Acked-by: Steve Wise 
> 

Thanks, applied.

-- 
Doug Ledford 
GPG Key ID: 0E572FDD



signature.asc
Description: OpenPGP digital signature

Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp

2016-09-02 Thread Doug Ledford 
On 8/29/2016 10:26 AM, Steve Wise wrote:
>> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
>>
>> We get 1 warning when build kernel with W=1:
>> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
>> '_free_qp' [-Wmissing-prototypes]
>>
>> In fact, this function is only used in the file in which it is declared
>> and don't need a declaration, but can be made static.
>> so this patch marks it 'static'.
>>
>> Signed-off-by: Baoyou Xie 
>> Reviewed-by: Yuval Shaia 
>> Reviewed-by: Leon Romanovsky 
> 
> Ignore my comment on v2...
> 
> Acked-by: Steve Wise 
> 

Thanks, applied.

-- 
Doug Ledford 
GPG Key ID: 0E572FDD



signature.asc
Description: OpenPGP digital signature

RE: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp

2016-08-29 Thread Steve Wise 
> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
> 
> We get 1 warning when build kernel with W=1:
> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
> '_free_qp' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie 
> Reviewed-by: Yuval Shaia 
> Reviewed-by: Leon Romanovsky 

Ignore my comment on v2...

Acked-by: Steve Wise

RE: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp

2016-08-29 Thread Steve Wise 
> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp
> 
> We get 1 warning when build kernel with W=1:
> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for
> '_free_qp' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie 
> Reviewed-by: Yuval Shaia 
> Reviewed-by: Leon Romanovsky 

Ignore my comment on v2...

Acked-by: Steve Wise